archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-16 05:58:45 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Promote invalid mode/unknow option from Warning to ValueError for plain streams.

Browse source 
Closes GH-5076
This commit is contained in:
George Peter Banyard 2020-02-04 22:25:43 +01:00
parent 2efa0b3bfa
commit b3f17ea5d5
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
main/streams/plain_wrapper.c
View file

@ -1029,7 +1029,7 @@ PHPAPI php_stream *_php_stream_fopen(const char *filename, const char *mode, zen
if (FAILURE == php_stream_parse_fopen_modes(mode, &open_flags)) { if (FAILURE == php_stream_parse_fopen_modes(mode, &open_flags)) {
if (options & REPORT_ERRORS) { if (options & REPORT_ERRORS) {
php_error_docref(NULL, E_WARNING, "`%s' is not a valid mode for fopen", mode); zend_value_error("`%s' is not a valid mode for fopen", mode);
} }
return NULL; return NULL;
} }
@ -1464,7 +1464,7 @@ static int php_plain_files_metadata(php_stream_wrapper *wrapper, const char *url
ret = VCWD_CHMOD(url, mode); ret = VCWD_CHMOD(url, mode);
break; break;
default: default:
php_error_docref1(NULL, url, E_WARNING, "Unknown option %d for stream_metadata", option); zend_value_error("Unknown option %d for stream_metadata", option);
return 0; return 0;
} }
if (ret == -1) { if (ret == -1) {