archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-16 05:58:45 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

ext/dba: php_dba_make_key() only returns NULL when an exception occurs

Browse source
This commit is contained in:
Gina Peter Banyard 2024-10-04 14:35:41 +01:00
parent 41217bb06c
commit b445641dd7
1 changed files with 4 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

12
ext/dba/dba.c
View file

@ -478,8 +478,7 @@ static void php_dba_update(INTERNAL_FUNCTION_PARAMETERS, int mode)
if (key_ht) { if (key_ht) {
key_str = php_dba_make_key(key_ht); key_str = php_dba_make_key(key_ht);
if (!key_str) { if (!key_str) {
// TODO ValueError? RETURN_THROWS();
RETURN_FALSE;
} }
} }
@ -1003,8 +1002,7 @@ PHP_FUNCTION(dba_exists)
if (key_ht) { if (key_ht) {
key_str = php_dba_make_key(key_ht); key_str = php_dba_make_key(key_ht);
if (!key_str) { if (!key_str) {
// TODO ValueError? RETURN_THROWS();
RETURN_FALSE;
} }
} }
@ -1050,8 +1048,7 @@ PHP_FUNCTION(dba_fetch)
if (key_ht) { if (key_ht) {
key_str = php_dba_make_key(key_ht); key_str = php_dba_make_key(key_ht);
if (!key_str) { if (!key_str) {
// TODO ValueError? RETURN_THROWS();
RETURN_FALSE;
} }
} }
@ -1184,8 +1181,7 @@ PHP_FUNCTION(dba_delete)
if (key_ht) { if (key_ht) {
key_str = php_dba_make_key(key_ht); key_str = php_dba_make_key(key_ht);
if (!key_str) { if (!key_str) {
// TODO ValueError? RETURN_THROWS();
RETURN_FALSE;
} }
} }