From b8abd2693e1885cfe11aea10ed360da6214c746b Mon Sep 17 00:00:00 2001
From: Niels Dossche <7771979+nielsdos@users.noreply.github.com>
Date: Sat, 4 May 2024 16:00:47 +0200
Subject: [PATCH] Increase test coverage of _bc_do_add() (#14131)

The final carry code was not tested.
---
 ext/bcmath/tests/bcadd.phpt | 79 ++++++++++++++++++++++++++++++++++++-
 1 file changed, 78 insertions(+), 1 deletion(-)

diff --git a/ext/bcmath/tests/bcadd.phpt b/ext/bcmath/tests/bcadd.phpt
index 188d8228e54..fbef355c4fa 100644
--- a/ext/bcmath/tests/bcadd.phpt
+++ b/ext/bcmath/tests/bcadd.phpt
@@ -8,7 +8,7 @@ bcmath.scale=0
 <?php
 require(__DIR__ . "/run_bcmath_tests_function.inc");
 
-$leftSummands = ["15", "-15", "1", "-9", "14.14", "-16.60", "0.15", "-0.01"];
+$leftSummands = ["15", "-15", "1", "-9", "14.14", "-16.60", "0.15", "-0.01", "99"];
 $rightSummands = array_merge($leftSummands, [
     "0",
     "0.00",
@@ -20,6 +20,7 @@ $rightSummands = array_merge($leftSummands, [
     "-149143276547656984948124912",
     "0.1322135476547459213732911312",
     "-0.123912932193769965476541321",
+    "2",
 ]);
 
 run_bcmath_tests($leftSummands, $rightSummands, "+", bcadd(...));
@@ -35,6 +36,7 @@ Number "15" (scale 0)
 15 + -16.60                         = -1
 15 + 0.15                           = 15
 15 + -0.01                          = 14
+15 + 99                             = 114
 15 + 0                              = 15
 15 + 0.00                           = 15
 15 + -0                             = 15
@@ -45,6 +47,7 @@ Number "15" (scale 0)
 15 + -149143276547656984948124912   = -149143276547656984948124897
 15 + 0.1322135476547459213732911312 = 15
 15 + -0.123912932193769965476541321 = 14
+15 + 2                              = 17
 
 Number "-15" (scale 0)
 -15 + 15                             = 0
@@ -55,6 +58,7 @@ Number "-15" (scale 0)
 -15 + -16.60                         = -31
 -15 + 0.15                           = -14
 -15 + -0.01                          = -15
+-15 + 99                             = 84
 -15 + 0                              = -15
 -15 + 0.00                           = -15
 -15 + -0                             = -15
@@ -65,6 +69,7 @@ Number "-15" (scale 0)
 -15 + -149143276547656984948124912   = -149143276547656984948124927
 -15 + 0.1322135476547459213732911312 = -14
 -15 + -0.123912932193769965476541321 = -15
+-15 + 2                              = -13
 
 Number "1" (scale 0)
 1 + 15                             = 16
@@ -75,6 +80,7 @@ Number "1" (scale 0)
 1 + -16.60                         = -15
 1 + 0.15                           = 1
 1 + -0.01                          = 0
+1 + 99                             = 100
 1 + 0                              = 1
 1 + 0.00                           = 1
 1 + -0                             = 1
@@ -85,6 +91,7 @@ Number "1" (scale 0)
 1 + -149143276547656984948124912   = -149143276547656984948124911
 1 + 0.1322135476547459213732911312 = 1
 1 + -0.123912932193769965476541321 = 0
+1 + 2                              = 3
 
 Number "-9" (scale 0)
 -9 + 15                             = 6
@@ -95,6 +102,7 @@ Number "-9" (scale 0)
 -9 + -16.60                         = -25
 -9 + 0.15                           = -8
 -9 + -0.01                          = -9
+-9 + 99                             = 90
 -9 + 0                              = -9
 -9 + 0.00                           = -9
 -9 + -0                             = -9
@@ -105,6 +113,7 @@ Number "-9" (scale 0)
 -9 + -149143276547656984948124912   = -149143276547656984948124921
 -9 + 0.1322135476547459213732911312 = -8
 -9 + -0.123912932193769965476541321 = -9
+-9 + 2                              = -7
 
 Number "14.14" (scale 0)
 14.14 + 15                             = 29
@@ -115,6 +124,7 @@ Number "14.14" (scale 0)
 14.14 + -16.60                         = -2
 14.14 + 0.15                           = 14
 14.14 + -0.01                          = 14
+14.14 + 99                             = 113
 14.14 + 0                              = 14
 14.14 + 0.00                           = 14
 14.14 + -0                             = 14
@@ -125,6 +135,7 @@ Number "14.14" (scale 0)
 14.14 + -149143276547656984948124912   = -149143276547656984948124897
 14.14 + 0.1322135476547459213732911312 = 14
 14.14 + -0.123912932193769965476541321 = 14
+14.14 + 2                              = 16
 
 Number "-16.60" (scale 0)
 -16.60 + 15                             = -1
@@ -135,6 +146,7 @@ Number "-16.60" (scale 0)
 -16.60 + -16.60                         = -33
 -16.60 + 0.15                           = -16
 -16.60 + -0.01                          = -16
+-16.60 + 99                             = 82
 -16.60 + 0                              = -16
 -16.60 + 0.00                           = -16
 -16.60 + -0                             = -16
@@ -145,6 +157,7 @@ Number "-16.60" (scale 0)
 -16.60 + -149143276547656984948124912   = -149143276547656984948124928
 -16.60 + 0.1322135476547459213732911312 = -16
 -16.60 + -0.123912932193769965476541321 = -16
+-16.60 + 2                              = -14
 
 Number "0.15" (scale 0)
 0.15 + 15                             = 15
@@ -155,6 +168,7 @@ Number "0.15" (scale 0)
 0.15 + -16.60                         = -16
 0.15 + 0.15                           = 0
 0.15 + -0.01                          = 0
+0.15 + 99                             = 99
 0.15 + 0                              = 0
 0.15 + 0.00                           = 0
 0.15 + -0                             = 0
@@ -165,6 +179,7 @@ Number "0.15" (scale 0)
 0.15 + -149143276547656984948124912   = -149143276547656984948124911
 0.15 + 0.1322135476547459213732911312 = 0
 0.15 + -0.123912932193769965476541321 = 0
+0.15 + 2                              = 2
 
 Number "-0.01" (scale 0)
 -0.01 + 15                             = 14
@@ -175,6 +190,7 @@ Number "-0.01" (scale 0)
 -0.01 + -16.60                         = -16
 -0.01 + 0.15                           = 0
 -0.01 + -0.01                          = 0
+-0.01 + 99                             = 98
 -0.01 + 0                              = 0
 -0.01 + 0.00                           = 0
 -0.01 + -0                             = 0
@@ -185,6 +201,29 @@ Number "-0.01" (scale 0)
 -0.01 + -149143276547656984948124912   = -149143276547656984948124912
 -0.01 + 0.1322135476547459213732911312 = 0
 -0.01 + -0.123912932193769965476541321 = 0
+-0.01 + 2                              = 1
+
+Number "99" (scale 0)
+99 + 15                             = 114
+99 + -15                            = 84
+99 + 1                              = 100
+99 + -9                             = 90
+99 + 14.14                          = 113
+99 + -16.60                         = 82
+99 + 0.15                           = 99
+99 + -0.01                          = 98
+99 + 99                             = 198
+99 + 0                              = 99
+99 + 0.00                           = 99
+99 + -0                             = 99
+99 + -0.00                          = 99
+99 + 15151324141414.412312232141241 = 15151324141513
+99 + -132132245132134.1515123765412 = -132132245132035
+99 + 141241241241241248267654747412 = 141241241241241248267654747511
+99 + -149143276547656984948124912   = -149143276547656984948124813
+99 + 0.1322135476547459213732911312 = 99
+99 + -0.123912932193769965476541321 = 98
+99 + 2                              = 101
 
 Number "15" (scale 10)
 15 + 15                             = 30.0000000000
@@ -195,6 +234,7 @@ Number "15" (scale 10)
 15 + -16.60                         = -1.6000000000
 15 + 0.15                           = 15.1500000000
 15 + -0.01                          = 14.9900000000
+15 + 99                             = 114.0000000000
 15 + 0                              = 15.0000000000
 15 + 0.00                           = 15.0000000000
 15 + -0                             = 15.0000000000
@@ -205,6 +245,7 @@ Number "15" (scale 10)
 15 + -149143276547656984948124912   = -149143276547656984948124897.0000000000
 15 + 0.1322135476547459213732911312 = 15.1322135476
 15 + -0.123912932193769965476541321 = 14.8760870678
+15 + 2                              = 17.0000000000
 
 Number "-15" (scale 10)
 -15 + 15                             = 0.0000000000
@@ -215,6 +256,7 @@ Number "-15" (scale 10)
 -15 + -16.60                         = -31.6000000000
 -15 + 0.15                           = -14.8500000000
 -15 + -0.01                          = -15.0100000000
+-15 + 99                             = 84.0000000000
 -15 + 0                              = -15.0000000000
 -15 + 0.00                           = -15.0000000000
 -15 + -0                             = -15.0000000000
@@ -225,6 +267,7 @@ Number "-15" (scale 10)
 -15 + -149143276547656984948124912   = -149143276547656984948124927.0000000000
 -15 + 0.1322135476547459213732911312 = -14.8677864523
 -15 + -0.123912932193769965476541321 = -15.1239129321
+-15 + 2                              = -13.0000000000
 
 Number "1" (scale 10)
 1 + 15                             = 16.0000000000
@@ -235,6 +278,7 @@ Number "1" (scale 10)
 1 + -16.60                         = -15.6000000000
 1 + 0.15                           = 1.1500000000
 1 + -0.01                          = 0.9900000000
+1 + 99                             = 100.0000000000
 1 + 0                              = 1.0000000000
 1 + 0.00                           = 1.0000000000
 1 + -0                             = 1.0000000000
@@ -245,6 +289,7 @@ Number "1" (scale 10)
 1 + -149143276547656984948124912   = -149143276547656984948124911.0000000000
 1 + 0.1322135476547459213732911312 = 1.1322135476
 1 + -0.123912932193769965476541321 = 0.8760870678
+1 + 2                              = 3.0000000000
 
 Number "-9" (scale 10)
 -9 + 15                             = 6.0000000000
@@ -255,6 +300,7 @@ Number "-9" (scale 10)
 -9 + -16.60                         = -25.6000000000
 -9 + 0.15                           = -8.8500000000
 -9 + -0.01                          = -9.0100000000
+-9 + 99                             = 90.0000000000
 -9 + 0                              = -9.0000000000
 -9 + 0.00                           = -9.0000000000
 -9 + -0                             = -9.0000000000
@@ -265,6 +311,7 @@ Number "-9" (scale 10)
 -9 + -149143276547656984948124912   = -149143276547656984948124921.0000000000
 -9 + 0.1322135476547459213732911312 = -8.8677864523
 -9 + -0.123912932193769965476541321 = -9.1239129321
+-9 + 2                              = -7.0000000000
 
 Number "14.14" (scale 10)
 14.14 + 15                             = 29.1400000000
@@ -275,6 +322,7 @@ Number "14.14" (scale 10)
 14.14 + -16.60                         = -2.4600000000
 14.14 + 0.15                           = 14.2900000000
 14.14 + -0.01                          = 14.1300000000
+14.14 + 99                             = 113.1400000000
 14.14 + 0                              = 14.1400000000
 14.14 + 0.00                           = 14.1400000000
 14.14 + -0                             = 14.1400000000
@@ -285,6 +333,7 @@ Number "14.14" (scale 10)
 14.14 + -149143276547656984948124912   = -149143276547656984948124897.8600000000
 14.14 + 0.1322135476547459213732911312 = 14.2722135476
 14.14 + -0.123912932193769965476541321 = 14.0160870678
+14.14 + 2                              = 16.1400000000
 
 Number "-16.60" (scale 10)
 -16.60 + 15                             = -1.6000000000
@@ -295,6 +344,7 @@ Number "-16.60" (scale 10)
 -16.60 + -16.60                         = -33.2000000000
 -16.60 + 0.15                           = -16.4500000000
 -16.60 + -0.01                          = -16.6100000000
+-16.60 + 99                             = 82.4000000000
 -16.60 + 0                              = -16.6000000000
 -16.60 + 0.00                           = -16.6000000000
 -16.60 + -0                             = -16.6000000000
@@ -305,6 +355,7 @@ Number "-16.60" (scale 10)
 -16.60 + -149143276547656984948124912   = -149143276547656984948124928.6000000000
 -16.60 + 0.1322135476547459213732911312 = -16.4677864523
 -16.60 + -0.123912932193769965476541321 = -16.7239129321
+-16.60 + 2                              = -14.6000000000
 
 Number "0.15" (scale 10)
 0.15 + 15                             = 15.1500000000
@@ -315,6 +366,7 @@ Number "0.15" (scale 10)
 0.15 + -16.60                         = -16.4500000000
 0.15 + 0.15                           = 0.3000000000
 0.15 + -0.01                          = 0.1400000000
+0.15 + 99                             = 99.1500000000
 0.15 + 0                              = 0.1500000000
 0.15 + 0.00                           = 0.1500000000
 0.15 + -0                             = 0.1500000000
@@ -325,6 +377,7 @@ Number "0.15" (scale 10)
 0.15 + -149143276547656984948124912   = -149143276547656984948124911.8500000000
 0.15 + 0.1322135476547459213732911312 = 0.2822135476
 0.15 + -0.123912932193769965476541321 = 0.0260870678
+0.15 + 2                              = 2.1500000000
 
 Number "-0.01" (scale 10)
 -0.01 + 15                             = 14.9900000000
@@ -335,6 +388,7 @@ Number "-0.01" (scale 10)
 -0.01 + -16.60                         = -16.6100000000
 -0.01 + 0.15                           = 0.1400000000
 -0.01 + -0.01                          = -0.0200000000
+-0.01 + 99                             = 98.9900000000
 -0.01 + 0                              = -0.0100000000
 -0.01 + 0.00                           = -0.0100000000
 -0.01 + -0                             = -0.0100000000
@@ -345,3 +399,26 @@ Number "-0.01" (scale 10)
 -0.01 + -149143276547656984948124912   = -149143276547656984948124912.0100000000
 -0.01 + 0.1322135476547459213732911312 = 0.1222135476
 -0.01 + -0.123912932193769965476541321 = -0.1339129321
+-0.01 + 2                              = 1.9900000000
+
+Number "99" (scale 10)
+99 + 15                             = 114.0000000000
+99 + -15                            = 84.0000000000
+99 + 1                              = 100.0000000000
+99 + -9                             = 90.0000000000
+99 + 14.14                          = 113.1400000000
+99 + -16.60                         = 82.4000000000
+99 + 0.15                           = 99.1500000000
+99 + -0.01                          = 98.9900000000
+99 + 99                             = 198.0000000000
+99 + 0                              = 99.0000000000
+99 + 0.00                           = 99.0000000000
+99 + -0                             = 99.0000000000
+99 + -0.00                          = 99.0000000000
+99 + 15151324141414.412312232141241 = 15151324141513.4123122321
+99 + -132132245132134.1515123765412 = -132132245132035.1515123765
+99 + 141241241241241248267654747412 = 141241241241241248267654747511.0000000000
+99 + -149143276547656984948124912   = -149143276547656984948124813.0000000000
+99 + 0.1322135476547459213732911312 = 99.1322135476
+99 + -0.123912932193769965476541321 = 98.8760870678
+99 + 2                              = 101.0000000000