archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-21 01:45:16 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

MFB: Fixed bug #39648 (Implementation of PHP functions chown() and chgrp()

Browse source 
are not thread safe).
This commit is contained in:
Ilia Alshanetsky 2006-11-29 23:46:25 +00:00
parent 573ff9aaa5
commit b9e264d497
1 changed files with 32 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

33
ext/standard/filestat.c
View file

@ -417,14 +417,29 @@ static void php_do_chgrp(INTERNAL_FUNCTION_PARAMETERS, int do_lchgrp)
if (Z_TYPE_P(group) == IS_LONG) {
gid = (gid_t)Z_LVAL_P(group);
} else {
struct group *gr;
#if HAVE_GETGRNAM_R
struct group gr;
struct group *retgrptr;
int grbuflen = sysconf(_SC_GETGR_R_SIZE_MAX);
char *grbuf = emalloc(grbuflen);
convert_to_string(group);
if (getgrnam_r(Z_STRVAL_PP(group), &gr, grbuf, grbuflen, &retgrptr) != 0 || retgrptr == NULL) {
php_error_docref(NULL TSRMLS_CC, E_WARNING, "Unable to find gid for %s", Z_STRVAL_PP(group));
efree(grbuf);
RETURN_FALSE;
}
efree(grbuf);
gid = gr.gr_gid;
#else
struct group *gr;
convert_to_string(group);
if (!(gr = getgrnam(Z_STRVAL_P(group)))) {
php_error_docref(NULL TSRMLS_CC, E_WARNING, "Unable to find gid for %s", Z_STRVAL_P(group));
RETURN_FALSE;
}
gid = gr->gr_gid;
#endif
}
if (filename_type == IS_UNICODE) {
@ -506,6 +521,21 @@ static void php_do_chown(INTERNAL_FUNCTION_PARAMETERS, int do_lchown)
if (Z_TYPE_P(user) == IS_LONG) {
uid = (uid_t)Z_LVAL_P(user);
} else {
#ifdef HAVE_GETPWNAM_R
struct passwd pw;
struct passwd *retpwptr = NULL;
int pwbuflen = sysconf(_SC_GETPW_R_SIZE_MAX);
char *pwbuf = emalloc(pwbuflen);
convert_to_string(user);
if (getpwnam_r(Z_STRVAL_PP(user), &pw, pwbuf, pwbuflen, &retpwptr) != 0 || retpwptr == NULL) {
php_error_docref(NULL TSRMLS_CC, E_WARNING, "Unable to find uid for %s", Z_STRVAL_PP(user));
efree(pwbuf);
RETURN_FALSE;
}
efree(pwbuf);
uid = pw.pw_uid;
#else
struct passwd *pw;
convert_to_string(user);
@ -514,6 +544,7 @@ static void php_do_chown(INTERNAL_FUNCTION_PARAMETERS, int do_lchown)
RETURN_FALSE;
}
uid = pw->pw_uid;
#endif
}
if (filename_type == IS_UNICODE) {