archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-15 21:48:51 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Improve fix for bug #73807

Browse source 
At least on some architectures memmove() on FreeBSD does not
short-curcuit if src==dst. Check for it explicitly to avoid
quadratic copying.
This commit is contained in:
Nikita Popov 2017-02-25 12:55:14 +01:00
parent eac8166bd4
commit bbfa1b6419
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
main/php_variables.c
View file

@ -311,7 +311,7 @@ static inline int add_post_vars(zval *arr, post_var_data_t *vars, zend_bool eof)
}
}
if (!eof) {
if (!eof && ZSTR_VAL(vars->str.s) != vars->ptr) {
memmove(ZSTR_VAL(vars->str.s), vars->ptr, ZSTR_LEN(vars->str.s) = vars->end - vars->ptr);
}
return SUCCESS;