archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-15 21:48:51 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Remove always-true check in pdo_stmt.c (#17535)

Browse source 
`check_empty` is checked earlier up, so this variable is always true.
This commit is contained in:
Niels Dossche 2025-01-21 19:20:57 +01:00 • committed by GitHub
parent 1aaf2b1899
commit c218f62920
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
ext/pdo/pdo_stmt.c
View file

@ -2360,7 +2360,7 @@ static int row_dim_exists(zend_object *object, zval *offset, int check_empty)
return false;
}
ZEND_ASSERT(retval == &tmp_val);
bool res = check_empty ? i_zend_is_true(retval) : Z_TYPE(tmp_val) != IS_NULL;
bool res = i_zend_is_true(retval);
zval_ptr_dtor_nogc(retval);
return res;
} else {