archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-15 21:48:51 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[run-tests.php] Replace backtick operator string literals with shell_exec() calls

Browse source 
The rationale is that `shell_exec()` is identical to the backtick operator (both of which are disabled when `shell_exec` function is disabled) makes it very clear that it is a shell execution, and eases security audits too.
This commit is contained in:
Ayesh Karunaratne 2022-07-09 22:34:59 +05:30 • committed by George Peter Banyard
parent f958701dad
commit c83a10d8db
1 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

14
run-tests.php
View file

@ -843,11 +843,11 @@ More .INIs : " , (function_exists(\'php_ini_scanned_files\') ? str_replace("\n"
$info_params = []; $info_params = [];
settings2array($ini_overwrites, $info_params); settings2array($ini_overwrites, $info_params);
$info_params = settings2params($info_params); $info_params = settings2params($info_params);
$php_info = `$php $pass_options $info_params $no_file_cache "$info_file"`; $php_info = shell_exec("$php $pass_options $info_params $no_file_cache \"$info_file\"");
define('TESTED_PHP_VERSION', `$php -n -r "echo PHP_VERSION;"`); define('TESTED_PHP_VERSION', shell_exec("$php -n -r \"echo PHP_VERSION;\""));
if ($php_cgi && $php != $php_cgi) { if ($php_cgi && $php != $php_cgi) {
$php_info_cgi = `$php_cgi $pass_options $info_params $no_file_cache -q "$info_file"`; $php_info_cgi = shell_exec("$php_cgi $pass_options $info_params $no_file_cache -q \"$info_file\"");
$php_info_sep = "\n---------------------------------------------------------------------"; $php_info_sep = "\n---------------------------------------------------------------------";
$php_cgi_info = "$php_info_sep\nPHP : $php_cgi $php_info_cgi$php_info_sep"; $php_cgi_info = "$php_info_sep\nPHP : $php_cgi $php_info_cgi$php_info_sep";
} else { } else {
@ -855,7 +855,7 @@ More .INIs : " , (function_exists(\'php_ini_scanned_files\') ? str_replace("\n"
} }
if ($phpdbg) { if ($phpdbg) {
$phpdbg_info = `$phpdbg $pass_options $info_params $no_file_cache -qrr "$info_file"`; $phpdbg_info = shell_exec("$phpdbg $pass_options $info_params $no_file_cache -qrr \"$info_file\"");
$php_info_sep = "\n---------------------------------------------------------------------"; $php_info_sep = "\n---------------------------------------------------------------------";
$phpdbg_info = "$php_info_sep\nPHP : $phpdbg $phpdbg_info$php_info_sep"; $phpdbg_info = "$php_info_sep\nPHP : $phpdbg $phpdbg_info$php_info_sep";
} else { } else {
@ -883,7 +883,7 @@ More .INIs : " , (function_exists(\'php_ini_scanned_files\') ? str_replace("\n"
} }
?> ?>
PHP); PHP);
$exts_to_test = explode(',', `$php $pass_options $info_params $no_file_cache "$info_file"`); $exts_to_test = explode(',', shell_exec("$php $pass_options $info_params $no_file_cache \"$info_file\""));
// check for extensions that need special handling and regenerate // check for extensions that need special handling and regenerate
$info_params_ex = [ $info_params_ex = [
'session' => ['session.auto_start=0'], 'session' => ['session.auto_start=0'],
@ -3652,8 +3652,8 @@ class SkipCache
return $this->extensions[$php]; return $this->extensions[$php];
} }
$extDir = `$php -d display_errors=0 -r "echo ini_get('extension_dir');"`; $extDir = shell_exec("$php -d display_errors=0 -r \"echo ini_get('extension_dir');\"");
$extensions = explode(",", `$php -d display_errors=0 -r "echo implode(',', get_loaded_extensions());"`); $extensions = explode(",", shell_exec("$php -d display_errors=0 -r \"echo implode(',', get_loaded_extensions());\""));
$extensions = array_map('strtolower', $extensions); $extensions = array_map('strtolower', $extensions);
if (in_array('zend opcache', $extensions)) { if (in_array('zend opcache', $extensions)) {
$extensions[] = 'opcache'; $extensions[] = 'opcache';