From cddb5eb3e9ff3af9fdff8b849bae67e4d3c7bd03 Mon Sep 17 00:00:00 2001 From: Dmitry Stogov Date: Tue, 14 Apr 2015 00:57:45 +0300 Subject: [PATCH] Fixed memory leak --- Zend/zend_execute.h | 2 +- ext/standard/tests/serialize/unserialize_mem_leak.phpt | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/Zend/zend_execute.h b/Zend/zend_execute.h index 408a7c50327..a3844b2a474 100644 --- a/Zend/zend_execute.h +++ b/Zend/zend_execute.h @@ -200,7 +200,7 @@ static zend_always_inline void zend_vm_stack_free_extra_args(zend_execute_data * zval *p = end + (ZEND_CALL_NUM_ARGS(call) - call->func->op_array.num_args); do { p--; - zval_ptr_dtor_nogc(p); + i_zval_ptr_dtor(p ZEND_FILE_LINE_CC); } while (p != end); } } diff --git a/ext/standard/tests/serialize/unserialize_mem_leak.phpt b/ext/standard/tests/serialize/unserialize_mem_leak.phpt index d27ca2b4229..97c59f9ad1c 100644 --- a/ext/standard/tests/serialize/unserialize_mem_leak.phpt +++ b/ext/standard/tests/serialize/unserialize_mem_leak.phpt @@ -1,7 +1,5 @@ --TEST-- Memleaks if unserialize return a self-referenced array/object ---XFAIL-- -To fix this, we need change zval_ptr_dtor_nogc to zval_ptr_dtor in free_args, but it will introduce slowdown. mark this XFAIL now. we may find better fix later. --INI-- report_memleaks=1 --FILE--