archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-15 21:48:51 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix potential NULL pointer argument to memcpy (#13859)

Browse source 
This is only possible when the length is 0, but memcpy doesn't like NULL
pointers, as UBSAN trips over it.
This commit is contained in:
Niels Dossche 2024-04-01 22:47:38 +02:00 • committed by GitHub
parent eb1cdb5b72
commit ce2dd0b20b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
ext/dom/html5_parser.c
View file

@ -86,7 +86,9 @@ static xmlNodePtr lexbor_libxml2_bridge_new_text_node_fast(xmlDocPtr lxml_doc, c
lxml_text->type = XML_TEXT_NODE; lxml_text->type = XML_TEXT_NODE;
lxml_text->doc = lxml_doc; lxml_text->doc = lxml_doc;
lxml_text->content = BAD_CAST &lxml_text->properties; lxml_text->content = BAD_CAST &lxml_text->properties;
memcpy(lxml_text->content, data, data_length); if (data != NULL) {
memcpy(lxml_text->content, data, data_length);
}
return lxml_text; return lxml_text;
} else { } else {
return xmlNewDocTextLen(lxml_doc, (const xmlChar *) data, data_length); return xmlNewDocTextLen(lxml_doc, (const xmlChar *) data, data_length);