From cf7c5921436caa718e9c07fb8ce9b8d56b7333ed Mon Sep 17 00:00:00 2001 From: Niels Dossche <7771979+nielsdos@users.noreply.github.com> Date: Mon, 29 Apr 2024 20:45:31 +0200 Subject: [PATCH] Simplify property check in php_libxml_node_free_resource() --- ext/libxml/libxml.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/ext/libxml/libxml.c b/ext/libxml/libxml.c index 5fec0fa7ba3..e32e46a6480 100644 --- a/ext/libxml/libxml.c +++ b/ext/libxml/libxml.c @@ -1406,18 +1406,8 @@ PHP_LIBXML_API void php_libxml_node_free_resource(xmlNodePtr node) default: if (node->parent == NULL || node->type == XML_NAMESPACE_DECL) { php_libxml_node_free_list((xmlNodePtr) node->children); - switch (node->type) { - /* Skip property freeing for the following types */ - case XML_ATTRIBUTE_DECL: - case XML_DTD_NODE: - case XML_DOCUMENT_TYPE_NODE: - case XML_ENTITY_DECL: - case XML_ATTRIBUTE_NODE: - case XML_NAMESPACE_DECL: - case XML_TEXT_NODE: - break; - default: - php_libxml_node_free_list((xmlNodePtr) node->properties); + if (node->type == XML_ELEMENT_NODE) { + php_libxml_node_free_list((xmlNodePtr) node->properties); } php_libxml_unregister_node(node); php_libxml_node_free(node);