- #50563, removing E_WARNING from parse_url()

NEWS

@@ -194,6 +194,10 @@ PHP                                                                        NEWS
   if defined in WSDL). (mephius at gmail dot com)
 - Fixed bug #50731 (Inconsistent namespaces sent to functions registered with
   spl_autoload_register). (Felipe)
+- Fixed bug #50563 (removing E_WARNING from parse_url). (ralph at smashlabs dot 
+  com, Pierre)
+- Fixed bug #50578 (incorrect shebang in phar.phar). (Fedora at FamilleCollet
+  dot com)
 - Fixed bug #50555 (DateTime::sub() allows 'relative' time modifications). (Derick)
 - Fixed bug #50392 (date_create_from_format enforces 6 digits for 'u' format
   character). (Derick)
@@ -202,6 +206,8 @@ PHP                                                                        NEWS
 - Fixed bug #50358 (Compile failure compiling ext/phar/util.lo). (Felipe)
 - Fixed bug #50101 (name clash between global and local variable).
   (patch by yoarvi at gmail dot com)
+- Fixed bug #51002 (fix possible memory corruption with very long names).
+  (Pierre)
 - Fixed bug #49893 (Crash while creating an instance of Zend_Mail_Storage_Pop3).
   (Dmitry)
 - Fixed bug #49819 (STDOUT losing data with posix_isatty()). (Mike)

ext/standard/tests/url/parse_url_basic_001.phpt

@@ -845,55 +845,29 @@ echo "Done";
   string(1) "/"
 }
 
---> http:///blah.com: 
+--> http:///blah.com: bool(false)
-Warning: parse_url(http:///blah.com): Unable to parse URL in %s on line 15
-bool(false)
 
---> http://:80: 
+--> http://:80: bool(false)
-Warning: parse_url(http://:80): Unable to parse URL in %s on line 15
-bool(false)
 
---> http://user@:80: 
+--> http://user@:80: bool(false)
-Warning: parse_url(http://user@:80): Unable to parse URL in %s on line 15
-bool(false)
 
---> http://user:pass@:80: 
+--> http://user:pass@:80: bool(false)
-Warning: parse_url(http://user:pass@:80): Unable to parse URL in %s on line 15
-bool(false)
 
---> http://:: 
+--> http://:: bool(false)
-Warning: parse_url(http://:): Unable to parse URL in %s on line 15
-bool(false)
 
---> http://@/: 
+--> http://@/: bool(false)
-Warning: parse_url(http://@/): Unable to parse URL in %s on line 15
-bool(false)
 
---> http://@:/: 
+--> http://@:/: bool(false)
-Warning: parse_url(http://@:/): Unable to parse URL in %s on line 15
-bool(false)
 
---> http://:/: 
+--> http://:/: bool(false)
-Warning: parse_url(http://:/): Unable to parse URL in %s on line 15
-bool(false)
 
---> http://?: 
+--> http://?: bool(false)
-Warning: parse_url(http://?): Unable to parse URL in %s on line 15
-bool(false)
 
---> http://?:: 
+--> http://?:: bool(false)
-Warning: parse_url(http://?:): Unable to parse URL in %s on line 15
-bool(false)
 
---> http://:?: 
+--> http://:?: bool(false)
-Warning: parse_url(http://:?): Unable to parse URL in %s on line 15
-bool(false)
 
---> http://blah.com:123456: 
+--> http://blah.com:123456: bool(false)
-Warning: parse_url(http://blah.com:123456): Unable to parse URL in %s on line 15
-bool(false)
 
---> http://blah.com:abcdef: 
+--> http://blah.com:abcdef: bool(false)
-Warning: parse_url(http://blah.com:abcdef): Unable to parse URL in %s on line 15
-bool(false)
 Done

ext/standard/tests/url/parse_url_basic_002.phpt

@@ -109,43 +109,17 @@ echo "Done";
 --> http://[x:80]/   : string(4) "http"
 -->    : NULL
 --> /   : NULL
---> http:///blah.com   : 
+--> http:///blah.com   : bool(false)
-Warning: parse_url(http:///blah.com): Unable to parse URL in %s on line 15
+--> http://:80   : bool(false)
-bool(false)
+--> http://user@:80   : bool(false)
---> http://:80   : 
+--> http://user:pass@:80   : bool(false)
-Warning: parse_url(http://:80): Unable to parse URL in %s on line 15
+--> http://:   : bool(false)
-bool(false)
+--> http://@/   : bool(false)
---> http://user@:80   : 
+--> http://@:/   : bool(false)
-Warning: parse_url(http://user@:80): Unable to parse URL in %s on line 15
+--> http://:/   : bool(false)
-bool(false)
+--> http://?   : bool(false)
---> http://user:pass@:80   : 
+--> http://?:   : bool(false)
-Warning: parse_url(http://user:pass@:80): Unable to parse URL in %s on line 15
+--> http://:?   : bool(false)
-bool(false)
+--> http://blah.com:123456   : bool(false)
---> http://:   : 
+--> http://blah.com:abcdef   : bool(false)
-Warning: parse_url(http://:): Unable to parse URL in %s on line 15
-bool(false)
---> http://@/   : 
-Warning: parse_url(http://@/): Unable to parse URL in %s on line 15
-bool(false)
---> http://@:/   : 
-Warning: parse_url(http://@:/): Unable to parse URL in %s on line 15
-bool(false)
---> http://:/   : 
-Warning: parse_url(http://:/): Unable to parse URL in %s on line 15
-bool(false)
---> http://?   : 
-Warning: parse_url(http://?): Unable to parse URL in %s on line 15
-bool(false)
---> http://?:   : 
-Warning: parse_url(http://?:): Unable to parse URL in %s on line 15
-bool(false)
---> http://:?   : 
-Warning: parse_url(http://:?): Unable to parse URL in %s on line 15
-bool(false)
---> http://blah.com:123456   : 
-Warning: parse_url(http://blah.com:123456): Unable to parse URL in %s on line 15
-bool(false)
---> http://blah.com:abcdef   : 
-Warning: parse_url(http://blah.com:abcdef): Unable to parse URL in %s on line 15
-bool(false)
 Done

ext/standard/tests/url/parse_url_basic_003.phpt

@@ -108,43 +108,17 @@ echo "Done";
 --> http://[x:80]/   : string(6) "[x:80]"
 -->    : NULL
 --> /   : NULL
---> http:///blah.com   : 
+--> http:///blah.com   : bool(false)
-Warning: parse_url(http:///blah.com): Unable to parse URL in %s on line 15
+--> http://:80   : bool(false)
-bool(false)
+--> http://user@:80   : bool(false)
---> http://:80   : 
+--> http://user:pass@:80   : bool(false)
-Warning: parse_url(http://:80): Unable to parse URL in %s on line 15
+--> http://:   : bool(false)
-bool(false)
+--> http://@/   : bool(false)
---> http://user@:80   : 
+--> http://@:/   : bool(false)
-Warning: parse_url(http://user@:80): Unable to parse URL in %s on line 15
+--> http://:/   : bool(false)
-bool(false)
+--> http://?   : bool(false)
---> http://user:pass@:80   : 
+--> http://?:   : bool(false)
-Warning: parse_url(http://user:pass@:80): Unable to parse URL in %s on line 15
+--> http://:?   : bool(false)
-bool(false)
+--> http://blah.com:123456   : bool(false)
---> http://:   : 
+--> http://blah.com:abcdef   : bool(false)
-Warning: parse_url(http://:): Unable to parse URL in %s on line 15
-bool(false)
---> http://@/   : 
-Warning: parse_url(http://@/): Unable to parse URL in %s on line 15
-bool(false)
---> http://@:/   : 
-Warning: parse_url(http://@:/): Unable to parse URL in %s on line 15
-bool(false)
---> http://:/   : 
-Warning: parse_url(http://:/): Unable to parse URL in %s on line 15
-bool(false)
---> http://?   : 
-Warning: parse_url(http://?): Unable to parse URL in %s on line 15
-bool(false)
---> http://?:   : 
-Warning: parse_url(http://?:): Unable to parse URL in %s on line 15
-bool(false)
---> http://:?   : 
-Warning: parse_url(http://:?): Unable to parse URL in %s on line 15
-bool(false)
---> http://blah.com:123456   : 
-Warning: parse_url(http://blah.com:123456): Unable to parse URL in %s on line 15
-bool(false)
---> http://blah.com:abcdef   : 
-Warning: parse_url(http://blah.com:abcdef): Unable to parse URL in %s on line 15
-bool(false)
 Done

ext/standard/tests/url/parse_url_basic_004.phpt

@@ -108,43 +108,17 @@ echo "Done";
 --> http://[x:80]/   : NULL
 -->    : NULL
 --> /   : NULL
---> http:///blah.com   : 
+--> http:///blah.com   : bool(false)
-Warning: parse_url(http:///blah.com): Unable to parse URL in %s on line 15
+--> http://:80   : bool(false)
-bool(false)
+--> http://user@:80   : bool(false)
---> http://:80   : 
+--> http://user:pass@:80   : bool(false)
-Warning: parse_url(http://:80): Unable to parse URL in %s on line 15
+--> http://:   : bool(false)
-bool(false)
+--> http://@/   : bool(false)
---> http://user@:80   : 
+--> http://@:/   : bool(false)
-Warning: parse_url(http://user@:80): Unable to parse URL in %s on line 15
+--> http://:/   : bool(false)
-bool(false)
+--> http://?   : bool(false)
---> http://user:pass@:80   : 
+--> http://?:   : bool(false)
-Warning: parse_url(http://user:pass@:80): Unable to parse URL in %s on line 15
+--> http://:?   : bool(false)
-bool(false)
+--> http://blah.com:123456   : bool(false)
---> http://:   : 
+--> http://blah.com:abcdef   : bool(false)
-Warning: parse_url(http://:): Unable to parse URL in %s on line 15
-bool(false)
---> http://@/   : 
-Warning: parse_url(http://@/): Unable to parse URL in %s on line 15
-bool(false)
---> http://@:/   : 
-Warning: parse_url(http://@:/): Unable to parse URL in %s on line 15
-bool(false)
---> http://:/   : 
-Warning: parse_url(http://:/): Unable to parse URL in %s on line 15
-bool(false)
---> http://?   : 
-Warning: parse_url(http://?): Unable to parse URL in %s on line 15
-bool(false)
---> http://?:   : 
-Warning: parse_url(http://?:): Unable to parse URL in %s on line 15
-bool(false)
---> http://:?   : 
-Warning: parse_url(http://:?): Unable to parse URL in %s on line 15
-bool(false)
---> http://blah.com:123456   : 
-Warning: parse_url(http://blah.com:123456): Unable to parse URL in %s on line 15
-bool(false)
---> http://blah.com:abcdef   : 
-Warning: parse_url(http://blah.com:abcdef): Unable to parse URL in %s on line 15
-bool(false)
 Done

ext/standard/tests/url/parse_url_basic_005.phpt

@@ -108,43 +108,17 @@ echo "Done";
 --> http://[x:80]/   : NULL
 -->    : NULL
 --> /   : NULL
---> http:///blah.com   : 
+--> http:///blah.com   : bool(false)
-Warning: parse_url(http:///blah.com): Unable to parse URL in %s on line 15
+--> http://:80   : bool(false)
-bool(false)
+--> http://user@:80   : bool(false)
---> http://:80   : 
+--> http://user:pass@:80   : bool(false)
-Warning: parse_url(http://:80): Unable to parse URL in %s on line 15
+--> http://:   : bool(false)
-bool(false)
+--> http://@/   : bool(false)
---> http://user@:80   : 
+--> http://@:/   : bool(false)
-Warning: parse_url(http://user@:80): Unable to parse URL in %s on line 15
+--> http://:/   : bool(false)
-bool(false)
+--> http://?   : bool(false)
---> http://user:pass@:80   : 
+--> http://?:   : bool(false)
-Warning: parse_url(http://user:pass@:80): Unable to parse URL in %s on line 15
+--> http://:?   : bool(false)
-bool(false)
+--> http://blah.com:123456   : bool(false)
---> http://:   : 
+--> http://blah.com:abcdef   : bool(false)
-Warning: parse_url(http://:): Unable to parse URL in %s on line 15
-bool(false)
---> http://@/   : 
-Warning: parse_url(http://@/): Unable to parse URL in %s on line 15
-bool(false)
---> http://@:/   : 
-Warning: parse_url(http://@:/): Unable to parse URL in %s on line 15
-bool(false)
---> http://:/   : 
-Warning: parse_url(http://:/): Unable to parse URL in %s on line 15
-bool(false)
---> http://?   : 
-Warning: parse_url(http://?): Unable to parse URL in %s on line 15
-bool(false)
---> http://?:   : 
-Warning: parse_url(http://?:): Unable to parse URL in %s on line 15
-bool(false)
---> http://:?   : 
-Warning: parse_url(http://:?): Unable to parse URL in %s on line 15
-bool(false)
---> http://blah.com:123456   : 
-Warning: parse_url(http://blah.com:123456): Unable to parse URL in %s on line 15
-bool(false)
---> http://blah.com:abcdef   : 
-Warning: parse_url(http://blah.com:abcdef): Unable to parse URL in %s on line 15
-bool(false)
 Done

ext/standard/tests/url/parse_url_basic_006.phpt

@@ -108,43 +108,17 @@ echo "Done";
 --> http://[x:80]/   : NULL
 -->    : NULL
 --> /   : NULL
---> http:///blah.com   : 
+--> http:///blah.com   : bool(false)
-Warning: parse_url(http:///blah.com): Unable to parse URL in %s on line 15
+--> http://:80   : bool(false)
-bool(false)
+--> http://user@:80   : bool(false)
---> http://:80   : 
+--> http://user:pass@:80   : bool(false)
-Warning: parse_url(http://:80): Unable to parse URL in %s on line 15
+--> http://:   : bool(false)
-bool(false)
+--> http://@/   : bool(false)
---> http://user@:80   : 
+--> http://@:/   : bool(false)
-Warning: parse_url(http://user@:80): Unable to parse URL in %s on line 15
+--> http://:/   : bool(false)
-bool(false)
+--> http://?   : bool(false)
---> http://user:pass@:80   : 
+--> http://?:   : bool(false)
-Warning: parse_url(http://user:pass@:80): Unable to parse URL in %s on line 15
+--> http://:?   : bool(false)
-bool(false)
+--> http://blah.com:123456   : bool(false)
---> http://:   : 
+--> http://blah.com:abcdef   : bool(false)
-Warning: parse_url(http://:): Unable to parse URL in %s on line 15
-bool(false)
---> http://@/   : 
-Warning: parse_url(http://@/): Unable to parse URL in %s on line 15
-bool(false)
---> http://@:/   : 
-Warning: parse_url(http://@:/): Unable to parse URL in %s on line 15
-bool(false)
---> http://:/   : 
-Warning: parse_url(http://:/): Unable to parse URL in %s on line 15
-bool(false)
---> http://?   : 
-Warning: parse_url(http://?): Unable to parse URL in %s on line 15
-bool(false)
---> http://?:   : 
-Warning: parse_url(http://?:): Unable to parse URL in %s on line 15
-bool(false)
---> http://:?   : 
-Warning: parse_url(http://:?): Unable to parse URL in %s on line 15
-bool(false)
---> http://blah.com:123456   : 
-Warning: parse_url(http://blah.com:123456): Unable to parse URL in %s on line 15
-bool(false)
---> http://blah.com:abcdef   : 
-Warning: parse_url(http://blah.com:abcdef): Unable to parse URL in %s on line 15
-bool(false)
 Done

ext/standard/tests/url/parse_url_basic_007.phpt

@@ -108,43 +108,17 @@ echo "Done";
 --> http://[x:80]/   : string(1) "/"
 -->    : string(0) ""
 --> /   : string(1) "/"
---> http:///blah.com   : 
+--> http:///blah.com   : bool(false)
-Warning: parse_url(http:///blah.com): Unable to parse URL in %s on line 15
+--> http://:80   : bool(false)
-bool(false)
+--> http://user@:80   : bool(false)
---> http://:80   : 
+--> http://user:pass@:80   : bool(false)
-Warning: parse_url(http://:80): Unable to parse URL in %s on line 15
+--> http://:   : bool(false)
-bool(false)
+--> http://@/   : bool(false)
---> http://user@:80   : 
+--> http://@:/   : bool(false)
-Warning: parse_url(http://user@:80): Unable to parse URL in %s on line 15
+--> http://:/   : bool(false)
-bool(false)
+--> http://?   : bool(false)
---> http://user:pass@:80   : 
+--> http://?:   : bool(false)
-Warning: parse_url(http://user:pass@:80): Unable to parse URL in %s on line 15
+--> http://:?   : bool(false)
-bool(false)
+--> http://blah.com:123456   : bool(false)
---> http://:   : 
+--> http://blah.com:abcdef   : bool(false)
-Warning: parse_url(http://:): Unable to parse URL in %s on line 15
-bool(false)
---> http://@/   : 
-Warning: parse_url(http://@/): Unable to parse URL in %s on line 15
-bool(false)
---> http://@:/   : 
-Warning: parse_url(http://@:/): Unable to parse URL in %s on line 15
-bool(false)
---> http://:/   : 
-Warning: parse_url(http://:/): Unable to parse URL in %s on line 15
-bool(false)
---> http://?   : 
-Warning: parse_url(http://?): Unable to parse URL in %s on line 15
-bool(false)
---> http://?:   : 
-Warning: parse_url(http://?:): Unable to parse URL in %s on line 15
-bool(false)
---> http://:?   : 
-Warning: parse_url(http://:?): Unable to parse URL in %s on line 15
-bool(false)
---> http://blah.com:123456   : 
-Warning: parse_url(http://blah.com:123456): Unable to parse URL in %s on line 15
-bool(false)
---> http://blah.com:abcdef   : 
-Warning: parse_url(http://blah.com:abcdef): Unable to parse URL in %s on line 15
-bool(false)
 Done

ext/standard/tests/url/parse_url_basic_008.phpt

@@ -108,43 +108,17 @@ echo "Done";
 --> http://[x:80]/   : NULL
 -->    : NULL
 --> /   : NULL
---> http:///blah.com   : 
+--> http:///blah.com   : bool(false)
-Warning: parse_url(http:///blah.com): Unable to parse URL in %s on line 15
+--> http://:80   : bool(false)
-bool(false)
+--> http://user@:80   : bool(false)
---> http://:80   : 
+--> http://user:pass@:80   : bool(false)
-Warning: parse_url(http://:80): Unable to parse URL in %s on line 15
+--> http://:   : bool(false)
-bool(false)
+--> http://@/   : bool(false)
---> http://user@:80   : 
+--> http://@:/   : bool(false)
-Warning: parse_url(http://user@:80): Unable to parse URL in %s on line 15
+--> http://:/   : bool(false)
-bool(false)
+--> http://?   : bool(false)
---> http://user:pass@:80   : 
+--> http://?:   : bool(false)
-Warning: parse_url(http://user:pass@:80): Unable to parse URL in %s on line 15
+--> http://:?   : bool(false)
-bool(false)
+--> http://blah.com:123456   : bool(false)
---> http://:   : 
+--> http://blah.com:abcdef   : bool(false)
-Warning: parse_url(http://:): Unable to parse URL in %s on line 15
-bool(false)
---> http://@/   : 
-Warning: parse_url(http://@/): Unable to parse URL in %s on line 15
-bool(false)
---> http://@:/   : 
-Warning: parse_url(http://@:/): Unable to parse URL in %s on line 15
-bool(false)
---> http://:/   : 
-Warning: parse_url(http://:/): Unable to parse URL in %s on line 15
-bool(false)
---> http://?   : 
-Warning: parse_url(http://?): Unable to parse URL in %s on line 15
-bool(false)
---> http://?:   : 
-Warning: parse_url(http://?:): Unable to parse URL in %s on line 15
-bool(false)
---> http://:?   : 
-Warning: parse_url(http://:?): Unable to parse URL in %s on line 15
-bool(false)
---> http://blah.com:123456   : 
-Warning: parse_url(http://blah.com:123456): Unable to parse URL in %s on line 15
-bool(false)
---> http://blah.com:abcdef   : 
-Warning: parse_url(http://blah.com:abcdef): Unable to parse URL in %s on line 15
-bool(false)
 Done

ext/standard/tests/url/parse_url_basic_009.phpt

@@ -108,43 +108,17 @@ echo "Done";
 --> http://[x:80]/   : NULL
 -->    : NULL
 --> /   : NULL
---> http:///blah.com   : 
+--> http:///blah.com   : bool(false)
-Warning: parse_url(http:///blah.com): Unable to parse URL in %s on line 15
+--> http://:80   : bool(false)
-bool(false)
+--> http://user@:80   : bool(false)
---> http://:80   : 
+--> http://user:pass@:80   : bool(false)
-Warning: parse_url(http://:80): Unable to parse URL in %s on line 15
+--> http://:   : bool(false)
-bool(false)
+--> http://@/   : bool(false)
---> http://user@:80   : 
+--> http://@:/   : bool(false)
-Warning: parse_url(http://user@:80): Unable to parse URL in %s on line 15
+--> http://:/   : bool(false)
-bool(false)
+--> http://?   : bool(false)
---> http://user:pass@:80   : 
+--> http://?:   : bool(false)
-Warning: parse_url(http://user:pass@:80): Unable to parse URL in %s on line 15
+--> http://:?   : bool(false)
-bool(false)
+--> http://blah.com:123456   : bool(false)
---> http://:   : 
+--> http://blah.com:abcdef   : bool(false)
-Warning: parse_url(http://:): Unable to parse URL in %s on line 15
-bool(false)
---> http://@/   : 
-Warning: parse_url(http://@/): Unable to parse URL in %s on line 15
-bool(false)
---> http://@:/   : 
-Warning: parse_url(http://@:/): Unable to parse URL in %s on line 15
-bool(false)
---> http://:/   : 
-Warning: parse_url(http://:/): Unable to parse URL in %s on line 15
-bool(false)
---> http://?   : 
-Warning: parse_url(http://?): Unable to parse URL in %s on line 15
-bool(false)
---> http://?:   : 
-Warning: parse_url(http://?:): Unable to parse URL in %s on line 15
-bool(false)
---> http://:?   : 
-Warning: parse_url(http://:?): Unable to parse URL in %s on line 15
-bool(false)
---> http://blah.com:123456   : 
-Warning: parse_url(http://blah.com:123456): Unable to parse URL in %s on line 15
-bool(false)
---> http://blah.com:abcdef   : 
-Warning: parse_url(http://blah.com:abcdef): Unable to parse URL in %s on line 15
-bool(false)
 Done

ext/standard/url.c

@@ -355,7 +355,7 @@ PHP_FUNCTION(parse_url)
 
 	resource = php_url_parse_ex(str, str_len);
 	if (resource == NULL) {
-		php_error_docref1(NULL TSRMLS_CC, str, E_WARNING, "Unable to parse URL");
+		/* @todo Find a method to determine why php_url_parse_ex() failed */
 		RETURN_FALSE;
 	}