archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-15 21:48:51 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Boolify PDO's transaction handlers

Browse source 
This includes begin(), commit(), rollBack(), and inTransaction()
This commit is contained in:
George Peter Banyard 2020-12-23 02:17:46 +01:00
parent 6728c1bd72
commit d04adf60be
9 changed files with 80 additions and 78 deletions
Download patch file Download diff file Expand all files Collapse all files

20
ext/pdo_sqlite/sqlite_driver.c
View file

@ -238,7 +238,7 @@ static int sqlite_handle_quoter(pdo_dbh_t *dbh, const char *unquoted, size_t unq
return 1;
}
static int sqlite_handle_begin(pdo_dbh_t *dbh)
static bool sqlite_handle_begin(pdo_dbh_t *dbh)
{
pdo_sqlite_db_handle *H = (pdo_sqlite_db_handle *)dbh->driver_data;
char *errmsg = NULL;
@ -247,12 +247,12 @@ static int sqlite_handle_begin(pdo_dbh_t *dbh)
pdo_sqlite_error(dbh);
if (errmsg)
sqlite3_free(errmsg);
return 0;
return false;
}
return 1;
return true;
}
static int sqlite_handle_commit(pdo_dbh_t *dbh)
static bool sqlite_handle_commit(pdo_dbh_t *dbh)
{
pdo_sqlite_db_handle *H = (pdo_sqlite_db_handle *)dbh->driver_data;
char *errmsg = NULL;
@ -261,12 +261,12 @@ static int sqlite_handle_commit(pdo_dbh_t *dbh)
pdo_sqlite_error(dbh);
if (errmsg)
sqlite3_free(errmsg);
return 0;
return false;
}
return 1;
return true;
}
static int sqlite_handle_rollback(pdo_dbh_t *dbh)
static bool sqlite_handle_rollback(pdo_dbh_t *dbh)
{
pdo_sqlite_db_handle *H = (pdo_sqlite_db_handle *)dbh->driver_data;
char *errmsg = NULL;
@ -275,9 +275,9 @@ static int sqlite_handle_rollback(pdo_dbh_t *dbh)
pdo_sqlite_error(dbh);
if (errmsg)
sqlite3_free(errmsg);
return 0;
return false;
}
return 1;
return true;
}
static int pdo_sqlite_get_attribute(pdo_dbh_t *dbh, zend_long attr, zval *return_value)
@ -729,7 +729,7 @@ static const struct pdo_dbh_methods sqlite_methods = {
NULL, /* check_liveness: not needed */
get_driver_methods,
pdo_sqlite_request_shutdown,
NULL, /* in_transaction */
NULL, /* in transaction, use PDO's internal tracking mechanism */
pdo_sqlite_get_gc
};