archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-15 13:38:49 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fixed GH-16978: Avoid unnecessary padding with leading zeros (#16988)

Browse source 
Fixed an issue where leading zeros were padded beyond the allocated memory.

fixes #16978
closes #16988
This commit is contained in:
Saki Takamachi 2024-11-29 21:28:38 +09:00
parent 8d25978d65
commit d17ed3445d
No known key found for this signature in database
GPG key ID: 770426E17EBBB3DD
3 changed files with 17 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
NEWS
View file

@ -2,6 +2,10 @@ PHP NEWS
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
?? ??? ????, PHP 8.4.2 ?? ??? ????, PHP 8.4.2
- BcMath:
. Fixed bug GH-16978 (Avoid unnecessary padding with leading zeros)
(Saki Takamachi)
- Core: - Core:
. Fixed bug GH-16344 (setRawValueWithoutLazyInitialization() and . Fixed bug GH-16344 (setRawValueWithoutLazyInitialization() and
skipLazyInitialization() may change initialized proxy). (Arnaud) skipLazyInitialization() may change initialized proxy). (Arnaud)

1
ext/bcmath/libbcmath/src/div.c
View file

@ -436,6 +436,7 @@ bool bc_divide(bc_num numerator, bc_num divisor, bc_num *quot, size_t scale)
numerator_bottom_extension = 0; numerator_bottom_extension = 0;
numeratorend -= scale_diff > numerator_top_extension ? scale_diff - numerator_top_extension : 0; numeratorend -= scale_diff > numerator_top_extension ? scale_diff - numerator_top_extension : 0;
} }
numerator_top_extension = MIN(numerator_top_extension, scale);
} else { } else {
numerator_bottom_extension += scale - numerator_scale; numerator_bottom_extension += scale - numerator_scale;
} }

12
ext/bcmath/tests/gh16978.phpt Normal file
View file

@ -0,0 +1,12 @@
--TEST--
GH-16978 Stack buffer overflow ext/bcmath/libbcmath/src/div.c:464:12 in bc_divide
--EXTENSIONS--
bcmath
--FILE--
<?php
echo bcpow('10', '-112', 10) . "\n";
echo bcdiv('1', '10000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000', 1);
?>
--EXPECT--
0.0000000000
0.0