archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-15 13:38:49 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

gen_stub: move parseDocComments() into DocCommentTag

Browse source 
Reduce the number of global functions by moving it to static method
`DocCommentTag::parseDocComments()`.
This commit is contained in:
Daniel Scherzer 2025-03-18 13:06:46 -07:00 • committed by DanielEScherzer
parent ce3990c1d3
commit d42bac2866
1 changed files with 24 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

48
build/gen_stub.php
View file

@ -4528,6 +4528,25 @@ class DocCommentTag {
return $matches["name"]; return $matches["name"];
} }
/** @return DocCommentTag[] */
public static function parseDocComments(array $comments): array {
$tags = [];
foreach ($comments as $comment) {
if (!($comment instanceof DocComment)) {
continue;
}
$commentText = substr($comment->getText(), 2, -2);
foreach (explode("\n", $commentText) as $commentLine) {
$regex = '/^\*\s*@([a-z-]+)(?:\s+(.+))?$/';
if (preg_match($regex, trim($commentLine), $matches)) {
$tags[] = new DocCommentTag($matches[1], $matches[2] ?? null);
}
}
}
return $tags;
}
} }
// Instances of ExposedDocComment are immutable and do not need to be cloned // Instances of ExposedDocComment are immutable and do not need to be cloned
@ -4571,25 +4590,6 @@ class ExposedDocComment {
} }
} }
/** @return DocCommentTag[] */
function parseDocComments(array $comments): array {
$tags = [];
foreach ($comments as $comment) {
if (!($comment instanceof DocComment)) {
continue;
}
$commentText = substr($comment->getText(), 2, -2);
foreach (explode("\n", $commentText) as $commentLine) {
$regex = '/^\*\s*@([a-z-]+)(?:\s+(.+))?$/';
if (preg_match($regex, trim($commentLine), $matches)) {
$tags[] = new DocCommentTag($matches[1], $matches[2] ?? null);
}
}
}
return $tags;
}
// Instances of FramelessFunctionInfo are immutable and do not need to be cloned // Instances of FramelessFunctionInfo are immutable and do not need to be cloned
// when held by an object that is cloned // when held by an object that is cloned
class FramelessFunctionInfo { class FramelessFunctionInfo {
@ -4628,7 +4628,7 @@ function parseFunctionLike(
$framelessFunctionInfos = []; $framelessFunctionInfos = [];
if ($comments) { if ($comments) {
$tags = parseDocComments($comments); $tags = DocCommentTag::parseDocComments($comments);
foreach ($tags as $tag) { foreach ($tags as $tag) {
switch ($tag->name) { switch ($tag->name) {
@ -4817,7 +4817,7 @@ function parseConstLike(
$link = null; $link = null;
$isFileCacheAllowed = true; $isFileCacheAllowed = true;
if ($comments) { if ($comments) {
$tags = parseDocComments($comments); $tags = DocCommentTag::parseDocComments($comments);
foreach ($tags as $tag) { foreach ($tags as $tag) {
if ($tag->name === 'var') { if ($tag->name === 'var') {
$phpDocType = $tag->getType(); $phpDocType = $tag->getType();
@ -4891,7 +4891,7 @@ function parseProperty(
$link = null; $link = null;
if ($comments) { if ($comments) {
$tags = parseDocComments($comments); $tags = DocCommentTag::parseDocComments($comments);
foreach ($tags as $tag) { foreach ($tags as $tag) {
if ($tag->name === 'var') { if ($tag->name === 'var') {
$phpDocType = $tag->getType(); $phpDocType = $tag->getType();
@ -4962,7 +4962,7 @@ function parseClass(
$allowsDynamicProperties = false; $allowsDynamicProperties = false;
if ($comments) { if ($comments) {
$tags = parseDocComments($comments); $tags = DocCommentTag::parseDocComments($comments);
foreach ($tags as $tag) { foreach ($tags as $tag) {
if ($tag->name === 'alias') { if ($tag->name === 'alias') {
$alias = $tag->getValue(); $alias = $tag->getValue();
@ -5067,7 +5067,7 @@ function parseStubFile(string $code): FileInfo {
$stmts = $parser->parse($code); $stmts = $parser->parse($code);
$nodeTraverser->traverse($stmts); $nodeTraverser->traverse($stmts);
$fileTags = parseDocComments(getFileDocComments($stmts)); $fileTags = DocCommentTag::parseDocComments(getFileDocComments($stmts));
$fileInfo = new FileInfo($fileTags); $fileInfo = new FileInfo($fileTags);
$fileInfo->handleStatements($stmts, $prettyPrinter); $fileInfo->handleStatements($stmts, $prettyPrinter);