From d45f4cef08d68efb0d0414ca32ee92c1350e3e94 Mon Sep 17 00:00:00 2001 From: Niels Dossche <7771979+nielsdos@users.noreply.github.com> Date: Thu, 2 Nov 2023 10:38:31 +0000 Subject: [PATCH] Drop Laravel from benchmark CI (#12595) Two issues: - The demo page does not seem to be doing much, so the value is limited. - The benchmark instruction count has too much variance to be useful. --- benchmark/benchmark.php | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/benchmark/benchmark.php b/benchmark/benchmark.php index 2e6f71bec79..a0c01ca7662 100644 --- a/benchmark/benchmark.php +++ b/benchmark/benchmark.php @@ -27,8 +27,6 @@ function main() { $data['Symfony Demo 2.2.3 JIT'] = runSymfonyDemo(true); $data['Wordpress 6.2'] = runWordpress(false); $data['Wordpress 6.2 JIT'] = runWordpress(true); - $data['Laravel 10.10'] = runLaravelDemo(false); - $data['Laravel 10.10 JIT'] = runLaravelDemo(true); $result = json_encode($data, JSON_PRETTY_PRINT) . "\n"; fwrite(STDOUT, $result); @@ -91,17 +89,6 @@ function runWordpress(bool $jit): array { return runValgrindPhpCgiCommand('wordpress', [$dir . '/index.php'], cwd: $dir, jit: $jit, warmup: 50, repeat: 50); } -function runLaravelDemo(bool $jit): array { - - $dir = __DIR__ . '/repos/laravel-demo-10.10'; - cloneRepo($dir, 'https://github.com/php/benchmarking-laravel-demo-10.10.git'); - runPhpCommand([$dir . '/artisan', 'config:cache']); - runPhpCommand([$dir . '/artisan', 'event:cache']); - runPhpCommand([$dir . '/artisan', 'route:cache']); - runPhpCommand([$dir . '/artisan', 'view:cache']); - return runValgrindPhpCgiCommand('laravel-demo', [$dir . '/public/index.php'], cwd: $dir, jit: $jit, warmup: 50, repeat: 100); -} - function runPhpCommand(array $args, ?string $cwd = null): ProcessResult { return runCommand([PHP_BINARY, ...$args], $cwd); }