From d68073c23b7e5bae66adc893beb701d021ea6e74 Mon Sep 17 00:00:00 2001
From: George Peter Banyard <girgias@php.net>
Date: Tue, 24 Jan 2023 15:04:23 +0000
Subject: [PATCH] streams: Checking if a stream is castable should not emit
 warnings for user defined streams

Closes GH-10435
---
 NEWS                                          |  1 +
 main/streams/userspace.c                      | 20 ++++++++++++-----
 ...tream_isatty_non_castable_userwrapper.phpt | 22 +++++++++++++++++++
 3 files changed, 37 insertions(+), 6 deletions(-)
 create mode 100644 tests/output/stream_isatty_non_castable_userwrapper.phpt

diff --git a/NEWS b/NEWS
index 92d38e495dd..7be1071a76b 100644
--- a/NEWS
+++ b/NEWS
@@ -14,6 +14,7 @@ PHP                                                                        NEWS
     that is unset in error handler). (Girgias)
   . Fixed bug GH-12102 (Incorrect compile error when using array access on TMP
     value in function call). (ilutov)
+  . Fixed warning emitted when checking if a user stream is castable. (Girgias)
 
 - FPM:
   . Fixed GH-12077 (PHP 8.3.0RC1 borked socket-close-on-exec.phpt).
diff --git a/main/streams/userspace.c b/main/streams/userspace.c
index e769f2cdf22..73319215d28 100644
--- a/main/streams/userspace.c
+++ b/main/streams/userspace.c
@@ -1384,6 +1384,8 @@ static int php_userstreamop_cast(php_stream *stream, int castas, void **retptr)
 	php_stream * intstream = NULL;
 	int call_result;
 	int ret = FAILURE;
+	/* If we are checking if the stream can cast, no return pointer is provided, so do not emit errors */
+	bool report_errors = retptr;
 
 	ZVAL_STRINGL(&func_name, USERSTREAM_CAST, sizeof(USERSTREAM_CAST)-1);
 
@@ -1400,8 +1402,10 @@ static int php_userstreamop_cast(php_stream *stream, int castas, void **retptr)
 
 	do {
 		if (call_result == FAILURE) {
-			php_error_docref(NULL, E_WARNING, "%s::" USERSTREAM_CAST " is not implemented!",
-					ZSTR_VAL(us->wrapper->ce->name));
+			if (report_errors) {
+				php_error_docref(NULL, E_WARNING, "%s::" USERSTREAM_CAST " is not implemented!",
+						ZSTR_VAL(us->wrapper->ce->name));
+			}
 			break;
 		}
 		if (!zend_is_true(&retval)) {
@@ -1409,13 +1413,17 @@ static int php_userstreamop_cast(php_stream *stream, int castas, void **retptr)
 		}
 		php_stream_from_zval_no_verify(intstream, &retval);
 		if (!intstream) {
-			php_error_docref(NULL, E_WARNING, "%s::" USERSTREAM_CAST " must return a stream resource",
-					ZSTR_VAL(us->wrapper->ce->name));
+			if (report_errors) {
+				php_error_docref(NULL, E_WARNING, "%s::" USERSTREAM_CAST " must return a stream resource",
+						ZSTR_VAL(us->wrapper->ce->name));
+			}
 			break;
 		}
 		if (intstream == stream) {
-			php_error_docref(NULL, E_WARNING, "%s::" USERSTREAM_CAST " must not return itself",
-					ZSTR_VAL(us->wrapper->ce->name));
+			if (report_errors) {
+				php_error_docref(NULL, E_WARNING, "%s::" USERSTREAM_CAST " must not return itself",
+						ZSTR_VAL(us->wrapper->ce->name));
+			}
 			intstream = NULL;
 			break;
 		}
diff --git a/tests/output/stream_isatty_non_castable_userwrapper.phpt b/tests/output/stream_isatty_non_castable_userwrapper.phpt
new file mode 100644
index 00000000000..cc304c19251
--- /dev/null
+++ b/tests/output/stream_isatty_non_castable_userwrapper.phpt
@@ -0,0 +1,22 @@
+--TEST--
+Non castable user-space streams (stream_cast())
+--FILE--
+<?php
+class test_wrapper {
+    public $context;
+    public $return_value;
+    function stream_open($path, $mode, $openedpath) {
+        return true;
+    }
+    function stream_eof() {
+        return false;
+    }
+}
+
+stream_wrapper_register('test', 'test_wrapper');
+$fd = fopen("test://foo","r");
+var_dump(stream_isatty($fd));
+
+?>
+--EXPECT--
+bool(false)