archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-21 01:45:16 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix release build failure

Browse source 
GCC complained about potentially uninitialized __orig_bailout,
even though the variable has an initializer. This warning was
quite persistent, I was only able to avoid it by using a separate
function.

Am I missing something?
This commit is contained in:
Nikita Popov 2019-12-10 13:49:40 +01:00
parent 9e22c3d4d9
commit d6f86caa11
3 changed files with 12 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

22
ext/opcache/ZendAccelerator.c
View file

@ -3870,6 +3870,15 @@ static void preload_check_windows_restrictions(zend_class_entry *scope) {
}
#endif
static inline int preload_update_class_constants(zend_class_entry *ce) {
/* This is a separate function to work around what appears to be a bug in GCC
* maybe-uninitialized analysis. */
zend_try {
return zend_update_class_constants(ce);
} zend_end_try();
return FAILURE;
}
static zend_class_entry *preload_load_prop_type(zend_property_info *prop, zend_string *name) {
zend_class_entry *ce;
if (zend_string_equals_literal_ci(name, "self")) {
@ -3915,18 +3924,7 @@ static void preload_ensure_classes_loadable() {
#endif
if (!(ce->ce_flags & ZEND_ACC_CONSTANTS_UPDATED)) {
int result = SUCCESS;
zend_try {
result = zend_update_class_constants(ce);
} zend_catch {
/* Provide some context for the generated error. */
zend_error_noreturn(E_ERROR,
"Error generated while resolving initializers of class %s during preloading",
ZSTR_VAL(ce->name));
} zend_end_try();
if (result == FAILURE) {
/* Just present to be safe: We generally always throw some
* other fatal error as part of update_class_constants(). */
if (preload_update_class_constants(ce) == FAILURE) {
zend_error_noreturn(E_ERROR,
"Failed to resolve initializers of class %s during preloading",
ZSTR_VAL(ce->name));

2
ext/opcache/tests/preload_004.phpt
View file

@ -14,4 +14,4 @@ var_dump(class_exists('Foo'));
--EXPECTF--
Fatal error: Undefined class constant 'self::DOES_NOT_EXIST' in Unknown on line 0
Fatal error: Error generated while resolving initializers of class Foo during preloading in Unknown on line 0
Fatal error: Failed to resolve initializers of class Foo during preloading in Unknown on line 0

2
ext/opcache/tests/preload_loadable_classes_2.phpt
View file

@ -14,4 +14,4 @@ Warning: Use of undefined constant UNDEF - assumed 'UNDEF' (this will throw an E
Fatal error: Class 'Foo' not found in Unknown on line 0
Fatal error: Error generated while resolving initializers of class Test during preloading in Unknown on line 0
Fatal error: Failed to resolve initializers of class Test during preloading in Unknown on line 0