archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-15 21:48:51 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Deprecate use of parent where no parent exists

Browse source 
This deprecation is part of the covariance RFC.
This commit is contained in:
Nikita Popov 2019-05-24 09:49:44 +02:00
parent d9747c23a2
commit d7f3844c87
3 changed files with 14 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Zend/tests/class_name_as_scalar_error_002.phpt
View file

@ -11,6 +11,8 @@ namespace Foo\Bar {
}
?>
--EXPECTF--
Deprecated: Cannot use "parent" when current class scope has no parent in %s on line %d
Fatal error: Uncaught Error: Cannot use "parent" when current class scope has no parent in %s:%d
Stack trace:
#0 {main}

2
Zend/tests/type_declarations/variance/parent_in_class.phpt
View file

@ -40,6 +40,8 @@ class B4 extends A4 {
?>
--EXPECTF--
Deprecated: Cannot use "parent" when current class scope has no parent in %s on line %d
Warning: Declaration of B4::method(A4 $x) should be compatible with A4::method(P4 $x) in %s on line %d
Warning: Could not check compatibility between B::method(A $x) and A::method(parent $x), because class parent is not available in %s on line %d

14
Zend/zend_compile.c
View file

@ -1319,10 +1319,16 @@ static uint32_t zend_get_class_fetch_type_ast(zend_ast *name_ast) /* {{{ */
static void zend_ensure_valid_class_fetch_type(uint32_t fetch_type) /* {{{ */
{
if (fetch_type != ZEND_FETCH_CLASS_DEFAULT && !CG(active_class_entry) && zend_is_scope_known()) {
zend_error_noreturn(E_COMPILE_ERROR, "Cannot use \"%s\" when no class scope is active",
fetch_type == ZEND_FETCH_CLASS_SELF ? "self" :
fetch_type == ZEND_FETCH_CLASS_PARENT ? "parent" : "static");
if (fetch_type != ZEND_FETCH_CLASS_DEFAULT && zend_is_scope_known()) {
zend_class_entry *ce = CG(active_class_entry);
if (!ce) {
zend_error_noreturn(E_COMPILE_ERROR, "Cannot use \"%s\" when no class scope is active",
fetch_type == ZEND_FETCH_CLASS_SELF ? "self" :
fetch_type == ZEND_FETCH_CLASS_PARENT ? "parent" : "static");
} else if (fetch_type == ZEND_FETCH_CLASS_PARENT && !ce->parent_name) {
zend_error(E_DEPRECATED,
"Cannot use \"parent\" when current class scope has no parent");
}
}
}
/* }}} */