From d94a1907b735c1c4b0e40a671fa9044c90456c2d Mon Sep 17 00:00:00 2001
From: Nikita Popov <nikita.ppv@gmail.com>
Date: Wed, 20 Feb 2019 09:31:08 +0100
Subject: [PATCH] Use zend_parse_parameters_none() in XmlWriter::openMemory()

And fix incorrect uses in tests
---
 ext/xmlwriter/php_xmlwriter.c | 4 ++++
 ext/xmlwriter/tests/002.phpt  | 3 +--
 ext/xmlwriter/tests/003.phpt  | 3 +--
 3 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/ext/xmlwriter/php_xmlwriter.c b/ext/xmlwriter/php_xmlwriter.c
index 921cd4151a8..3f7b0da9242 100644
--- a/ext/xmlwriter/php_xmlwriter.c
+++ b/ext/xmlwriter/php_xmlwriter.c
@@ -1700,6 +1700,10 @@ static PHP_FUNCTION(xmlwriter_open_memory)
 	zval *self = getThis();
 	ze_xmlwriter_object *ze_obj = NULL;
 
+	if (zend_parse_parameters_none() == FAILURE) {
+		return;
+	}
+
 	if (self) {
 		/* We do not use XMLWRITER_FROM_OBJECT, xmlwriter init function here */
 		ze_obj = Z_XMLWRITER_P(self);
diff --git a/ext/xmlwriter/tests/002.phpt b/ext/xmlwriter/tests/002.phpt
index 13c7da17bf0..d8c822b1a58 100644
--- a/ext/xmlwriter/tests/002.phpt
+++ b/ext/xmlwriter/tests/002.phpt
@@ -5,8 +5,7 @@ XMLWriter: libxml2 XML Writer, membuffer, flush
 --FILE--
 <?php
 
-$doc_dest = '002.xml';
-$xw = xmlwriter_open_memory($doc_dest);
+$xw = xmlwriter_open_memory();
 xmlwriter_start_document($xw, '1.0', 'UTF-8');
 xmlwriter_start_element($xw, "tag1");
 xmlwriter_end_document($xw);
diff --git a/ext/xmlwriter/tests/003.phpt b/ext/xmlwriter/tests/003.phpt
index f1463c7dfc4..f7dcdfaa6c5 100644
--- a/ext/xmlwriter/tests/003.phpt
+++ b/ext/xmlwriter/tests/003.phpt
@@ -5,8 +5,7 @@ XMLWriter: libxml2 XML Writer, membuffer, flush, attribute
 --FILE--
 <?php
 
-$doc_dest = '003.xml';
-$xw = xmlwriter_open_memory($doc_dest);
+$xw = xmlwriter_open_memory();
 xmlwriter_start_document($xw, '1.0', 'UTF-8');
 xmlwriter_start_element($xw, "tag1");