archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-16 05:58:45 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix bug #71428: Validation type inheritance with = NULL

Browse source
This commit is contained in:
Joe Watkins 2016-03-29 09:57:51 +01:00
parent 3f56dfe866
commit dd70c39556
2 changed files with 13 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Zend/tests/bug71428.3.phpt Normal file
View file

@ -0,0 +1,11 @@
--TEST--
bug #71428: Validation type inheritance with = NULL
--FILE--
<?php
class A { }
class B { public function m(A $a = NULL, $n) { echo "B.m";} };
class C extends B { public function m(A $a , $n) { echo "C.m";} };
?>
--EXPECTF--
Warning: Declaration of C::m(A $a, $n) should be compatible with B::m(A $a = NULL, $n) in %sbug71428.3.php on line 4

2
Zend/zend_inheritance.c
View file

@ -488,6 +488,8 @@ static ZEND_COLD zend_string *zend_get_function_declaration(const zend_function
} else {
smart_str_appends(&str, "NULL");
}
} else if (arg_info->type_hint && arg_info->allow_null) {
smart_str_appends(&str, " = NULL");
}
if (++i < num_args) {