archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-18 15:08:55 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix #38624 (Strange warning when incrementing an object property and exception is thrown from __get method)

Browse source
This commit is contained in:
Antony Dovgal 2006-08-28 10:25:49 +00:00
parent 2321d27bc8
commit dd9165d60a
2 changed files with 37 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

34
Zend/tests/bug38624.phpt Normal file
View file

@ -0,0 +1,34 @@
--TEST--
Bug #38624 (Strange warning when incrementing an object property and exception is thrown from __get method)
--FILE--
<?php
class impl
{
public function __construct()
{
$this->counter++;
}
public function __set( $name, $value )
{
throw new Exception( "doesn't work" );
}
public function __get( $name )
{
throw new Exception( "doesn't work" );
}
}
$impl = new impl();
echo "Done\n";
?>
--EXPECTF--
Fatal error: Uncaught exception 'Exception' with message 'doesn't work' in %s:%d
Stack trace:
#0 %s(%d): impl->__get('counter')
#1 %s(%d): impl->__construct()
#2 {main}
thrown in %s on line %d

2
Zend/zend_interfaces.c
View file

@ -93,8 +93,10 @@ ZEND_API zval* zend_call_method(zval **object_pp, zend_class_entry *obj_ce, zend
if (!obj_ce) { if (!obj_ce) {
obj_ce = object_pp ? Z_OBJCE_PP(object_pp) : NULL; obj_ce = object_pp ? Z_OBJCE_PP(object_pp) : NULL;
} }
if (!EG(exception)) {
zend_error(E_CORE_ERROR, "Couldn't execute method %v%s%s", obj_ce ? obj_ce->name : EMPTY_ZSTR, obj_ce ? "::" : "", function_name); zend_error(E_CORE_ERROR, "Couldn't execute method %v%s%s", obj_ce ? obj_ce->name : EMPTY_ZSTR, obj_ce ? "::" : "", function_name);
} }
}
if (!retval_ptr_ptr) { if (!retval_ptr_ptr) {
if (retval) { if (retval) {
zval_ptr_dtor(&retval); zval_ptr_dtor(&retval);