From ddedd15eae012ede1ab9a738019d78a13a2dd2b9 Mon Sep 17 00:00:00 2001 From: Niels Dossche <7771979+nielsdos@users.noreply.github.com> Date: Mon, 11 Dec 2023 20:07:34 +0100 Subject: [PATCH] Remove always-true condition in php_conv_open() --- ext/standard/filters.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/ext/standard/filters.c b/ext/standard/filters.c index d72c09b7d22..22842396d35 100644 --- a/ext/standard/filters.c +++ b/ext/standard/filters.c @@ -1188,9 +1188,7 @@ static php_conv *php_conv_open(int conv_mode, const HashTable *options, int pers retval = pemalloc(sizeof(php_conv_base64_encode), persistent); if (lbchars != NULL) { if (php_conv_base64_encode_ctor((php_conv_base64_encode *)retval, line_len, lbchars, lbchars_len, 1, persistent) != PHP_CONV_ERR_SUCCESS) { - if (lbchars != NULL) { - pefree(lbchars, 0); - } + pefree(lbchars, 0); goto out_failure; } pefree(lbchars, 0);