archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-16 05:58:45 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix off-by-one in ReflectionType::__toString()

Browse source 
Review mistake...
This commit is contained in:
Nikita Popov 2016-08-20 19:00:03 +02:00
parent 9988863d37
commit dfed09afca
1 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

10
ext/reflection/php_reflection.c
View file

@ -3040,14 +3040,16 @@ ZEND_METHOD(reflection_type, __toString)
if (param->arg_info->type_hint == IS_OBJECT
&& !zend_string_equals_literal_ci(param->arg_info->class_name, "self")
&& !zend_string_equals_literal_ci(param->arg_info->class_name, "parent")) {
str = zend_string_extend(str, ZSTR_LEN(str) + 1, 0);
memmove(ZSTR_VAL(str) + 1, ZSTR_VAL(str), ZSTR_LEN(str) + 1);
size_t orig_len = ZSTR_LEN(str);
str = zend_string_extend(str, orig_len + 1, 0);
memmove(ZSTR_VAL(str) + 1, ZSTR_VAL(str), orig_len + 1);
ZSTR_VAL(str)[0] = '\\';
}
if (param->arg_info->allow_null) {
str = zend_string_extend(str, ZSTR_LEN(str) + 1, 0);
memmove(ZSTR_VAL(str) + 1, ZSTR_VAL(str), ZSTR_LEN(str) + 1);
size_t orig_len = ZSTR_LEN(str);
str = zend_string_extend(str, orig_len + 1, 0);
memmove(ZSTR_VAL(str) + 1, ZSTR_VAL(str), orig_len + 1);
ZSTR_VAL(str)[0] = '?';
}