archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-16 05:58:45 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix #79462: method_exists and property_exists incoherent behavior

Browse source 
Both functions are closely related, so should behave the same for wrong
input types, i.e. both should throw a TypeError.
This commit is contained in:
Christoph M. Becker 2020-04-09 10:55:53 +02:00
parent 12324364f7
commit e6458d67cf
3 changed files with 31 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

2
NEWS
View file

@ -16,6 +16,8 @@ PHP NEWS
abstract trait function). (Nikita)
. Fixed bug #62609 (Allow implementing Traversable on abstract classes).
(Nikita)
. Fixed bug #79462 (method_exists and property_exists incoherent behavior).
(cmb)
- CURL:
. Bumped required libcurl version to 7.29.0. (cmb)

3
Zend/zend_builtin_functions.c
View file

@ -1107,7 +1107,8 @@ ZEND_FUNCTION(method_exists)
RETURN_FALSE;
}
} else {
RETURN_FALSE;
zend_argument_type_error(1, "must be of type object|string, %s given", zend_zval_type_name(klass));
RETURN_THROWS();
}
lcname = zend_string_tolower(method_name);

50
ext/standard/tests/class_object/method_exists_variation_001.phpt
View file

@ -78,7 +78,11 @@ $values = array(
foreach($values as $value) {
echo "\nArg value $value \n";
var_dump( method_exists($value, $method) );
try {
var_dump( method_exists($value, $method) );
} catch (TypeError $e) {
echo $e->getMessage(), PHP_EOL;
}
};
echo "Done";
@ -89,69 +93,69 @@ Error: 2 - Undefined variable $undefined_var
Error: 2 - Undefined variable $unset_var
Arg value 0
bool(false)
method_exists(): Argument #1 ($object_or_class) must be of type object|string, int given
Arg value 1
bool(false)
method_exists(): Argument #1 ($object_or_class) must be of type object|string, int given
Arg value 12345
bool(false)
method_exists(): Argument #1 ($object_or_class) must be of type object|string, int given
Arg value -2345
bool(false)
method_exists(): Argument #1 ($object_or_class) must be of type object|string, int given
Arg value 10.5
bool(false)
method_exists(): Argument #1 ($object_or_class) must be of type object|string, float given
Arg value -10.5
bool(false)
method_exists(): Argument #1 ($object_or_class) must be of type object|string, float given
Arg value 101234567000
bool(false)
method_exists(): Argument #1 ($object_or_class) must be of type object|string, float given
Arg value 1.07654321E-9
bool(false)
method_exists(): Argument #1 ($object_or_class) must be of type object|string, float given
Arg value 0.5
bool(false)
method_exists(): Argument #1 ($object_or_class) must be of type object|string, float given
Error: 2 - Array to string conversion
Arg value Array
bool(false)
method_exists(): Argument #1 ($object_or_class) must be of type object|string, array given
Error: 2 - Array to string conversion
Arg value Array
bool(false)
method_exists(): Argument #1 ($object_or_class) must be of type object|string, array given
Error: 2 - Array to string conversion
Arg value Array
bool(false)
method_exists(): Argument #1 ($object_or_class) must be of type object|string, array given
Error: 2 - Array to string conversion
Arg value Array
bool(false)
method_exists(): Argument #1 ($object_or_class) must be of type object|string, array given
Error: 2 - Array to string conversion
Arg value Array
bool(false)
method_exists(): Argument #1 ($object_or_class) must be of type object|string, array given
Arg value
bool(false)
method_exists(): Argument #1 ($object_or_class) must be of type object|string, null given
Arg value
bool(false)
method_exists(): Argument #1 ($object_or_class) must be of type object|string, null given
Arg value 1
bool(false)
method_exists(): Argument #1 ($object_or_class) must be of type object|string, bool given
Arg value
bool(false)
method_exists(): Argument #1 ($object_or_class) must be of type object|string, bool given
Arg value 1
bool(false)
method_exists(): Argument #1 ($object_or_class) must be of type object|string, bool given
Arg value
bool(false)
method_exists(): Argument #1 ($object_or_class) must be of type object|string, bool given
Arg value
bool(false)
@ -168,8 +172,8 @@ In autoload(String)
bool(false)
Arg value
bool(false)
method_exists(): Argument #1 ($object_or_class) must be of type object|string, null given
Arg value
bool(false)
method_exists(): Argument #1 ($object_or_class) must be of type object|string, null given
Done