Run one testsuite with observers enabled in CI (#13869)

Signed-off-by: Bob Weinand <bobwei9@hotmail.com>

.circleci/config.yml

@@ -184,6 +184,8 @@ jobs:
               -d opcache.enable_cli=1 \
               -d opcache.jit_buffer_size=16M \
               -d opcache.jit=tracing \
+              -d zend_test.observer.enabled=1 \
+              -d zend_test.observer.show_output=0 \
               -P -q -x -j2 \
               -g FAIL,BORK,LEAK,XLEAK \
               --no-progress \

.github/nightly_matrix.php

@@ -70,6 +70,7 @@ function get_matrix_include(array $branches) {
                 'debug' => true,
                 'zts' => true,
                 'configuration_parameters' => "CFLAGS='-DZEND_RC_DEBUG=1 -DPROFITABILITY_CHECKS=0 -DZEND_VERIFY_FUNC_INFO=1'",
+                'run_tests_parameters' => '-d zend_test.observer.enabled=1 -d zend_test.observer.show_output=0',
                 'timeout_minutes' => 360,
                 'test_function_jit' => true,
             ];

Zend/tests/gh10346.phpt

@@ -6,6 +6,7 @@ Florian Sowade
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 --FILE--
 <?php

ext/ffi/tests/gh12905.phpt

@@ -14,6 +14,7 @@ try {
 --INI--
 ffi.enable=1
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 zend_test.observer.show_return_value=0
 --FILE--

ext/opcache/tests/gh13712.phpt

@@ -5,6 +5,7 @@ opcache
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 opcache.enable=1
 opcache.enable_cli=1
 --FILE--

ext/opcache/tests/jit/ignored_opcodes.phpt

@@ -8,6 +8,7 @@ opcache.jit_buffer_size=1M
 opcache.jit=function
 ;opcache.jit_debug=257
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 zend_test.observer.show_opcode_in_user_handler=ZEND_EXIT, ZEND_BEGIN_SILENCE, ZEND_END_SILENCE
 --EXTENSIONS--

ext/zend_test/tests/gh9871.phpt

@@ -5,6 +5,7 @@ zend_test
 --INI--
 opcache.enable_cli=1
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 zend_test.observer.show_return_value=1
 --FILE--

ext/zend_test/tests/observer_backtrace_01.phpt

@@ -4,6 +4,7 @@ Observer: Show backtrace on init
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 zend_test.observer.show_init_backtrace=1
 --FILE--

ext/zend_test/tests/observer_basic_01.phpt

@@ -4,6 +4,7 @@ Observer: Basic observability of userland functions
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 --FILE--
 <?php

ext/zend_test/tests/observer_basic_02.phpt

@@ -4,6 +4,7 @@ Observer: Basic observability of userland methods
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 --FILE--
 <?php

ext/zend_test/tests/observer_basic_03.phpt

@@ -4,6 +4,7 @@ Observer: Basic observability of includes
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 --FILE--
 <?php

ext/zend_test/tests/observer_basic_04.phpt

@@ -4,6 +4,7 @@ Observer: Basic observability of includes only (no functions)
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_includes=1
 --FILE--
 <?php

ext/zend_test/tests/observer_basic_05.phpt

@@ -4,6 +4,7 @@ Observer: Basic observability of functions only (no includes)
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_functions=1
 --FILE--
 <?php

ext/zend_test/tests/observer_basic_06.phpt

@@ -4,6 +4,7 @@ Observer: Basic observability of functions only (with run-time swapping)
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_function_names=foo
 --FILE--
 <?php

ext/zend_test/tests/observer_bug81430_1.phpt

@@ -5,6 +5,7 @@ zend_test
 --INI--
 memory_limit=20M
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 --FILE--
 <?php

ext/zend_test/tests/observer_bug81430_2.phpt

@@ -5,6 +5,7 @@ zend_test
 --INI--
 memory_limit=20M
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 --SKIPIF--
 <?php

ext/zend_test/tests/observer_bug81435.phpt

@@ -5,6 +5,7 @@ zend_test
 --INI--
 memory_limit=20M
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_function_names=a,d
 opcache.optimization_level=0
 --SKIPIF--

ext/zend_test/tests/observer_call_user_func_01.phpt

@@ -4,6 +4,7 @@ Observer: call_user_func() from root namespace
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 --FILE--
 <?php

ext/zend_test/tests/observer_call_user_func_02.phpt

@@ -4,6 +4,7 @@ Observer: call_user_func_array() from root namespace
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 --FILE--
 <?php

ext/zend_test/tests/observer_call_user_func_03.phpt

@@ -4,6 +4,7 @@ Observer: call_user_func() from namespace
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 --FILE--
 <?php

ext/zend_test/tests/observer_call_user_func_04.phpt

@@ -4,6 +4,7 @@ Observer: call_user_func_array() from namespace
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 --FILE--
 <?php

ext/zend_test/tests/observer_closure_01.phpt

@@ -4,6 +4,7 @@ Observer: Basic observability of closures
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 --FILE--
 <?php

ext/zend_test/tests/observer_closure_02.phpt

@@ -4,6 +4,7 @@ Observer: Observability of fake closures
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 --FILE--
 <?php

ext/zend_test/tests/observer_closure_03.phpt

@@ -4,6 +4,7 @@ Observer: Observability of closures of builtin functions
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 --FILE--
 <?php

ext/zend_test/tests/observer_declarations_01.phpt

@@ -4,6 +4,7 @@ Observer: Observe function and class declarations
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 zend_test.observer.observe_declaring=1
 --FILE--

ext/zend_test/tests/observer_declarations_file_cache.phpt

@@ -4,6 +4,7 @@ Observer: Observe function and class declarations with file_cache_only
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_declaring=1
 opcache.enable_cli=1
 opcache.file_cache="{TMP}"

ext/zend_test/tests/observer_error_01.phpt

@@ -4,6 +4,7 @@ Observer: End handlers fire after a fatal error
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 zend_test.observer.show_return_value=1
 memory_limit=2M

ext/zend_test/tests/observer_error_02.phpt

@@ -4,6 +4,7 @@ Observer: End handlers fire after a userland fatal error
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 zend_test.observer.show_return_value=1
 --FILE--

ext/zend_test/tests/observer_error_03.phpt

@@ -4,6 +4,7 @@ Observer: non-fatal errors do not fire end handlers prematurely
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 zend_test.observer.show_return_value=1
 --FILE--

ext/zend_test/tests/observer_error_04.phpt

@@ -5,6 +5,7 @@ zend_test
 soap
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 zend_test.observer.show_return_value=1
 --FILE--

ext/zend_test/tests/observer_error_05.phpt

@@ -4,6 +4,7 @@ Observer: End handlers fire after a userland fatal error
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 zend_test.observer.show_return_value=1
 --FILE--

ext/zend_test/tests/observer_eval_01.phpt

@@ -4,6 +4,7 @@ Observer: Basic eval observability
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 --FILE--
 <?php

ext/zend_test/tests/observer_exception_01.phpt

@@ -4,6 +4,7 @@ Observer: Basic observability of userland functions with uncaught exceptions
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 --FILE--
 <?php

ext/zend_test/tests/observer_fiber_01.phpt

@@ -4,6 +4,7 @@ Observer: Basic fiber switching
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.fiber_init=1
 zend_test.observer.fiber_switch=1
 zend_test.observer.fiber_destroy=1

ext/zend_test/tests/observer_fiber_02.phpt

@@ -4,6 +4,7 @@ Observer: Unfinished fiber
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.fiber_switch=1
 --FILE--
 <?php

ext/zend_test/tests/observer_fiber_03.phpt

@@ -4,6 +4,7 @@ Observer: Nested fibers
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.fiber_switch=1
 --FILE--
 <?php

ext/zend_test/tests/observer_fiber_04.phpt

@@ -4,6 +4,7 @@ Observer: Nested fibers with unfinished fiber
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.fiber_switch=1
 --FILE--
 <?php

ext/zend_test/tests/observer_fiber_05.phpt

@@ -4,6 +4,7 @@ Observer: Nested fibers with both unfinished
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.fiber_switch=1
 --FILE--
 <?php

ext/zend_test/tests/observer_fiber_06.phpt

@@ -4,6 +4,7 @@ Observer: Throwing fiber
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.fiber_switch=1
 --FILE--
 <?php

ext/zend_test/tests/observer_fiber_functions_01.phpt

@@ -4,6 +4,7 @@ Observer: Basic function observing in fibers
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 zend_test.observer.fiber_init=1
 zend_test.observer.fiber_switch=1

ext/zend_test/tests/observer_fiber_functions_02.phpt

@@ -4,6 +4,7 @@ Observer: Function observing in fibers with unfinished fiber
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 zend_test.observer.fiber_init=1
 zend_test.observer.fiber_switch=1

ext/zend_test/tests/observer_fiber_functions_03.phpt

@@ -4,6 +4,7 @@ Observer: Function observing in fibers with bailout in fiber
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 zend_test.observer.fiber_init=1
 zend_test.observer.fiber_switch=1

ext/zend_test/tests/observer_generator_01.phpt

@@ -4,6 +4,7 @@ Observer: Basic generator observability
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 zend_test.observer.show_return_value=1
 --FILE--

ext/zend_test/tests/observer_generator_02.phpt

@@ -4,6 +4,7 @@ Observer: Generator with explicit return
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 zend_test.observer.show_return_value=1
 --FILE--

ext/zend_test/tests/observer_generator_03.phpt

@@ -4,6 +4,7 @@ Observer: Generator with 'yield from'
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 zend_test.observer.show_return_value=1
 --FILE--

ext/zend_test/tests/observer_generator_04.phpt

@@ -4,6 +4,7 @@ Observer: Generator with manual traversal
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 zend_test.observer.show_return_value=1
 --FILE--

ext/zend_test/tests/observer_generator_05.phpt

@@ -4,6 +4,7 @@ Observer: Generator with uncaught exception
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 zend_test.observer.show_return_value=1
 --FILE--

ext/zend_test/tests/observer_magic_01.phpt

@@ -4,6 +4,7 @@ Observer: Basic magic method observability
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 --FILE--
 <?php

ext/zend_test/tests/observer_opline_01.phpt

@@ -4,6 +4,7 @@ Observer: Ensure opline exists on the execute_data
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 zend_test.observer.show_opcode=1
 opcache.jit=0

ext/zend_test/tests/observer_preload.phpt

@@ -15,6 +15,7 @@ opcache.preload={PWD}/observer_preload.inc
 opcache.file_cache=
 opcache.file_cache_only=0
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 zend_test.observer.observe_declaring=1
 zend_test.observer.show_return_value=1

ext/zend_test/tests/observer_retval_01.phpt

@@ -4,6 +4,7 @@ Observer: Retvals are observable that are: IS_CONST
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 zend_test.observer.show_return_value=1
 opcache.optimization_level=0

ext/zend_test/tests/observer_retval_02.phpt

@@ -4,6 +4,7 @@ Observer: Unused retvals from generators are still observable
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 zend_test.observer.show_return_value=1
 --FILE--

ext/zend_test/tests/observer_retval_03.phpt

@@ -4,6 +4,7 @@ Observer: Retvals are observable that are: refcounted, IS_CV
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 zend_test.observer.show_return_value=1
 --FILE--

ext/zend_test/tests/observer_retval_04.phpt

@@ -4,6 +4,7 @@ Observer: Retvals are observable that are: refcounted, IS_VAR
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 zend_test.observer.show_return_value=1
 --FILE--

ext/zend_test/tests/observer_retval_05.phpt

@@ -4,6 +4,7 @@ Observer: Retvals are observable that are: IS_CV, IS_UNDEF
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 zend_test.observer.show_return_value=1
 --FILE--

ext/zend_test/tests/observer_retval_06.phpt

@@ -4,6 +4,7 @@ Observer: Retvals are observable that are: IS_CV
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 zend_test.observer.show_return_value=1
 --FILE--

ext/zend_test/tests/observer_retval_07.phpt

@@ -4,6 +4,7 @@ Observer: Retvals are observable that are: IS_REFERENCE, IS_VAR
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 zend_test.observer.show_return_value=1
 --FILE--

ext/zend_test/tests/observer_retval_by_ref_01.phpt

@@ -4,6 +4,7 @@ Observer: Retvals by reference are observable that are: IS_CV
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 zend_test.observer.show_return_value=1
 --FILE--

ext/zend_test/tests/observer_retval_by_ref_02.phpt

@@ -4,6 +4,7 @@ Observer: Retvals by reference are observable that are: IS_TMP_VAR
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 zend_test.observer.show_return_value=1
 --FILE--

ext/zend_test/tests/observer_retval_by_ref_03.phpt

@@ -4,6 +4,7 @@ Observer: Retvals by reference are observable that are: IS_VAR, ZEND_RETURNS_FUN
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 zend_test.observer.show_return_value=1
 opcache.optimization_level=0

ext/zend_test/tests/observer_shutdown_01.phpt

@@ -4,6 +4,7 @@ Observer: Function calls from a shutdown handler are observable
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 zend_test.observer.show_return_value=1
 --FILE--

ext/zend_test/tests/observer_shutdown_02.phpt

@@ -4,6 +4,7 @@ Observer: Function calls from a __destruct during shutdown are observable
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 zend_test.observer.show_return_value=1
 --FILE--

ext/zend_test/tests/observer_sqlite_create_function.phpt

@@ -6,6 +6,7 @@ pdo
 pdo_sqlite
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 --FILE--
 <?php

ext/zend_test/tests/observer_types_01.phpt

@@ -4,6 +4,7 @@ Observer: Observe basic TypeError
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 zend_test.observer.show_return_value=1
 --FILE--

ext/zend_test/tests/observer_zend_call_function_01.phpt

@@ -4,6 +4,7 @@ Observer: Calls that go through zend_call_function are observed
 zend_test
 --INI--
 zend_test.observer.enabled=1
+zend_test.observer.show_output=1
 zend_test.observer.observe_all=1
 --FILE--
 <?php