archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-16 05:58:45 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Implemented fix for incorrect filedescriptor closing

Browse source
This commit is contained in:
Joshua Thijssen 2015-10-21 13:21:03 +02:00
parent ccc95bf9df
commit e7f23e164b
2 changed files with 52 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

13
ext/standard/proc_open.c
View file

@ -854,6 +854,12 @@ PHP_FUNCTION(proc_open)
} }
#endif #endif
#if PHP_CAN_DO_PTS
if (dev_ptmx >= 0) {
close(dev_ptmx);
close(slave_pty);
}
#endif
/* close those descriptors that we just opened for the parent stuff, /* close those descriptors that we just opened for the parent stuff,
* dup new descriptors into required descriptors and close the original * dup new descriptors into required descriptors and close the original
* cruft */ * cruft */
@ -869,13 +875,6 @@ PHP_FUNCTION(proc_open)
close(descriptors[i].childend); close(descriptors[i].childend);
} }
#if PHP_CAN_DO_PTS
if (dev_ptmx >= 0) {
close(dev_ptmx);
close(slave_pty);
}
#endif
if (cwd) { if (cwd) {
php_ignore_value(chdir(cwd)); php_ignore_value(chdir(cwd));
} }

46
ext/standard/tests/file/bug69442.phpt Normal file
View file

@ -0,0 +1,46 @@
--TEST--
proc_open with PTY closes incorrect file descriptor
--SKIPIF--
<?php
$code = <<< 'EOC'
<?php
$descriptors = array(array("pty"), array("pty"), array("pty"), array("pipe", "w"));
$pipes = array();
$process = proc_open('echo "foo";', $descriptors, $pipes);
EOC;
$tmpFile = tempnam(sys_get_temp_dir(), "bug69442");
file_put_contents($tmpFile, $code);
exec($_SERVER['TEST_PHP_EXECUTABLE']." ".$tmpFile." 2>&1", $output);
$output = join("\n", $output);
unlink($tmpFile);
if (strstr($output, "pty pseudo terminal not supported on this system") !== false) {
die("skip PTY pseudo terminals are not supported");
}
--FILE--
<?php
$cmd = '(echo "foo" ; exit 42;) 3>/dev/null; code=$?; echo $code >&3; exit $code';
$descriptors = array(array("pty"), array("pty"), array("pty"), array("pipe", "w"));
$pipes = array();
$process = proc_open($cmd, $descriptors, $pipes);
foreach ($pipes as $type => $pipe) {
$data = fread($pipe, 999);
echo 'type ' . $type . ' ';
var_dump($data);
fclose($pipe);
}
proc_close($process);
--EXPECT--
type 0 string(5) "foo
"
type 1 string(0) ""
type 2 string(0) ""
type 3 string(3) "42
"