archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-15 21:48:51 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Merge branch 'PHP-8.4'

Browse source 
* PHP-8.4:
  Disallow asymmetric visibility on static properties
This commit is contained in:
Ilija Tovilo 2024-10-16 23:00:41 +02:00
commit ec152105f2
No known key found for this signature in database
GPG key ID: 5050C66BFCD1015A
2 changed files with 16 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Zend/tests/asymmetric_visibility/static_props.phpt Normal file
View file

@ -0,0 +1,12 @@
--TEST--
Asymmetric visibility on static props
--FILE--
<?php
class C {
public private(set) static int $prop;
}
?>
--EXPECTF--
Fatal error: Static property may not have asymmetric visibility in %s on line %d

4
Zend/zend_compile.c
View file

@ -8598,6 +8598,10 @@ static void zend_compile_prop_decl(zend_ast *ast, zend_ast *type_ast, uint32_t f
zend_error_noreturn(E_COMPILE_ERROR, "Property cannot be both final and private"); zend_error_noreturn(E_COMPILE_ERROR, "Property cannot be both final and private");
} }
if ((flags & ZEND_ACC_STATIC) && (flags & ZEND_ACC_PPP_SET_MASK)) {
zend_error_noreturn(E_COMPILE_ERROR, "Static property may not have asymmetric visibility");
}
if (ce->ce_flags & ZEND_ACC_INTERFACE) { if (ce->ce_flags & ZEND_ACC_INTERFACE) {
if (flags & ZEND_ACC_FINAL) { if (flags & ZEND_ACC_FINAL) {
zend_error_noreturn(E_COMPILE_ERROR, "Property in interface cannot be final"); zend_error_noreturn(E_COMPILE_ERROR, "Property in interface cannot be final");