From ec2655f88b8a4cad2619fa8b92dbdee2e57a9031 Mon Sep 17 00:00:00 2001 From: "Christoph M. Becker" Date: Wed, 14 Aug 2024 21:09:26 +0200 Subject: [PATCH] Voidify getfilesystemtime() (GH-15413) The function always returned 0, and the return values was never used, so we declare it to return void. While we're at it, we also fix the space indentation of the comment. --- win32/time.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/win32/time.c b/win32/time.c index 57db914e6a8..ac1abbc9e9c 100644 --- a/win32/time.c +++ b/win32/time.c @@ -23,7 +23,7 @@ #include #include "php_win32_globals.h" -static zend_always_inline int getfilesystemtime(struct timeval *tv) +static zend_always_inline void getfilesystemtime(struct timeval *tv) {/*{{{*/ FILETIME ft; unsigned __int64 ff = 0; @@ -31,7 +31,7 @@ static zend_always_inline int getfilesystemtime(struct timeval *tv) GetSystemTimePreciseAsFileTime(&ft); - /* + /* * Do not cast a pointer to a FILETIME structure to either a * ULARGE_INTEGER* or __int64* value because it can cause alignment faults on 64-bit Windows. * via http://technet.microsoft.com/en-us/library/ms724284(v=vs.85).aspx @@ -45,8 +45,6 @@ static zend_always_inline int getfilesystemtime(struct timeval *tv) tv->tv_sec = (long)(ff / 1000000Ui64); tv->tv_usec = (long)(ff % 1000000Ui64); - - return 0; }/*}}}*/ PHPAPI int gettimeofday(struct timeval *time_Info, struct timezone *timezone_Info)