archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-16 05:58:45 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

unserialize: Deprecate the 'S' tag (#12309)

Browse source 
RFC: https://wiki.php.net/rfc/deprecations_php_8_4
This commit is contained in:
Tim Düsterhus 2024-08-04 18:23:19 +02:00 • committed by GitHub
parent d6a75e19d1
commit ecd11b9687
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 23 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
NEWS
View file

@ -14,6 +14,9 @@ PHP NEWS
. array out of bounds, stack overflow handled for segfault handler on windows. . array out of bounds, stack overflow handled for segfault handler on windows.
(David Carlier) (David Carlier)
- Standard:
. Unserializing the uppercase 'S' tag is now deprecated. (timwolla)
01 Aug 2024, PHP 8.4.0alpha4 01 Aug 2024, PHP 8.4.0alpha4
- GMP: - GMP:

2
UPGRADING
View file

@ -446,6 +446,8 @@ PHP 8.4 UPGRADE NOTES
. Calling stream_context_set_option() with 2 arguments is deprecated. . Calling stream_context_set_option() with 2 arguments is deprecated.
Use stream_context_set_options() instead. Use stream_context_set_options() instead.
. Raising zero to the power of negative number is deprecated. . Raising zero to the power of negative number is deprecated.
. Unserializing strings using the uppercase 'S' tag is deprecated.
RFC: https://wiki.php.net/rfc/deprecations_php_8_4
======================================== ========================================
5. Changed Functions 5. Changed Functions

15
ext/standard/tests/serialize/unserialize_uppercase_s.phpt Normal file
View file

@ -0,0 +1,15 @@
--TEST--
Test unserialize() with the 'S' format emits a deprecation.
--FILE--
<?php
var_dump(unserialize('S:1:"e";'));
var_dump(unserialize('S:1:"\65";'));
?>
--EXPECTF--
Deprecated: unserialize(): Unserializing the 'S' format is deprecated in %s on line %d
string(1) "e"
Deprecated: unserialize(): Unserializing the 'S' format is deprecated in %s on line %d
string(1) "e"

3
ext/standard/var_unserializer.re
View file

@ -1089,6 +1089,9 @@ use_double:
*p = YYCURSOR; *p = YYCURSOR;
ZVAL_STR(rval, str); ZVAL_STR(rval, str);
php_error_docref(NULL, E_DEPRECATED, "Unserializing the 'S' format is deprecated");
return 1; return 1;
} }