archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-16 22:18:50 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

- Fixed bug #49074 (private class static fields can be modified by using reflection)

Browse source
This commit is contained in:
Jani Taskinen 2009-08-01 00:48:04 +00:00
parent 8608857c1a
commit edbf332cea
2 changed files with 12 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
NEWS
View file

@ -1,4 +1,4 @@
PHP NEWS PHP NEWS
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
?? ??? 2009, PHP 5.3.1 ?? ??? 2009, PHP 5.3.1
- Fixed spl_autoload_unregister/spl_autoload_functions wrt. Closures and - Fixed spl_autoload_unregister/spl_autoload_functions wrt. Closures and
@ -8,7 +8,8 @@
- Fixed signature generation/validation for zip archives in ext/phar. (Greg) - Fixed signature generation/validation for zip archives in ext/phar. (Greg)
- Fixed memory leak in stream_is_local(). (Felipe) - Fixed memory leak in stream_is_local(). (Felipe)
- Fixed bug #48880 (Random Appearing open_basedir problem). (Rasmus+Gwynne) - Fixed bug #49074 (private class static fields can be modified by using
reflection). (Jani)
- Fixed bug #49108 (2nd scan_dir produces seg fault). (Felipe) - Fixed bug #49108 (2nd scan_dir produces seg fault). (Felipe)
- Fixed bug #49065 ("disable_functions" php.ini option does not work on - Fixed bug #49065 ("disable_functions" php.ini option does not work on
Zend extensions). (Stas) Zend extensions). (Stas)
@ -46,6 +47,7 @@
- Fixed bug #48854 (array_merge_recursive modifies arrays after first one). - Fixed bug #48854 (array_merge_recursive modifies arrays after first one).
(Felipe) (Felipe)
- Fixed bug #48802 (printf() returns incorrect outputted length). (Jani) - Fixed bug #48802 (printf() returns incorrect outputted length). (Jani)
- Fixed bug #48880 (Random Appearing open_basedir problem). (Rasmus, Gwynne)
- Fixed bug #48791 (open office files always reported as corrupted). (Greg) - Fixed bug #48791 (open office files always reported as corrupted). (Greg)
- Fixed bug #48788 (RecursiveDirectoryIterator doesn't descend into symlinked - Fixed bug #48788 (RecursiveDirectoryIterator doesn't descend into symlinked
directories). (Ilia) directories). (Ilia)

10
ext/reflection/php_reflection.c
View file

@ -3030,6 +3030,7 @@ ZEND_METHOD(reflection_class, getStaticProperties)
if (zend_parse_parameters_none() == FAILURE) { if (zend_parse_parameters_none() == FAILURE) {
return; return;
} }
GET_REFLECTION_OBJECT_PTR(ce); GET_REFLECTION_OBJECT_PTR(ce);
zend_update_class_constants(ce TSRMLS_CC); zend_update_class_constants(ce TSRMLS_CC);
@ -3045,12 +3046,17 @@ ZEND_METHOD(reflection_class, getStaticProperties)
if (zend_hash_get_current_key_ex(CE_STATIC_MEMBERS(ce), &key, &key_len, &num_index, 0, &pos) != FAILURE && key) { if (zend_hash_get_current_key_ex(CE_STATIC_MEMBERS(ce), &key, &key_len, &num_index, 0, &pos) != FAILURE && key) {
char *prop_name, *class_name; char *prop_name, *class_name;
zval *prop_copy;
zend_unmangle_property_name(key, key_len-1, &class_name, &prop_name); zend_unmangle_property_name(key, key_len-1, &class_name, &prop_name);
zval_add_ref(value); /* copy: enforce read only access */
ALLOC_ZVAL(prop_copy);
*prop_copy = **value;
zval_copy_ctor(prop_copy);
INIT_PZVAL(prop_copy);
zend_hash_update(Z_ARRVAL_P(return_value), prop_name, strlen(prop_name)+1, value, sizeof(zval *), NULL); add_assoc_zval(return_value, prop_name, prop_copy);
} }
zend_hash_move_forward_ex(CE_STATIC_MEMBERS(ce), &pos); zend_hash_move_forward_ex(CE_STATIC_MEMBERS(ce), &pos);
} }