archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-15 21:48:51 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Get rid of impossible error branch

Browse source
This commit is contained in:
Niels Dossche 2024-04-02 22:44:46 +02:00
parent 88449f6798
commit f02fd58809
1 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
ext/dom/dom_iterators.c
View file

@ -206,9 +206,10 @@ static void php_dom_iterator_move_forward(zend_object_iterator *iter) /* {{{ */
/* The collection is live, we nav the tree from the base object if we cannot /* The collection is live, we nav the tree from the base object if we cannot
* use the cache to restart from the last point. */ * use the cache to restart from the last point. */
xmlNodePtr basenode = dom_object_get_node(objmap->baseobj); xmlNodePtr basenode = dom_object_get_node(objmap->baseobj);
if (UNEXPECTED(!basenode)) {
goto err; /* We have a strong reference to the base node via baseobj_zv, this cannot become NULL */
} ZEND_ASSERT(basenode != NULL);
int previndex; int previndex;
if (php_dom_is_cache_tag_stale_from_node(&iterator->cache_tag, basenode)) { if (php_dom_is_cache_tag_stale_from_node(&iterator->cache_tag, basenode)) {
php_dom_mark_cache_tag_up_to_date_from_node(&iterator->cache_tag, basenode); php_dom_mark_cache_tag_up_to_date_from_node(&iterator->cache_tag, basenode);
@ -234,7 +235,7 @@ static void php_dom_iterator_move_forward(zend_object_iterator *iter) /* {{{ */
} }
} }
} }
err:
zval_ptr_dtor(&iterator->curobj); zval_ptr_dtor(&iterator->curobj);
ZVAL_UNDEF(&iterator->curobj); ZVAL_UNDEF(&iterator->curobj);