From f6c464fee56f34080e89c9c0ffd0eb20b501c5d2 Mon Sep 17 00:00:00 2001 From: Gina Peter Bnayard Date: Sun, 18 Aug 2024 20:10:12 +0200 Subject: [PATCH] ext/gettext: Remove duplicate domain length checks It not being empty is already checked by PHP_GETTEXT_DOMAIN_LENGTH_CHECK() --- ext/gettext/gettext.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/ext/gettext/gettext.c b/ext/gettext/gettext.c index 96ee53144ac..ee94fcb26ed 100644 --- a/ext/gettext/gettext.c +++ b/ext/gettext/gettext.c @@ -190,11 +190,6 @@ PHP_FUNCTION(bindtextdomain) PHP_GETTEXT_DOMAIN_LENGTH_CHECK(1, ZSTR_LEN(domain)) - if (!ZSTR_LEN(domain)) { - zend_argument_cannot_be_empty_error(1); - RETURN_THROWS(); - } - if (dir == NULL) { RETURN_STRING(bindtextdomain(ZSTR_VAL(domain), NULL)); } @@ -312,11 +307,6 @@ PHP_FUNCTION(bind_textdomain_codeset) PHP_GETTEXT_DOMAIN_LENGTH_CHECK(1, ZSTR_LEN(domain)) - if (!ZSTR_LEN(domain)) { - zend_argument_cannot_be_empty_error(1); - RETURN_THROWS(); - } - retval = bind_textdomain_codeset(ZSTR_VAL(domain), codeset ? ZSTR_VAL(codeset) : NULL); if (!retval) {