- Implemented "break N" where N is the line number on the current file

phpdbg_prompt.c

@@ -382,8 +382,19 @@ static PHPDBG_COMMAND(break) /* {{{ */
 		    }
 		}
 	} else {
-		if (expr_len > 2 && expr[0] == '0' && expr[1] == 'x') {
+		if (phpdbg_is_addr(expr)) {
 			phpdbg_set_breakpoint_opline(expr TSRMLS_CC);
+		} else if (phpdbg_is_numeric(expr)) {
+			const char *filename = zend_get_executed_filename(TSRMLS_C);
+			long line_num = strtol(expr, NULL, 0);
+
+			if (!filename) {
+				printf("%sNo file context found%s\n",
+					PHPDBG_RED_LINE(TSRMLS_C), PHPDBG_END_LINE(TSRMLS_C));
+				return FAILURE;
+			}
+
+			phpdbg_set_breakpoint_file(filename, line_num TSRMLS_CC);
 		} else {
 			char name[200];
 			size_t name_len = strlen(expr);
@@ -395,7 +406,8 @@ static PHPDBG_COMMAND(break) /* {{{ */
 
 				phpdbg_set_breakpoint_symbol(name TSRMLS_CC);
 			} else {
-		        printf("%sMalformed break command found%s\n", PHPDBG_RED_LINE(TSRMLS_C), PHPDBG_END_LINE(TSRMLS_C));
+				printf("%sMalformed break command found%s\n",
+					PHPDBG_RED_LINE(TSRMLS_C), PHPDBG_END_LINE(TSRMLS_C));
 				return FAILURE;
 			}
 		}

phpdbg_utils.c

@@ -41,3 +41,8 @@ int phpdbg_is_empty(const char *str) /* {{{ */
 	}
 	return 1;
 } /* }}} */
+
+int phpdbg_is_addr(const char *str) /* {{{ */
+{
+	return str[0] && str[1] && memcmp(str, "0x", 2) == 0;
+} /* }}} */

phpdbg_utils.h

@@ -22,5 +22,6 @@
 
 int phpdbg_is_numeric(const char*);
 int phpdbg_is_empty(const char*);
+int phpdbg_is_addr(const char*);
 
 #endif /* PHPDBG_UTILS_H */