Máté Kocsis
610815c0ce
Improve gen_stub.php
...
Closes GH-5350
Add support for generating deprecated function entries, as well as forward declaration
of function aliases.
2020-04-04 23:52:33 +02:00
George Peter Banyard
c3e65d9069
Fix [-Wtype-limits] warning in LDAP by removing unnecessary condition
...
As context is a pointer to a berval struct and bv_len is of type
ber_len_t [1] which it self is defined as an unsigned integer [2]
this condition is always true.
[1] https://www.openldap.org/devel/gitweb.cgi?p=openldap.git;a=blob;f=include/lber.h#l212
[2] https://www.openldap.org/software//man.cgi?query=ber_free&sektion=3&apropos=0&manpath=OpenLDAP+2.4-Release
2020-02-06 13:20:15 +01:00
Máté Kocsis
d1764ca330
Make error messages more consistent by fixing capitalization
...
Closes GH-5066 As a first step, let's capitalize their initial letter when it is applicable.
2020-01-17 14:52:46 +01:00
Máté Kocsis
1abea33b1e
Fix usage of RETURN_THROWS() in LDAP extension
2020-01-03 22:40:16 +01:00
Máté Kocsis
aadd3aaed9
Use RETURN_THROWS() in various places
2020-01-03 21:10:24 +01:00
Máté Kocsis
bbcfa66e06
Use RETURN_THROWS() after zend_fetch_resource*()
2020-01-03 19:20:56 +01:00
Christoph M. Becker
d694edaee4
Fix erroneous change
2019-12-31 12:24:01 +01:00
Máté Kocsis
345703724c
Use RETURN_THROWS() during ZPP in most of the extensions
...
Except for some bigger ones: reflection, sodium, spl
2019-12-31 11:46:11 +01:00
Máté Kocsis
9493893412
Cleanup return values when parameter parsing is unsuccessful
2019-10-30 16:05:20 +01:00
Stephen Reay
72e3b252e8
Adding ldap stubs for arginfo
2019-09-25 15:09:25 +02:00
Gabriel Caruso
5d6e923d46
Remove mention of PHP major version in Copyright headers
...
Closes GH-4732.
2019-09-25 14:51:43 +02:00
Nikita Popov
2789ad982e
Merge branch 'PHP-7.4'
2019-09-06 14:48:31 +02:00
Nikita Popov
025ff3b5a3
Remove nsldap support
...
The newest version we're checking (libssldap50) seems to be about
15 years out of date. We could add support for libssldap60 (also
unmainted, but more recent), but given how nobody has expressed any
interest in this, I'm going ahead and dropping this code.
2019-09-06 14:39:42 +02:00
Nikita Popov
0d8a399afa
Merge branch 'PHP-7.4'
2019-08-29 19:07:59 +02:00
Nikita Popov
48ff226cae
Fix potentially uninitialized use in ldap
...
If ctrl->ldctl_value.bv_len is zero context is uninitialized. Only
free it if the call took place and succeeded.
2019-08-29 19:07:45 +02:00
Christoph M. Becker
6cd821b2d1
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Don't modify arrays passed by value
2019-08-25 18:29:08 +02:00
Christoph M. Becker
ac40d0ffbc
Don't modify arrays passed by value
2019-08-25 18:27:35 +02:00
Nikita Popov
85b17a0429
Remove some unnecessary RETURN_FALSE
2019-08-20 17:08:19 +02:00
Christoph M. Becker
9c0c20b9f8
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Don't use C++ style comments
2019-08-20 13:59:20 +02:00
Christoph M. Becker
ae923287ca
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Don't use C++ style comments
2019-08-20 13:58:54 +02:00
Christoph M. Becker
963b40c9a8
Don't use C++ style comments
...
Cf. <f45b61b898/CODING_STANDARDS.md (syntax-and-indentation)
>
cc @mcmic
2019-08-20 13:58:22 +02:00
Nikita Popov
ac749b126f
Merge branch 'PHP-7.4'
2019-06-26 11:43:30 +02:00
Nikita Popov
80958d0f90
Use ldap_destroy instead of ldap_unbind_ext
2019-06-26 11:43:11 +02:00
Nikita Popov
ca2a6f75bf
Merge branch 'PHP-7.4'
2019-06-14 11:14:08 +02:00
Nikita Popov
ec77cca5f3
Merge branch 'PHP-7.3' into PHP-7.4
2019-06-14 11:13:43 +02:00
Nikita Popov
98457b6d60
Fix some leaks in ldap
...
The result of zval_get_string() needs to be released. In some places
where it is inconvenient to manage, I went back to convert_to_string.
It is safe in those places due to existing array separations.
Also fix a preexisting leak when getting controls, the previous
value was not destroyed.
2019-06-14 11:11:24 +02:00
Côme Chilliet
890e846d85
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Some more string conversion handling, fixing bug #77958
Avoid converting zval when not needed
2019-06-13 22:15:41 +02:00
Côme Chilliet
9684d5f282
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Some more string conversion handling, fixing bug #77958
Avoid converting zval when not needed
2019-06-13 22:15:13 +02:00
Côme Chilliet
5d2fe48785
Some more string conversion handling, fixing bug #77958
2019-06-13 22:12:34 +02:00
Côme Chilliet
c219d8d5c2
Avoid converting zval when not needed
...
Also added exception checks so that exception from __toString are
correctly handled in the future
2019-06-13 20:58:45 +02:00
Nikita Popov
466666c616
Merge branch 'PHP-7.4'
2019-06-11 17:12:33 +02:00
Hugh McMaster
9d61036651
ext/ldap: Use PKG_CHECK_MODULES to detect the libsasl2 library
2019-06-11 17:11:53 +02:00
Dmitry Stogov
e188e4170f
Use ZEND_TRY_ASSIGN_REF_... macros for arguments passed to internal function by reference
2019-04-24 18:28:29 +03:00
Dmitry Stogov
2e4686b566
Use ZEND_TRY_ASSIGN_REF_... macros for arguments passed to internal function by reference
2019-04-24 18:16:47 +03:00
Dmitry Stogov
34db07567d
Use ZEND_TRA_ASSIGN_REF_... macros for by reference arguments of internal functions.
2019-04-24 16:14:48 +03:00
Côme Chilliet
9d38510ab4
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Updated NEWS
Fix a NULL dereferencing crash in php-ldap
2019-04-15 10:21:27 +02:00
Côme Chilliet
f31435b855
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Updated NEWS
Fix a NULL dereferencing crash in php-ldap
2019-04-15 10:20:12 +02:00
Côme Chilliet
ea0f26420d
Fix a NULL dereferencing crash in php-ldap
...
This happens when parsing a control response to a VLV request which does
not contain a "context" string.
See bug #77869
2019-04-15 10:16:29 +02:00
Dmitry Stogov
5f09db3073
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Switch to use ZTS cache
2019-03-12 14:17:14 +03:00
Dmitry Stogov
f1b306fe11
Switch to use ZTS cache
2019-03-12 14:15:47 +03:00
Côme Chilliet
f0ddc93f46
Removed ldap_sort and LDAP_DEPRECATED build flag
...
ldap_sort was deprecated in PHP7, it is now removed.
This allows removing the LDAP_DEPRECATED flag when building against
openldap.
2019-02-04 13:10:05 +01:00
Côme Chilliet
d93ce17959
Mark ldap_control_paged_result and ldap_control_paged_result_response as deprecated
...
These functions have serious limitations and may confuse users.
Same operations can be done using the new ldap control system in search
operations.
2019-02-04 12:20:51 +01:00
Peter Kokot
92ac598aab
Remove local variables
...
This patch removes the so called local variables defined per
file basis for certain editors to properly show tab width, and
similar settings. These are mainly used by Vim and Emacs editors
yet with recent changes the once working definitions don't work
anymore in Vim without custom plugins or additional configuration.
Neither are these settings synced across the PHP code base.
A simpler and better approach is EditorConfig and fixing code
using some code style fixing tools in the future instead.
This patch also removes the so called modelines for Vim. Modelines
allow Vim editor specifically to set some editor configuration such as
syntax highlighting, indentation style and tab width to be set in the
first line or the last 5 lines per file basis. Since the php test
files have syntax highlighting already set in most editors properly and
EditorConfig takes care of the indentation settings, this patch removes
these as well for the Vim 6.0 and newer versions.
With the removal of local variables for certain editors such as
Emacs and Vim, the footer is also probably not needed anymore when
creating extensions using ext_skel.php script.
Additionally, Vim modelines for setting php syntax and some editor
settings has been removed from some *.phpt files. All these are
mostly not relevant for phpt files neither work properly in the
middle of the file.
2019-02-03 21:03:00 +01:00
Zeev Suraski
0cf7de1c70
Remove yearly range from copyright notice
2019-01-30 11:03:12 +02:00
Nikita Popov
e219ec144e
Implement typed properties
...
RFC: https://wiki.php.net/rfc/typed_properties_v2
This is a squash of PR #3734 , which is a squash of PR #3313 .
Co-authored-by: Bob Weinand <bobwei9@hotmail.com>
Co-authored-by: Joe Watkins <krakjoe@php.net>
Co-authored-by: Dmitry Stogov <dmitry@zend.com>
2019-01-11 15:49:06 +01:00
Zeev Suraski
9afce019e0
Future-proof email addresses
2018-11-01 18:35:32 +02:00
Zeev Suraski
67e0138c0d
Future-proof email addresses...
2018-11-01 18:30:28 +02:00
Nikita Popov
1d0252a1c0
Remove IS_EXT_MODULE defines
...
I'm not sure what this was used for, but it doesn't look to be
relevant anymore.
2018-09-16 11:09:51 +02:00
Gabriel Caruso
8ca1f47a7a
Use variables that already received ZEND_NUM_ARGS()
2018-07-22 15:54:00 -03:00
Dmitry Stogov
265c3ed6cf
Fixed incorrrecr zval_dtor() usage to replace value of argument passed by reference, that may lead to memory leaks.
2018-07-05 10:57:49 +03:00