Commit graph

1236 commits

Author SHA1 Message Date
NathanFreeman
b3903515bf
Fix bug where large bigints may be truncated
Unless stringified results are requested, we need to parse large
bigints as unsigned, to avoid wrap-around behavior.

Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>

Closes GH-7837.
2021-12-30 19:07:36 +01:00
Kamil Tekiela
a0be3f8b27
Merge branch 'PHP-8.1'
* PHP-8.1:
  Fix bug GH-7746 (mysqli_sql_exception->sqlstate is inaccessible)
2021-12-30 14:23:44 +00:00
Kamil Tekiela
8869bbe0e9
Fix bug GH-7746 (mysqli_sql_exception->sqlstate is inaccessible)
Closes GH-7747
2021-12-30 14:23:06 +00:00
Christoph M. Becker
dea548be60
Merge branch 'PHP-8.1'
* PHP-8.1:
  Fix #81658: MYSQL_OPT_LOAD_DATA_LOCAL_DIR not available in MariaDB
2021-12-05 19:11:32 +01:00
David Carlier
15e7e570a5
Fix #81658: MYSQL_OPT_LOAD_DATA_LOCAL_DIR not available in MariaDB
This also introduces the boolean userland constant `MYSQLI_IS_MARIADB`.
2021-12-05 19:11:04 +01:00
Nikita Popov
902d64390e Deprecate implicit dynamic properties
Writing to a proprety that hasn't been declared is deprecated,
unless the class uses the #[AllowDynamicProperties] attribute or
defines __get()/__set().

RFC: https://wiki.php.net/rfc/deprecate_dynamic_properties
2021-11-26 14:10:11 +01:00
Kamil Tekiela
c149d37611
Merge branch 'PHP-8.1'
* PHP-8.1:
  mysqli_reap_async_query error reporting (#7629)
2021-11-09 18:17:37 +00:00
Kamil Tekiela
15a2c8660b
mysqli_reap_async_query error reporting (#7629) 2021-11-09 18:16:36 +00:00
Kamil Tekiela
304f758bf8 Remove redundant checks
I am unsure what this condition was actually supposed to do, but it
seems like it was only checking for 1 (loose check)
2021-11-09 14:00:30 +00:00
Kamil Tekiela
c5cc4c813c Fix grammar in code comments 2021-11-09 14:00:30 +00:00
Kamil Tekiela
0ac7dacc23 Fix PHP DocBlock 2021-11-09 14:00:30 +00:00
Kamil Tekiela
97bef32976 Invalid condition in connect.inc 2021-11-09 14:00:30 +00:00
Kamil Tekiela
1b3a73bbd7 Refactor have_innodb function 2021-11-09 14:00:30 +00:00
Kamil Tekiela
9b433c2398
Fix SKIP in mysqli tests 2021-11-06 20:46:04 +00:00
Kamil Tekiela
c9d509b668
Revert "Fix bug GH-1 (mysqli_sql_exception->sqlstate is inaccessible)"
This reverts commit 64fca5c5f0.
2021-10-21 19:01:01 +01:00
Kamil Tekiela
64fca5c5f0
Fix bug GH-1 (mysqli_sql_exception->sqlstate is inaccessible) 2021-10-21 18:51:16 +01:00
Nikita Popov
a01d7390b8 Merge branch 'PHP-8.1'
* PHP-8.1:
  Fixed bug #81494
2021-10-08 15:02:41 +02:00
Nikita Popov
d001682ac4 Merge branch 'PHP-8.0' into PHP-8.1
* PHP-8.0:
  Fixed bug #81494
2021-10-08 15:02:29 +02:00
Nikita Popov
df940a6dc3 Merge branch 'PHP-7.4' into PHP-8.0
* PHP-7.4:
  Fixed bug #81494
2021-10-08 15:00:51 +02:00
Nikita Popov
fcabe693ba Fixed bug #81494
Use the proper error reporting mechanism rather than throwing a
warning. This requires something of a hack because we don't have
direct access to the connection object at this point.
2021-10-08 15:00:10 +02:00
Kamil Tekiela
c3dda473cc
Fix 'can not' in test data and in code comments 2021-10-05 09:51:58 +01:00
Nikita Popov
218fd03532 Fix some more CLEANUP sections 2021-09-03 14:10:40 +02:00
Kamil Tekiela
400c6055b1 Remove mysqli_close that prevented CLEAN from running properly 2021-09-03 10:43:10 +02:00
Kamil Tekiela
abacd91cc8
Merge branch 'PHP-8.0'
* PHP-8.0:
  Prevent mysqli::next_result from reporting errors from previous calls (#7304)
2021-07-27 11:57:39 +01:00
Kamil Tekiela
65e2dbd0de
Merge branch 'PHP-7.4' into PHP-8.0
* PHP-7.4:
  Prevent mysqli::next_result from reporting errors from previous calls (#7304)
2021-07-27 11:56:14 +01:00
Kamil Tekiela
d26069a2f1
Prevent mysqli::next_result from reporting errors from previous calls (#7304) 2021-07-27 11:50:28 +01:00
Nikita Popov
625b89af2f Deprecate mysqli::init()
In favor of parent::__construct().

Part of https://wiki.php.net/rfc/deprecations_php_8_1.
2021-07-08 16:45:05 +02:00
Patrick Allaert
ac18dd0dc7 Prefer EXPECT over EXPECTF 2021-06-29 17:13:02 +02:00
Kamil Tekiela
db64aa3cfd
optimize skip condition for the test 2021-06-25 13:35:48 +01:00
Kamil Tekiela
f699c96ec3
Fix broken test due to missing skipif.inc 2021-06-25 13:26:40 +01:00
Kamil Tekiela
970d659dae
Fix libmysql test cases (#7097)
Fixed test cases for: mysqli_stmt_execute_bind_libmysql, bug77935, fetch_column, and some others that failed on libmysql
2021-06-25 12:29:20 +01:00
Nikita Popov
b5a14e6c04 Port skipif.inc files to EXTENSIONS 2021-06-11 16:27:50 +02:00
Nikita Popov
7485978339
Migrate SKIPIF -> EXTENSIONS (#7138)
This is an automated migration of most SKIPIF extension_loaded checks.
2021-06-11 11:57:42 +02:00
Kamil Tekiela
b601acf35e
Fix typo, there is no MySQL 8.2.10 2021-06-03 19:02:53 +01:00
Christoph M. Becker
8a8e307cd5
Mark slow tests
Each of these tests took more than ten seconds on a recent AppVeyor CI
run; that appears to qualify them to be marked as slow tests.

Closes GH-7077.
2021-06-03 15:14:08 +02:00
George Peter Banyard
b6958bb847
Implement "Deprecate implicit non-integer-compatible float to int conversions" RFC. (#6661)
RFC: https://wiki.php.net/rfc/implicit-float-int-deprecate

Co-authored-by: Nikita Popov <nikita.ppv@gmail.com>
2021-05-31 15:48:45 +01:00
Máté Kocsis
01775fa104
Declare tentative return types for ext/mysqli (#6998) 2021-05-26 17:29:58 +02:00
Kamil Tekiela
428340dfeb
Add error reporting to mysqli_options (#7036) 2021-05-25 10:42:06 +01:00
Kamil Tekiela
54222a6fe4
Implement mysqli_fetch_column (#6798)
* Implement mysqli_fetch_column
2021-05-01 20:11:47 +01:00
Kamil Tekiela
45bad6474e
Mysqli bind in execute (#6271) 2021-04-14 12:52:51 +01:00
Nikita Popov
0e7b4d09ec Add tests for mysqli property writing
Forgot to git add these in the previous commit.
2021-04-13 15:32:49 +02:00
Kamil Tekiela
b7a298b20c
Deprecate unused mysqli constants (#6850)
Deprecated:
MYSQLI_SERVER_QUERY_NO_GOOD_INDEX_USED
MYSQLI_SERVER_QUERY_NO_INDEX_USED
MYSQLI_SERVER_QUERY_WAS_SLOW
MYSQLI_SERVER_PS_OUT_PARAMS
MYSQLI_DATA_TRUNCATED
MYSQLI_NO_DATA
2021-04-13 00:11:54 +01:00
Kamil Tekiela
830d385351
Fix typos in fetch_all error message 2021-03-28 20:36:17 +01:00
Dharman
7e9f6d2a48 Deprecate OO style mysqli::get_client_info method
Deprecate passing connection object to mysqli_get_client_info()

Closes GH-6777.
2021-03-17 20:10:18 +00:00
Dharman
5e1056edb6 Change the default error mode of mysqli
Make MYSQLI_REPORT_ERROR | MYSQLI_REPORT_STRICT the new mysqli
error reporting default. Explicitly call
mysqli_report(MYSQLI_REPORT_OFF) to preserve previous behavior.

RFC: https://wiki.php.net/rfc/mysqli_default_errmode

Closes GH-6629.
2021-03-15 14:55:31 +01:00
Nikita Popov
5604c2d05c Merge branch 'PHP-8.0'
* PHP-8.0:
  Fix bug #80837
2021-03-15 14:38:56 +01:00
Nikita Popov
6493b516f9 Merge branch 'PHP-7.4' into PHP-8.0
* PHP-7.4:
  Fix bug #80837
2021-03-15 14:38:49 +01:00
Dharman
c93b461ad7 Fix bug #80837
The error needs to be reported on the statement, not the connection.
2021-03-15 14:38:09 +01:00
Máté Kocsis
4833309bd2
Use typed properties in ext/mysqli
Closes GH-6739
2021-03-15 13:11:57 +01:00
Dharman
8573eb9e5c Add CLEAN sections to mysqli and PDO mysql tests
Closes GH-6756.
2021-03-15 11:01:12 +01:00