archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-20 09:24:05 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2
121238 commits 526 branches 1434 tags 881 MiB
Commit graph

756 commits

Author SHA1 Message Date
Christoph M. Becker
818eb8f611 Merge branch 'PHP-7.4' into PHP-8.0 
* PHP-7.4:
  Fix #80226: imap_sort() leaks sortpgm memory
 2020-10-12 23:21:56 +02:00
Christoph M. Becker
12fc8f66e7 Merge branch 'PHP-7.3' into PHP-7.4 
* PHP-7.3:
  Fix #80226: imap_sort() leaks sortpgm memory
 2020-10-12 23:17:57 +02:00
Christoph M. Becker
8488c34fc6 Fix #80226: imap_sort() leaks sortpgm memory 
We need to free what we have allocated.

Closes GH-6327.
 2020-10-12 23:16:31 +02:00
Christoph M. Becker
8d4774a2df Change parameters types from int to bool 
These are typical boolean parameters, so we shouldn't advertize them as
integers.  For the `$reverse` parameter that even fixes expectations,
because the `reverse` member is a bitfield of 1 bit, so assigning any
even integer would not set it.

Closes GH-6328.
 2020-10-12 23:10:13 +02:00
Christoph M. Becker
11c752a5f5 Merge branch 'PHP-7.4' into PHP-8.0 
* PHP-7.4:
  Fix #80216: imap_mail_compose() does not validate types/encodings
 2020-10-12 16:30:48 +02:00
Christoph M. Becker
216d6a024a Merge branch 'PHP-7.3' into PHP-7.4 
* PHP-7.3:
  Fix #80216: imap_mail_compose() does not validate types/encodings
 2020-10-12 16:28:52 +02:00
Christoph M. Becker
73e43b6e19 Fix #80216: imap_mail_compose() does not validate types/encodings 
We need to check whether the given `type`s and `encoding`s are within
bounds to avoid segfaults and out-of-bound reads.

Closes GH-6323.
 2020-10-12 16:27:49 +02:00
Christoph M. Becker
0443c824a3 Merge branch 'PHP-7.4' into PHP-8.0 
* PHP-7.4:
  Fix #80223: imap_mail_compose() leaks envelope on malformed bodies
 2020-10-12 15:10:38 +02:00
Christoph M. Becker
4a469c7e98 Merge branch 'PHP-7.3' into PHP-7.4 
* PHP-7.3:
  Fix #80223: imap_mail_compose() leaks envelope on malformed bodies
 2020-10-12 15:09:30 +02:00
Christoph M. Becker
c1962e900a Fix #80223: imap_mail_compose() leaks envelope on malformed bodies 
We have to clean up even on failure.

Closes GH-6322.
 2020-10-12 15:08:30 +02:00
Christoph M. Becker
5a8958f0f3 Merge branch 'PHP-7.4' into PHP-8.0 
* PHP-7.4:
  Fix #80220: imap_mail_compose() may leak memory
 2020-10-12 13:34:19 +02:00
Christoph M. Becker
acce991a37 Merge branch 'PHP-7.3' into PHP-7.4 
* PHP-7.3:
  Fix #80220: imap_mail_compose() may leak memory
 2020-10-12 13:32:40 +02:00
Christoph M. Becker
0d022ddf03 Fix #80220: imap_mail_compose() may leak memory 
Unless `topbod` is of `TYPEMULTIPART`, `mail_free_body()` does not free
the `nested.part`; while we could do this ourselves, instead we just
ignore additional bodies in this case, i.e. we don't attach them in the
first place.

Closes GH-6321.
 2020-10-12 13:31:30 +02:00
Christoph M. Becker
6494e57804 Merge branch 'PHP-7.4' into PHP-8.0 
* PHP-7.4:
  Fix #80215: imap_mail_compose() may modify by-val parameters
 2020-10-10 23:28:19 +02:00
Christoph M. Becker
7940fb42ce Merge branch 'PHP-7.3' into PHP-7.4 
* PHP-7.3:
  Fix #80215: imap_mail_compose() may modify by-val parameters
 2020-10-10 23:26:12 +02:00
Christoph M. Becker
62a2387a8d Fix #80215: imap_mail_compose() may modify by-val parameters 
We separate the input arrays and all sub-arrays to avoid modification
of the passed parameters.

This should be rewritten to use `zend_string`s for the "master" branch.

Closes GH-6316.
 2020-10-10 23:25:06 +02:00
Christoph M. Becker
7d085c87ac Merge branch 'PHP-7.4' into PHP-8.0 
* PHP-7.4:
  Fix #80213: imap_mail_compose() segfaults on certain $bodies
 2020-10-10 19:19:47 +02:00
Christoph M. Becker
b2b9e2e87e Merge branch 'PHP-7.3' into PHP-7.4 
* PHP-7.3:
  Fix #80213: imap_mail_compose() segfaults on certain $bodies
 2020-10-10 19:18:14 +02:00
Christoph M. Becker
8bee0fbd37 Fix #80213: imap_mail_compose() segfaults on certain $bodies 
We have to cater to non-associative arrays where the key may be `NULL`;
we just skip these elements.

Closes GH-6315.
 2020-10-10 19:17:13 +02:00
Christoph M. Becker
45c19bde22 Change imap_mail_compose() $body param to $bodies 
This parameter actually expects an array of bodies, so we should name
it accordingly.

Closes GH-6313.
 2020-10-10 17:39:54 +02:00
Nikita Popov
e0f2ac9ff6 Update ext/imap parameter names 
Closes GH-6299.
 2020-10-08 18:02:09 +02:00
Christoph M. Becker
d3b41c4640 Fix imap test expectation which is still too strict for Windows 2020-10-08 12:33:38 +02:00
Christoph M. Becker
48736dddab Merge branch 'PHP-7.4' into master 
* PHP-7.4:
  Fix too strict imap test expectations
 2020-10-08 12:11:28 +02:00
Christoph M. Becker
2e7247c558 Merge branch 'PHP-7.3' into PHP-7.4 
* PHP-7.3:
  Fix too strict imap test expectations
 2020-10-08 12:08:35 +02:00
Christoph M. Becker
1895bf7b94 Fix too strict imap test expectations 2020-10-08 12:06:54 +02:00
Christoph M. Becker
f5afc2c3cf Fix potential mail related segfault on Windows 
`rpath` may be `NULL` here, in which case we must not access its
members.
 2020-10-08 11:47:18 +02:00
Nikita Popov
0a573f9e1c Skip one more imap test under asan 
Wondering if the error just moves to a different test each time
we skip one?
 2020-09-28 09:54:44 +02:00
Nikita Popov
ae86edefe7 Skip imap_lsub_basic.phpt under asan 
LeakSanitizer fails on Azure with:

> Tracer caught signal 11: addr=0x0 pc=0x7f86cde7c8b0 sp=0x7f86c46bcce0
 2020-09-24 17:03:53 +02:00
George Peter Banyard
25569679aa Promote warnings to Error in IMAP extension 
Drop some dependencies on argc at the same time

Closes GH-6164
 2020-09-23 13:54:54 +01:00
George Peter Banyard
5d7d5e2773 Add proper default values for optional arguments in IMAP 
Closes GH-6179
 2020-09-22 17:46:28 +01:00
George Peter Banyard
7fde9918af Refactor imap_mail()'s internal implementation to use zend_strings 2020-09-22 17:46:28 +01:00
George Peter Banyard
35013ac823 Skip IMAP test which chokes on ASAN build 2020-09-22 14:43:31 +01:00
George Peter Banyard
9746490ad4 Drop some connection retries in IMAP test 
They are unnecessary and just take time for no good reason
 2020-09-21 14:49:53 +01:00
Christoph M. Becker
4591cb8a07 Merge branch 'PHP-7.4' into master 
* PHP-7.4:
  Fix memory leak in php_imap_mutf7()
 2020-09-21 11:27:51 +02:00
Christoph M. Becker
d1feeed7f3 Merge branch 'PHP-7.3' into PHP-7.4 
* PHP-7.3:
  Fix memory leak in php_imap_mutf7()
 2020-09-21 11:26:41 +02:00
Christoph M. Becker
730fdc77a7 Fix memory leak in php_imap_mutf7() 
We have to free the string which has been allocated by libc-client.
 2020-09-21 11:25:46 +02:00
George Peter Banyard
3b67f183b1 Update README for how to setup IMAP tests 
This details which packages needs to be installed on Ubuntun 18.04,
which configure flags are necessary and what the setup.sh shell script does.
 2020-09-20 22:20:34 +01:00
George Peter Banyard
30bb15b24a Fix IMAP tests 
Drop various ZPP checks and make them PASS
Add CONFLICT file as the tests all hit the same mailbox
 2020-09-18 23:02:01 +02:00
George Peter Banyard
ef9359d30f Set-up IMAP in Azure 
Closes GH-6162
 2020-09-18 23:02:01 +02:00
Nikita Popov
c5401854fc Run tidy 
This should fix most of the remaining issues with tabs and spaces
being mixed in tests.
 2020-09-18 14:28:32 +02:00
Máté Kocsis
36fd95b524
Generate arginfos 2020-09-16 21:28:27 +02:00
Máté Kocsis
de912821e0
Display string default values in stubs more uniformly 
Settling on using quoted string
 2020-09-16 21:27:01 +02:00
Máté Kocsis
c76910cd96
Display types in stubs more uniformly 
In preparation for generating method signatures for the manual.

This change gets rid of bogus false|null return types, a few unnecessary trailing backslashes, and settles on using ? when possible for nullable types.
 2020-09-16 21:19:36 +02:00
Máté Kocsis
9975986b7e
Improve error messages mentioning parameters instead of arguments 
Closes GH-5999
 2020-09-09 10:47:43 +02:00
Máté Kocsis
7aacc705d0
Add many missing closing PHP tags to tests 
Closes GH-5958
 2020-08-09 22:03:36 +02:00
Máté Kocsis
79981a394e
Add a bunch of missing argument types to stubs 2020-08-03 00:45:51 +02:00
Max Semenik
2b5de6f839
Remove proto comments from C files 
Closes GH-5758
 2020-07-06 21:13:34 +02:00
Fabien Villepinte
0c6d06ecfa Replace EXPECTF when possible 
Closes GH-5779
 2020-06-29 21:31:44 +02:00
Máté Kocsis
b5c7a83dca
Remove unnecessary PHPDoc-alike blocks from tests 
Closes GH-5759
 2020-06-24 13:13:44 +02:00
Nikita Popov
c9b9f525a9 Include stub hash in generated arginfo files 
The hash is used to check whether the arginfo file needs to be
regenerated. PHP-Parser will only be downloaded if this is actually
necessary.

This ensures that release artifacts will never try to regenerate
stubs and thus fetch PHP-Parser, as long as you do not modify any
files.

Closes GH-5739.
 2020-06-24 09:55:19 +02:00