Commit graph

93 commits

Author SHA1 Message Date
Peter Kokot
d679f02295 Sync leading and final newlines in *.phpt sections
This patch adds missing newlines, trims multiple redundant final
newlines into a single one, and trims redundant leading newlines in all
*.phpt sections.

According to POSIX, a line is a sequence of zero or more non-' <newline>'
characters plus a terminating '<newline>' character. [1] Files should
normally have at least one final newline character.

C89 [2] and later standards [3] mention a final newline:
"A source file that is not empty shall end in a new-line character,
which shall not be immediately preceded by a backslash character."

Although it is not mandatory for all files to have a final newline
fixed, a more consistent and homogeneous approach brings less of commit
differences issues and a better development experience in certain text
editors and IDEs.

[1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206
[2] https://port70.net/~nsz/c/c89/c89-draft.html#2.1.1.2
[3] https://port70.net/~nsz/c/c99/n1256.html#5.1.1.2
2018-10-15 04:33:09 +02:00
Gabriel Caruso
9c144e0d82
Trim trailing whitespace in tests 2018-10-14 12:07:20 -03:00
Gabriel Caruso
f72b6c5e19
Use EXPECT instead of EXPECTF when possible 2018-09-16 15:39:18 -03:00
Anatol Belski
cf21a505a6 Merge branch 'PHP-7.3'
* PHP-7.3:
  Improve cleanup
2018-08-03 07:12:13 +02:00
Anatol Belski
4bb44e0f44 Merge branch 'PHP-7.2' into PHP-7.3
* PHP-7.2:
  Improve cleanup
2018-08-03 07:11:23 +02:00
Anatol Belski
0872e80dd8 Merge branch 'PHP-7.1' into PHP-7.2
* PHP-7.1:
  Improve cleanup
2018-08-03 07:10:27 +02:00
Anatol Belski
41c69766a4 Improve cleanup
The persistent connection locks the file which might prevent deletion.
2018-08-03 07:08:53 +02:00
BohwaZ
6f9ebe677b Add \PDO::SQLITE_ATTR_READONLY_STATEMENT
This attribute is a boolean value. It is taken from the return value of
sqlite3_stmt_readonly(), indicating if and only if the prepared statement makes
no direct changes to the content of the database.
2018-08-01 17:45:20 -04:00
Gabriel Caruso
c93aba042f
Give a reason why the test was skipped
This will help us debug why a test was skipped in GCOV
(http://gcov.php.net/viewer.php?version=PHP_HEAD&func=skip), and maybe
put them to run again
2018-07-22 16:41:41 -03:00
Gabriel Caruso
b895690dfa
remove support for string|unicode in tests 2018-02-22 08:11:30 +01:00
Gabriel Caruso
ded3d984c6 Use EXPECT instead of EXPECTF when possible
EXPECTF logic in run-tests.php is considerable, so let's avoid it.
2018-02-20 21:53:48 +01:00
Anatol Belski
fe78a7cb4f Fix test cleanup 2017-09-06 12:59:10 +02:00
BohwaZ
ed2f6510da
Add support for SQLite open flags 2017-09-06 09:56:02 +01:00
Markus Staab
175b2d8910 fixed typo 2017-03-29 09:10:41 +02:00
Markus Staab
b8842839db fixed typo 2017-03-29 09:09:53 +02:00
Remi Collet
83b0708878 Merge branch 'PHP-7.1'
* PHP-7.1:
  Fix buid with system libsqlite, see bug #74217
2017-03-29 07:28:26 +02:00
Remi Collet
012dc336a6 Fix buid with system libsqlite, see bug #74217
SQLITE_DETERMINISTIC only exists in recent version
e.g. missing on 3.7 which is the default on RHEL/CentOS-7
and probably others (wheezy have 3.7, jessie 3.8...)
2017-03-29 07:25:01 +02:00
Nikita Popov
e31342ef84 Merge branch 'PHP-7.1' 2017-03-12 17:04:02 +01:00
andrewnester
fbf0e0587f Implement FR #74217: deterministic sqlite functions 2017-03-12 17:03:00 +01:00
Nikita Popov
5af586bec5 Remove more PHP 6 leftovers from tests 2016-11-24 22:39:39 +01:00
Anatol Belski
5360b3de33 fix test if unlink fails occasionally 2016-05-01 19:25:39 +02:00
Sara Golemon
d0b952260e Create temporary sqlite db in test dir rather than cwd (and clean it up)
Well behaved tests do not leave their droppings all over the filesystem.
2016-04-30 06:02:01 +00:00
Anatol Belski
cff9e16a12 fix pdo_sqlite crash with empty bound stream 2015-11-05 21:50:34 +01:00
Anatol Belski
5ba763413b fix test redirection when run not from source root 2015-10-23 09:42:19 +02:00
Xinchen Hui
aaf7638706 Fixed bug #70221 (persistent sqlite connection + custom function segfaults) 2015-08-10 19:00:35 +08:00
Dmitry Stogov
6d4da2db8a Make internal non-static methods to be executed in context of class. Set EG(scope) accordingly. 2015-04-23 03:41:50 +03:00
Nikita Popov
6ef9216269 Finish PHP 4 constructor deprecation 2015-03-31 17:55:27 +02:00
Xinchen Hui
3a1f79d51d Fixed bug #47407 2014-05-27 11:48:25 +08:00
Xinchen Hui
e3d9e18e7b Fixed Bug #66034 (Segmentation Fault when constructor of PDO statement throws an exception)
I know zend_call_function will initilize retval_ptr_ptr, but still set
it to NULL explict is more readable
2013-11-05 11:04:55 +08:00
Yasuo Ohgaki
cb13f8318b Add user contributed test. Bug #61748 2013-08-02 09:52:08 +09:00
Lars Strojny
1e9a3ed234 Fix bug #63916: PDO::PARAM_INT casts to 32bit int internally even on 64bit builds in pdo_sqlite 2013-01-14 17:59:11 +01:00
Rasmus Lerdorf
9111a8a58a createCollation() for pdo_sqlite as well
Closes bug #55226
2012-01-29 04:22:23 +00:00
Dmitry Stogov
cacf363957 Fixed bug #60104 (Segmentation Fault in pdo_sqlite when using sqliteCreateFunction()) 2011-11-08 10:11:25 +00:00
Patrick Allaert
9da01ac6b6 Added test for #60104 2011-11-04 19:13:37 +00:00
Felipe Pena
fbb5aae32c - New tests (code coverage++) 2011-06-19 12:33:49 +00:00
Felipe Pena
938265115b - New test 2010-07-29 23:46:49 +00:00
Johannes Schlüter
ed03634a8c Revert 290786: Fixed bug #49521 (PDO fetchObject sets values before calling
constructor)
2010-02-11 22:14:06 +00:00
Ilia Alshanetsky
d2e14e3f20 Fixed bug #50728 (All PDOExceptions hardcode 'code' property to 0) 2010-01-12 12:46:54 +00:00
Felipe Pena
c00a91a024 - Added SKIPIF 2009-12-15 00:37:43 +00:00
Felipe Pena
286f36e702 - Fixed memory leak when E_STRICT message is getted 2009-12-14 21:44:56 +00:00
Felipe Pena
4bafbf58f8 - Fixed bug #49521 (PDO fetchObject sets values before calling constructor)
(patch by Pierrick)
2009-11-15 16:20:37 +00:00
Felipe Pena
cdf9cf3033 - Fixed bug #48773 (Incorrect error when setting PDO::ATTR_STATEMENT_CLASS with ctor_args)
[HEAD only]
2009-07-19 18:55:31 +00:00
Jani Taskinen
eb190a2ef9 MFH: Fix cleanup 2009-04-25 21:44:33 +00:00
Jani Taskinen
7be492a208 MFB: Added missing SKIPIF 2009-04-25 21:38:04 +00:00
Felipe Pena
a518082fb0 - Fix test 2009-02-20 13:39:14 +00:00
Johannes Schlüter
162aed0aed MFH: Fix #46542 Extending PDO class with a __call() function doesn't work
as expected
2009-02-17 14:42:26 +00:00
Felipe Pena
7c34d6f76b - New test 2009-02-13 02:20:52 +00:00
Scott MacVicar
efaba65cf5 MFH Add table key to getColumnMeta() with SQLite 2009-01-13 02:50:54 +00:00
Johannes Schlüter
76b988475a MFH: Fix tests (use a in-memory database not a file called memory) 2008-12-03 11:00:31 +00:00
Felipe Pena
00cb5de0ab MFH:
- Fixed memory leaks
- Added new tests (Coverage++)
2008-12-02 21:01:37 +00:00