archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-18 15:08:55 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1
121832 commits 526 branches 1434 tags 877 MiB
Commit graph

758 commits

Author SHA1 Message Date
Nikita Popov
625d8463a4 Consistent error handling for fgetcsv/fputcsv 
Normalize the behavior between the file functions and those on
SplFileObject.

Be consistent about throwing regardless of whether the delimiter etc
is empty or has too many characters. I don't think it's worthwhile
to distinguish these cases.

Back when we looked into this originally, there was some hope that
we might want to add support for multiple-character delimiter etc,
but after a cursory look, I really don't think this is going to
happen (for fputcsv maybe, but for fgetcsv this just makes an already
broken function much more complicated.)

Closes GH-6188.
 2020-09-23 10:11:04 +02:00
Ikko Ashimine
8f3a38d927 Fixed minor typo in comment 
Initiailize -> Initialize

Closes GH-6181.
 2020-09-22 09:10:23 +02:00
Máté Kocsis
e950ca13ea
Consolidate the usage of "either" and "one of" in error messages 
Closes GH-6173
 2020-09-20 19:41:47 +02:00
Máté Kocsis
c37a1cd650
Promote a few remaining errors in ext/standard 
Closes GH-6110
 2020-09-15 14:26:16 +02:00
Máté Kocsis
2c96780e1c
Fix UNKNOWN default values in ext/standard 
Closes GH-6026
 2020-09-07 18:58:11 +02:00
George Peter Banyard
7805b97720 Extract common flock code 
As SPL is currently a copie of the code in file.c

Closes GH-6069
 2020-09-04 14:29:31 +02:00
George Peter Banyard
430b3ac7df Refactor parts of SPL Dir/SplFileObject 
This fixes a way it was possible to trigger an Internel Error
by disabling function (via the INI setting) when SPL was acting
as a proxy to the function call.

Fix flock_compat layer as it needs to used in SPL now.

Use macro to check if object is initialized

Closes GH-6014
 2020-09-03 14:23:18 +02:00
Máté Kocsis
af80d8a14e
Add more argument types to stubs 
Closes GH-5943
 2020-08-07 12:35:30 +02:00
Nikita Popov
3bb1830369 Reapply "Explicitly validate popen mode" 
To avoid behavior differences due to libc. This time with the
check only for the non-win32 case, as Windows support additional
modifiers here (t/b).
 2020-08-07 10:33:27 +02:00
Nikita Popov
7c8467562d Revert "Explicitly validate popen mode" 
This reverts commit ab36540bdd.

Causes a test failure on Windows.
 2020-08-06 21:53:13 +02:00
Nikita Popov
ab36540bdd Explicitly validate popen mode 
To avoid behavior differences due to libc.
 2020-08-06 10:26:46 +02:00
Max Semenik
2b5de6f839
Remove proto comments from C files 
Closes GH-5758
 2020-07-06 21:13:34 +02:00
Christoph M. Becker
8c11d8fedb Merge branch 'PHP-7.4' 
* PHP-7.4:
  Fix #70362: Can't copy() large 'data://' with open_basedir
 2020-06-30 10:48:58 +02:00
Christoph M. Becker
993b19ae69 Merge branch 'PHP-7.3' into PHP-7.4 
* PHP-7.3:
  Fix #70362: Can't copy() large 'data://' with open_basedir
 2020-06-30 10:48:07 +02:00
Christoph M. Becker
7f3bc64287 Fix #70362: Can't copy() large 'data://' with open_basedir 
open_basedir is only relevant for plain files, so there is no need to
check it for other URL wrappers.
 2020-06-30 10:46:53 +02:00
twosee
7d6a0ba808 Fix expression warnings and break warnings 
Close GH-5675.
 2020-06-07 10:41:11 +02:00
Christoph M. Becker
864fb0ec23 Implement #47074: phpinfo() reports "On" as 1 for the some extensions 
What is modified as boolean, should also be displayed as boolean.
 2020-06-04 11:25:45 +02:00
Christoph M. Becker
5a628402a0 Don't raise bogus warning if writing completely failed 2020-05-02 16:32:29 +02:00
Máté Kocsis
6111d64cda
Improve a last couple of argument error messages 
Closes GH-5404
 2020-04-20 13:09:00 +02:00
Nikita Popov
2d1bf6970d Add Z_PARAM_RESOURCE_OR_NULL() 
As a more explicit alternative to Z_PARAM_RESOURCE_EX(, 1, 0).
 2020-04-09 15:39:11 +02:00
Máté Kocsis
50765075db
Improve some ValueError messages 
Closes GH-5340
 2020-04-06 10:41:01 +02:00
George Peter Banyard
457380cae7 Drop wchar header check as always defined since C95 2020-03-31 00:14:56 +02:00
Nikita Popov
97cb81ead5 Remove HAVE_REALPATH checks 
We do not actually use realpath(), but a custom implementation.
Make sure the realpath() function is always available.

Closes GH-5290.
 2020-03-26 11:46:00 +01:00
Máté Kocsis
bb6f374048
Improve argument error messages in ext/standard 
Closes GH-5198
 2020-03-18 19:56:10 +01:00
Nikita Popov
bb6e2a1615 Avoid used of "named fn" in ext/standard 2020-02-25 10:21:31 +01:00
George Peter Banyard
9a76a2a032 Convert some warnings into ValueErrors in the standard file extension 
Closes GH-5007
 2020-01-27 23:20:40 +01:00
George Peter Banyard
b79efec994 Remove unused delimiter parameter in php_fgetcsv_lookup_trailing_spaces subroutine. 2020-01-10 03:38:16 +01:00
Máté Kocsis
bbcfa66e06
Use RETURN_THROWS() after zend_fetch_resource*() 2020-01-03 19:20:56 +01:00
Máté Kocsis
31cf9a7ea9
Use RETURN_THROWS() when an exception is thrown 
Closes GH-5036
 2019-12-30 17:38:10 +01:00
Máté Kocsis
e34a1f9289
Convert zend_parse_parameters_none() to fast ZPP in standard lib 
Closes GH-5037
 2019-12-30 15:28:37 +01:00
Máté Kocsis
5898e8ef3c
Promote warning to exception in file_get_contents() function 2019-12-05 08:32:29 +01:00
Nikita Popov
647b1c7fcf Remove most uses of ZEND_PARSE_PARAMETERS_END_EX() 
As ZPP now throws, it makes no sense to specify an explicit return
value.
 2019-10-07 10:02:18 +02:00
Gabriel Caruso
5d6e923d46
Remove mention of PHP major version in Copyright headers 
Closes GH-4732.
 2019-09-25 14:51:43 +02:00
Christoph M. Becker
a858a53c07 Merge branch 'PHP-7.4' 
* PHP-7.4:
  Fix #78535: auto_detect_line_endings value not parsed as bool
 2019-09-14 18:49:00 +02:00
Christoph M. Becker
d0247a63b6 Merge branch 'PHP-7.3' into PHP-7.4 
* PHP-7.3:
  Fix #78535: auto_detect_line_endings value not parsed as bool
 2019-09-14 18:48:28 +02:00
Christoph M. Becker
00ad365125 Merge branch 'PHP-7.2' into PHP-7.3 
* PHP-7.2:
  Fix #78535: auto_detect_line_endings value not parsed as bool
 2019-09-14 18:47:12 +02:00
bugreportuser
fdcca93056 Fix #78535: auto_detect_line_endings value not parsed as bool 2019-09-14 18:46:09 +02:00
Nikita Popov
a1e2c8870e Merge branch 'PHP-7.4' 2019-07-22 17:26:01 +02:00
Nikita Popov
d59aac58b3 Report errors from stream read and write operations 
The php_stream_read() and php_stream_write() functions now return
an ssize_t value, with negative results indicating failure. Functions
like fread() and fwrite() will return false in that case.

As a special case, EWOULDBLOCK and EAGAIN on non-blocking streams
should not be regarded as error conditions, and be reported as
successful zero-length reads/writes instead. The handling of EINTR
remains unclear and is internally inconsistent (e.g. some code-paths
will automatically retry on EINTR, while some won't).

I'm landing this now to make sure the stream wrapper ops API changes
make it into 7.4 -- however, if the user-facing changes turn out to
be problematic we have the option of clamping negative returns to
zero in php_stream_read() and php_stream_write() to restore the
old behavior in a relatively non-intrusive manner.
 2019-07-22 17:17:28 +02:00
Nikita Popov
eea206a06c Merge branch 'PHP-7.4' 2019-06-12 13:18:04 +02:00
Nikita Popov
5be772a19c Fix incorrect printf modifiers 2019-06-12 13:17:25 +02:00
Nikita Popov
001d434449 Finish func_info updates for ext/standard 2019-06-03 11:26:25 +02:00
Nikita Popov
a1a8d14485 Update more func info information for ext/standard 2019-05-29 15:30:06 +02:00
Jakub Zelenka
5b7acc64eb Merge branch 'PHP-7.4' 2019-04-28 18:51:36 +01:00
codarrenvelvindron
5c05f5e6d3 Added tls 1.3 support for PHP 2019-04-28 17:37:43 +01:00
Dmitry Stogov
e188e4170f Use ZEND_TRY_ASSIGN_REF_... macros for arguments passed to internal function by reference 2019-04-24 18:28:29 +03:00
Dmitry Stogov
2e4686b566 Use ZEND_TRY_ASSIGN_REF_... macros for arguments passed to internal function by reference 2019-04-24 18:16:47 +03:00
Dmitry Stogov
34db07567d Use ZEND_TRA_ASSIGN_REF_... macros for by reference arguments of internal functions. 2019-04-24 16:14:48 +03:00
Dmitry Stogov
91ef4124e5 Refactor zend_object_handlers API to pass zend_object* and zend_string* insted of zval(s). 2019-02-04 13:20:25 +03:00
Peter Kokot
623911f993 Merge branch 'PHP-7.4' 
* PHP-7.4:
  Remove local variables
 2019-02-03 21:23:18 +01:00