Tim Düsterhus
45d1acf916
Zend: Fix reference counting for Closures in const-expr ( #17853 )
...
* Clean up closure static variable handling
* Zend: Fix reference counting for Closures in const-expr
Fixes php/php-src#17851
---------
Co-authored-by: Ilija Tovilo <ilija.tovilo@me.com>
2025-03-27 10:11:44 +01:00
Tim Düsterhus
8779e2a603
Add (void) cast
...
RFC: https://wiki.php.net/rfc/marking_return_value_as_important
2025-03-24 19:35:30 +01:00
Tim Düsterhus
2042fd34e0
Support first-class callables in const-expressions ( #17213 )
...
RFC: https://wiki.php.net/rfc/fcc_in_const_expr
Co-authored-by: Volker Dusch <volker@tideways-gmbh.com>
2025-02-20 18:52:47 +01:00
Gina Peter Banyard
65d433161a
Use new known "self" and "parent" zend_strings ( #17766 )
2025-02-12 15:30:55 +00:00
Tim Düsterhus
d8d1cb4195
zend_ast: Print placeholder value when printing ZEND_AST_OP_ARRAY ( #17405 )
...
As per the discussion in GH-17120, we are printing a placeholder value only.
The commit history of that PR also includes alternative implementations, should
a different decision be desirable.
Fixes GH-17096
Closes GH-17120
2025-01-10 08:37:17 +01:00
Tim Düsterhus
e421a44ac6
zend_ast: Remove unused ZEND_AST_EXIT ( #17417 )
...
This AST node is no longer used since `exit()` was made a real function in
GH-13483.
2025-01-09 12:23:33 +01:00
Tim Düsterhus
cee64ed3bd
Add dedicated zend_ast_op_array struct ( #17391 )
...
Given that the `ZEND_AST_OP_ARRAY` type already needed special handling in
various places, it makes sense to give it its own struct to avoid some of the
casts. As a side benefit, it is a little smaller than the `zend_ast_zval`
struct.
2025-01-08 11:26:35 +01:00
Tim Düsterhus
fd1eacc2ed
Add assertions verifying that zend_ast_decl AST nodes are not treated as regular zend_ast nodes ( #17390 )
...
* zend_compile: Do not traverse children of ZEND_AST_CLOSURE in zend_compile_const_expr()
* Add assertions verifying that zend_ast_decl AST nodes are not treated as regular zend_ast nodes
2025-01-08 10:36:02 +01:00
Niels Dossche
97f44b7c39
Merge branch 'PHP-8.4'
...
* PHP-8.4:
Export visibility for promoted property (8.3)
[ci skip] News for GH-17101
Add test for GH-17101
Print hooks in parameter exports
Fix property hook name mismatch
Extract hook export code
Export visibility for promoted property
2024-12-17 19:14:55 +01:00
Niels Dossche
3f0f7ab7df
Print hooks in parameter exports
2024-12-17 19:06:10 +01:00
Niels Dossche
0cba85b54d
Fix property hook name mismatch
2024-12-17 19:06:10 +01:00
Niels Dossche
6920aa2ae6
Extract hook export code
2024-12-17 19:06:10 +01:00
Niels Dossche
6f41bfd1c7
Export visibility for promoted property
2024-12-17 19:06:09 +01:00
Tim Düsterhus
f6a0bb4d04
Support Closures in constant expressions ( #16458 )
...
RFC: https://wiki.php.net/rfc/closures_in_const_expr
Co-authored-by: Volker Dusch <volker@tideways-gmbh.com>
Co-authored-by: Ilija Tovilo <ilija.tovilo@me.com>
Co-authored-by: Arthur Kurbidaev <artkurbidaev@gmail.com>
2024-12-02 18:25:43 +01:00
Ilija Tovilo
8df557ac42
[RFC] Asymmetric visibility v2 (GH-15063)
...
Co-authored-by: Larry Garfield <larry@garfieldtech.com>
2024-08-27 02:04:48 +02:00
Christoph M. Becker
65c6d72319
Drop FASTCALL on variadic functions (GH-15389)
...
This is unlikely to be properly supported by compilers anyway, see
<https://github.com/php/php-src/pull/2975 >.
2024-08-13 19:46:48 +02:00
Ilija Tovilo
780a8280d2
[RFC] Property hooks ( #13455 )
...
RFC: https://wiki.php.net/rfc/property-hooks
Co-authored-by: Nikita Popov <nikita.ppv@gmail.com>
2024-07-14 11:55:03 +02:00
Cristian Rodríguez
8e62e2b829
Mark multple functions as static ( #13864 )
...
* Mark many functions as static
Multiple functions are missing the static qualifier.
* remove unused struct sigactions
struct sigaction act, old_term, old_quit, old_int;
all unused.
* optimizer: minXOR and maxXOR are unused
2024-05-22 13:11:46 +02:00
George Peter Banyard
d5ad75108e
More usage of known zend_str instead of C string ( #11381 )
2023-06-08 13:03:29 +01:00
Nikita Popov
c230aa9be3
Correctly handle multiple constants in typed declaration
...
While here also fix AST printing support.
2023-05-21 14:17:01 +01:00
Ilija Tovilo
5107483cd6
Correctly copy lineno for zval asts ( #11203 )
...
The comment was incorrect. Zval ASTs store their lineno in u2, but u2 does not
get copied in ZVAL_COPY. This triggers use-of-uninitialized errors with MSAN.
Unfortunately, I don't have a simple reproducer.
2023-05-07 13:17:19 +02:00
Ilija Tovilo
ba33bbe260
Merge branch 'PHP-8.2'
...
* PHP-8.2:
Unary minus const expression consistency
2023-03-31 14:28:39 +02:00
Ilija Tovilo
ed80a7e8c9
Merge branch 'PHP-8.1' into PHP-8.2
...
* PHP-8.1:
Unary minus const expression consistency
2023-03-31 14:28:25 +02:00
Ilija Tovilo
41bbb116dd
Unary minus const expression consistency
...
- of 0.0 should result in -0.0
Closes GH-10978
2023-03-31 14:27:54 +02:00
Ilija Tovilo
35a36b13e5
Fix comp-time and constant evaluation of dynamic class constant fetch
...
Fixes GH-10486
Fixes oss-fuzz #55436
Fixes oss-fuzz #55472
Closes GH-10487
2023-02-02 19:18:17 +01:00
Ilija Tovilo
9e097822e8
Fix lineno for all constant expressions
...
Fixes GH-8821
Closes GH-8855
2023-02-02 19:03:47 +01:00
Christoph M. Becker
bf1cfc0753
Revert GH-10300
...
Cf. <https://github.com/php/php-src/pull/10220#issuecomment-1383739816 >.
This reverts commit 68ada76f9a45384c6e20ef7fbfd7109b9ea0d7c6f15747c26be883ba93c47e87551c37921274d2b8fc1f528e5e0961715cdaa93f26452672dd94e1c629b2dc896405c7653bba5190e5c2606b55bf228c184b4a12d34c31b7888ad44e9680f04069a5c43f
2023-01-16 12:22:54 +01:00
Max Kellermann
5190e5c260
Zend/zend_ast: include cleanup
2023-01-15 15:07:58 +00:00
Niels
23fe58c3a8
Remove _zend_ast_decl->lex_pos ( #10046 )
...
This struct member was only written to, but never read.
2022-12-22 15:01:21 +01:00
Christoph M. Becker
9f0e4a55e7
Merge branch 'PHP-8.2'
...
* PHP-8.2:
Fix GH-9769: Misleading error message for unpacking of objects
2022-12-02 13:12:14 +01:00
Christoph M. Becker
6b1f4c5a44
Merge branch 'PHP-8.1' into PHP-8.2
...
* PHP-8.1:
Fix GH-9769: Misleading error message for unpacking of objects
2022-12-02 13:11:51 +01:00
蝦米
93592ea743
Fix GH-9769: Misleading error message for unpacking of objects
...
Only arrays can be unpacked in constant expressions.
Closes GH-9776.
2022-12-02 13:10:59 +01:00
Ilija Tovilo
683d81e4bd
Fix incorrect short-circuiting in constant expressions ( #10030 )
...
Fixes GH-10014
2022-12-01 19:30:44 +01:00
Ilija Tovilo
8731fb2d09
Fix caching of default params with side-effects
...
Fixes GH-9965
Closes GH-9935
2022-11-17 11:52:12 +01:00
Ilija Tovilo
1d6b32f65c
Remove unnecessary ast eval bailout
...
We can just reset the filename_override to NULL in php_request_shutdown.
Closes GH-9805
2022-10-27 10:54:59 +02:00
Ilija Tovilo
d36874d002
Merge branch 'PHP-8.1' into PHP-8.2
...
* PHP-8.1:
Fix class name FQN when AST dumping new and class const
2022-09-02 08:58:27 +02:00
Ilija Tovilo
2cfb028e22
Fix class name FQN when AST dumping new and class const
...
Fixes GH-9447
Closes GH-9462
2022-09-02 08:57:26 +02:00
Ilija Tovilo
f957e3e7f1
Fix arrow function with never return type
...
Fixes GH-7900
Closes GH-9103
2022-07-29 12:25:09 +02:00
Ilija Tovilo
7aadbcb8f4
GH-8344 Fetch properties of enums in const expressions
2022-07-18 23:52:28 +02:00
Ilija Tovilo
ddc0b490f7
Allow arbitrary const expressions in backed enums
...
Closes GH-7821
Closes GH-8190
Closes GH-8418
2022-06-12 22:56:05 +02:00
Máté Kocsis
7850c10389
Add support for readonly classes ( #7305 )
...
RFC: https://wiki.php.net/rfc/readonly_classes
2022-05-16 20:40:23 +02:00
Ilija Tovilo
3b4eaf67ec
Merge branch 'PHP-8.1'
...
* PHP-8.1:
Fix preloading of constants containing enums
2022-04-21 11:59:15 +02:00
Ilija Tovilo
4397811db2
Fix preloading of constants containing enums
...
Fixes GH-8133
2022-04-21 11:57:12 +02:00
Dmitry Stogov
efb014dda2
Reset EG(filename_override) after fatal error
...
Fixes oss-fuzz #45492
2022-03-14 11:07:49 +03:00
Ilija Tovilo
e3ef7bbbb8
Adjust filename/lineno for constant expressions
...
Closes GH-7771
Closes GH-8124
2022-03-09 18:41:04 +01:00
Tyson Andre
944b6b6bbd
Merge concatenated literal strings while compiling. ( #7948 )
...
The output of token_get_all is unaffected, so projects such as the userland
nikic/php-parser are unaffected.
Extensions such as nikic/php-ast which expose the internal php ast would see
literals be flattened, though.
This makes php significantly faster at parsing code such as
`$x = eval('return ' . var_export(str_repeat("\0", 100), true) . ';');`
and avoids the stack overflow from recursing 100000 times in
zend_eval_const_expr to process `'' . "\0" . '' . "\0" . ...`
Closes GH-7946
* Don't create binary op if unnecessary
* Update Zend/zend_ast.c
Co-authored-by: Nikita Popov <nikita.ppv@googlemail.com>
2022-01-16 13:31:58 -05:00
Cameron Porter
812df2bd8a
Fix bug #81611
...
Add zend_fetch_class_with_scope() which accepts a scope to use for
self/parent, and use that during constant expression evaluation.
Closes GH-7649.
2021-11-16 14:40:06 +01:00
Nikita Popov
f34114b1fb
Export AST for default value strings in reflection
...
When dumping default values in ReflectionXXX::__toString(), for
expression initializers print the AST export instead of trying to
evaluate the expression. With the introduction of "new in
initializers" the result of the evaluation will commonly not be
printable at all, and "__toString" will throw an exception, which
is not particularly useful. Using the AST export also provides more
information on how the parameter was originally declared, e.g. it
preserves the fact that a certain constant was used.
Closes GH-7540.
2021-10-01 16:13:35 +02:00
Nikita Popov
7d6a7e78fc
Use array_set_zval_key() in zend_ast_add_array_element()
...
This reimplemented basically the same logic.
2021-08-31 10:52:21 +02:00
Nikita Popov
b964d007e3
Fix AST print of first class callable in anon class expr
...
This will cause a compile error later, but the expression is
printed first.
Fixes oss-fuzz #37473 .
2021-08-26 12:00:37 +02:00
