Commit graph

2346 commits

Author SHA1 Message Date
Niels Dossche
984bcb5d69
ext/mysqli: Get rid of calls to strcpy (#18970)
strcpy is a dangerous API that should be avoided.
2025-06-28 14:04:39 +02:00
Niels Dossche
737db4a7dc
Use hasThis() where appropriate (#18967)
This macro was introduced to solve false compilers warning about the getThis()
condition not making sense for the address-taken part of the ternary.
2025-06-28 10:12:43 +02:00
DanielEScherzer
171501b93f
Replace @deprecated with #[\Deprecated] for internal constants (#18780)
Only covers constants declared via stub files, others will be handled
separately in a later commit.

Does not include the intl extension, since that had some errors relating to the
cpp code; that extension will be updated separately.
2025-06-26 11:27:15 -07:00
Tim Düsterhus
4c5a6b0e8d
tree-wide: Remove stacktraces from tests testing throwing clones (#18748)
This is in preparation for the possible future transformation of `clone` into a
function call, but also meaningful on its own, since the purpose of the tests
is not to test the stack trace generation, but rather that an exception was
thrown. It also cleans up some unreachable code in the tests.
2025-06-03 20:08:47 +02:00
Gina Peter Banyard
9e67d0baa3 ext/mysqli: Use zval_is_true() instead of converting to boolean 2025-05-31 14:25:43 +01:00
Gina Peter Banyard
340e139ea4 ext/mysqli: Add test for mysqli_object_has_property() object handler 2025-05-31 14:25:43 +01:00
Niels Dossche
c91c6545fe
Drop name from mysqli_prop_handler (#18498)
It's just not necessary to store this, if we ever need this we can get
this from the hash table.
2025-05-05 12:36:26 +01:00
Ilija Tovilo
798e27286e
Merge branch 'PHP-8.4'
* PHP-8.4:
  Fix mysql test date flakiness
2025-03-16 14:26:38 +01:00
Ilija Tovilo
45fc03c190
Fix mysql test date flakiness
Separate date() calls can lead to diverging results.

Closes GH-18080
2025-03-16 14:26:04 +01:00
Ilija Tovilo
e5adfd5d89
Merge branch 'PHP-8.4'
* PHP-8.4:
  Fix flaky connection count in mysqli test
2025-03-13 16:47:36 +01:00
Ilija Tovilo
e624364967
Merge branch 'PHP-8.3' into PHP-8.4
* PHP-8.3:
  Fix flaky connection count in mysqli test
2025-03-13 16:47:29 +01:00
Ilija Tovilo
276c2a67ef
Merge branch 'PHP-8.2' into PHP-8.3
* PHP-8.2:
  Fix flaky connection count in mysqli test
2025-03-13 16:47:20 +01:00
Ilija Tovilo
f390425db3
Merge branch 'PHP-8.1' into PHP-8.2
* PHP-8.1:
  Fix flaky connection count in mysqli test
2025-03-13 16:46:03 +01:00
Ilija Tovilo
00ebd2d7f2
Fix flaky connection count in mysqli test
Use connection ID instead of count to check whether we're using a
persistent connection. This allows the test to be run in parallel with
the other tests, but also protects against the possibility that some
other service connects to the mysql server.

Closes GH-18040
2025-03-13 16:40:33 +01:00
Calvin Buckley
eebc7b0a7a
Merge branch 'PHP-8.4'
* PHP-8.4:
  Skip mysqli/tests/bug73462 on PPC CI (#17971)
2025-03-05 10:20:34 -04:00
Calvin Buckley
b2e49c80bf
Merge branch 'PHP-8.3' into PHP-8.4
* PHP-8.3:
  Skip mysqli/tests/bug73462 on PPC CI (#17971)
2025-03-05 10:20:19 -04:00
Calvin Buckley
a30a41af78
Merge branch 'PHP-8.2' into PHP-8.3
* PHP-8.2:
  Skip mysqli/tests/bug73462 on PPC CI (#17971)
2025-03-05 10:19:52 -04:00
Calvin Buckley
1afbaaa804
Merge branch 'PHP-8.1' into PHP-8.2
* PHP-8.1:
  Skip mysqli/tests/bug73462 on PPC CI (#17971)
2025-03-05 10:18:41 -04:00
Calvin Buckley
dc6586dd9d
Skip mysqli/tests/bug73462 on PPC CI (#17971)
* Skip this test on PPC CI

Seems to be unfortunately flaky with persistent connections.

* use spaces in phpt file
2025-03-05 10:17:39 -04:00
Niels Dossche
2b6c9b68bb
Fix GH-17900 and GH-8084
Calling the constructor twice has no real world benefit.
Block it to fix these two issues.
We also clean up the constructor code a bit:
- `in_ctor` implies `object` exist.
- We surround the instance check with ZEND_DEBUG to avoid a runtime
  penalty.

Closes GH-17900.
Closes GH-8084.
Closes GH-17908.
2025-02-24 19:25:08 +01:00
Jakub Zelenka
b60f9bf27a
Merge branch 'PHP-8.4' 2025-01-19 20:39:27 +01:00
Jakub Zelenka
b3c297d88f
Merge branch 'PHP-8.3' into PHP-8.4 2025-01-19 20:38:51 +01:00
Jakub Zelenka
191e16b703
Merge branch 'PHP-8.2' into PHP-8.3 2025-01-19 20:38:19 +01:00
Jakub Zelenka
5d632230ba
Merge branch 'PHP-8.1' into PHP-8.2 2025-01-19 20:37:53 +01:00
Jakub Zelenka
235d1b14a3
Fix GH-17499: mysqli flaky test: ghsa-h35g-vwh6-m678-stmt-row-string 2025-01-19 20:36:12 +01:00
Kamil Tekiela
a883082f87
Improve mysqli_thread_id test (#17515) 2025-01-19 17:54:01 +00:00
Kamil Tekiela
d6d23fe002
Improve bug74021 test (#17514) 2025-01-19 17:53:54 +00:00
Kamil Tekiela
6919b95010
Ensure charset in tests (#17513) 2025-01-19 17:53:37 +00:00
Kamil Tekiela
b47d17188b
Improve mysqli test 066.phpt (#17022) 2024-12-10 02:11:43 +01:00
Jakub Zelenka
8ef9302c31
Merge branch 'PHP-8.4' 2024-12-09 23:38:20 +01:00
Jakub Zelenka
7d77082dca
Merge branch 'PHP-8.3' into PHP-8.4 2024-12-09 23:37:31 +01:00
Jakub Zelenka
5168a2f5ba
Merge branch 'PHP-8.2' into PHP-8.3 2024-12-09 23:37:03 +01:00
Jakub Zelenka
d18768e231
Merge branch 'PHP-8.1' into PHP-8.2 2024-12-09 23:36:36 +01:00
Jakub Zelenka
39c292b1eb
Use empheral port for mysqli fake server tests 2024-12-09 23:34:50 +01:00
Niels Dossche
e36dea065d
Merge branch 'PHP-8.4'
* PHP-8.4:
  Fix some MariaDB test failures
2024-12-02 19:22:27 +01:00
Niels Dossche
6753c55bdb
Merge branch 'PHP-8.3' into PHP-8.4
* PHP-8.3:
  Fix some MariaDB test failures
2024-12-02 19:21:37 +01:00
Niels Dossche
51e0920e45
Merge branch 'PHP-8.2' into PHP-8.3
* PHP-8.2:
  Fix some MariaDB test failures
2024-12-02 19:21:03 +01:00
Niels Dossche
1a6f8a0b79
Fix some MariaDB test failures
Allow other wording too such that these mysqli tests pass.

Closes GH-17004.
2024-12-02 19:20:54 +01:00
Jakub Zelenka
b0b876d076
Merge branch 'PHP-8.4' 2024-11-24 23:50:09 +01:00
Jakub Zelenka
a5db8b3fe5
Merge branch 'PHP-8.3' into PHP-8.4 2024-11-24 23:49:55 +01:00
Jakub Zelenka
ac57b81c7c
Merge branch 'PHP-8.2' into PHP-8.3 2024-11-24 23:49:29 +01:00
Jakub Zelenka
173175badd
Merge branch 'PHP-8.1' into PHP-8.2 2024-11-24 23:49:04 +01:00
Jakub Zelenka
eb951b3d11
Increase MySQLi fake server read timeout for ASAN job 2024-11-24 23:48:27 +01:00
Jakub Zelenka
59ed9cebaa
Merge branch 'PHP-8.4' 2024-11-24 20:16:26 +01:00
Jakub Zelenka
17c93e6c51
Merge branch 'PHP-8.3' into PHP-8.4 2024-11-24 20:16:01 +01:00
Jakub Zelenka
b707f42119
Merge branch 'PHP-8.2' into PHP-8.3 2024-11-24 20:15:02 +01:00
Jakub Zelenka
06082671f4
Merge branch 'PHP-8.1' into PHP-8.2 2024-11-24 20:14:29 +01:00
Jakub Zelenka
51f5539914
Change port for mysqli fake server auth message test 2024-11-24 20:13:47 +01:00
Jakub Zelenka
c70b97d8eb
Make MySQLnd protocol stmt test work on 32bit
Closes GH-16869.
2024-11-20 13:52:53 +01:00
Jakub Zelenka
4b211a7769
Merge branch 'PHP-8.4' 2024-11-20 11:14:32 +01:00