mirror of
https://github.com/php/php-src.git
synced 2025-08-15 13:38:49 +02:00

This is a comprehensive refactoring of the error mechanism of the Intl extension. By moving the prefixing of the current method/function being executed to actual error message creation by accessing the execution context, we get the following benefits: - Accurate error messages indicating *what* call caused the error - As we *always* "copy" the message, the `copyMsg` arg becomes unused, meaning we can reduce the size of the `intl_error` struct by 4 bytes. - Saving it as a zend_string means we know the length of the message - Remove the need to pass around a "function name" `char*` across multiple calls - Use Intl's exception mechanism to generate exceptions for constructor call - This removes the need for replacing the error handler - Which didn't do anything anyway in silent mode, which required throwing non-descriptive exceptions
179 lines
5.2 KiB
C++
179 lines
5.2 KiB
C++
/*
|
|
+----------------------------------------------------------------------+
|
|
| This source file is subject to version 3.01 of the PHP license, |
|
|
| that is bundled with this package in the file LICENSE, and is |
|
|
| available through the world-wide-web at the following url: |
|
|
| https://www.php.net/license/3_01.txt |
|
|
| If you did not receive a copy of the PHP license and are unable to |
|
|
| obtain it through the world-wide-web, please send a note to |
|
|
| license@php.net so we can mail you a copy immediately. |
|
|
+----------------------------------------------------------------------+
|
|
| Authors: Gustavo Lopes <cataphract@php.net> |
|
|
+----------------------------------------------------------------------+
|
|
*/
|
|
|
|
#include <unicode/rbbi.h>
|
|
#include <memory>
|
|
|
|
extern "C" {
|
|
#define USE_BREAKITERATOR_POINTER 1
|
|
#include "breakiterator_class.h"
|
|
#include <zend_exceptions.h>
|
|
#include <limits.h>
|
|
}
|
|
|
|
#include "../intl_convertcpp.h"
|
|
#include "../intl_common.h"
|
|
|
|
using icu::RuleBasedBreakIterator;
|
|
using icu::Locale;
|
|
|
|
static inline RuleBasedBreakIterator *fetch_rbbi(BreakIterator_object *bio) {
|
|
return (RuleBasedBreakIterator*)bio->biter;
|
|
}
|
|
|
|
U_CFUNC PHP_METHOD(IntlRuleBasedBreakIterator, __construct)
|
|
{
|
|
zend_string *rules;
|
|
bool compiled = false;
|
|
UErrorCode status = U_ZERO_ERROR;
|
|
BREAKITER_METHOD_INIT_VARS;
|
|
object = ZEND_THIS;
|
|
|
|
ZEND_PARSE_PARAMETERS_START(1, 2)
|
|
Z_PARAM_STR(rules)
|
|
Z_PARAM_OPTIONAL
|
|
Z_PARAM_BOOL(compiled)
|
|
ZEND_PARSE_PARAMETERS_END();
|
|
|
|
BREAKITER_METHOD_FETCH_OBJECT_NO_CHECK;
|
|
if (bio->biter) {
|
|
zend_throw_error(NULL, "IntlRuleBasedBreakIterator object is already constructed");
|
|
RETURN_THROWS();
|
|
}
|
|
|
|
RuleBasedBreakIterator *rbbi;
|
|
|
|
if (!compiled) {
|
|
UnicodeString rulesStr;
|
|
UParseError parseError = UParseError();
|
|
if (intl_stringFromChar(rulesStr, ZSTR_VAL(rules), ZSTR_LEN(rules), &status) == FAILURE) {
|
|
zend_throw_exception(IntlException_ce_ptr,
|
|
"IntlRuleBasedBreakIterator::__construct(): rules were not a valid UTF-8 string", 0);
|
|
RETURN_THROWS();
|
|
}
|
|
|
|
rbbi = new RuleBasedBreakIterator(rulesStr, parseError, status);
|
|
intl_error_set_code(NULL, status);
|
|
if (U_FAILURE(status)) {
|
|
smart_str parse_error_str;
|
|
parse_error_str = intl_parse_error_to_string(&parseError);
|
|
zend_throw_exception_ex(IntlException_ce_ptr, 0,
|
|
"IntlRuleBasedBreakIterator::__construct(): "
|
|
"unable to create RuleBasedBreakIterator from rules (%s)",
|
|
parse_error_str.s ? ZSTR_VAL(parse_error_str.s) : "");
|
|
smart_str_free(&parse_error_str);
|
|
delete rbbi;
|
|
RETURN_THROWS();
|
|
}
|
|
} else { // compiled
|
|
rbbi = new RuleBasedBreakIterator(reinterpret_cast<uint8_t *>(ZSTR_VAL(rules)), ZSTR_LEN(rules), status);
|
|
if (U_FAILURE(status)) {
|
|
zend_throw_exception(IntlException_ce_ptr,
|
|
"IntlRuleBasedBreakIterator::__construct(): unable to create instance from compiled rules", 0);
|
|
delete rbbi;
|
|
RETURN_THROWS();
|
|
}
|
|
}
|
|
|
|
breakiterator_object_create(object, rbbi, false);
|
|
}
|
|
|
|
U_CFUNC PHP_METHOD(IntlRuleBasedBreakIterator, getRules)
|
|
{
|
|
BREAKITER_METHOD_INIT_VARS;
|
|
object = ZEND_THIS;
|
|
|
|
ZEND_PARSE_PARAMETERS_NONE();
|
|
|
|
BREAKITER_METHOD_FETCH_OBJECT;
|
|
|
|
zend_string *u8str;
|
|
const UnicodeString rules = fetch_rbbi(bio)->getRules();
|
|
|
|
u8str = intl_charFromString(rules, BREAKITER_ERROR_CODE_P(bio));
|
|
if (!u8str)
|
|
{
|
|
intl_errors_set(BREAKITER_ERROR_P(bio), BREAKITER_ERROR_CODE(bio),
|
|
"Error converting result to UTF-8 string");
|
|
RETURN_FALSE;
|
|
}
|
|
RETVAL_STR(u8str);
|
|
}
|
|
|
|
U_CFUNC PHP_METHOD(IntlRuleBasedBreakIterator, getRuleStatus)
|
|
{
|
|
BREAKITER_METHOD_INIT_VARS;
|
|
object = ZEND_THIS;
|
|
|
|
ZEND_PARSE_PARAMETERS_NONE();
|
|
|
|
BREAKITER_METHOD_FETCH_OBJECT;
|
|
|
|
RETURN_LONG(fetch_rbbi(bio)->getRuleStatus());
|
|
}
|
|
|
|
U_CFUNC PHP_METHOD(IntlRuleBasedBreakIterator, getRuleStatusVec)
|
|
{
|
|
BREAKITER_METHOD_INIT_VARS;
|
|
object = ZEND_THIS;
|
|
|
|
ZEND_PARSE_PARAMETERS_NONE();
|
|
|
|
BREAKITER_METHOD_FETCH_OBJECT;
|
|
|
|
int32_t num_rules = fetch_rbbi(bio)->getRuleStatusVec(NULL, 0,
|
|
BREAKITER_ERROR_CODE(bio));
|
|
|
|
ZEND_ASSERT(BREAKITER_ERROR_CODE(bio) == U_BUFFER_OVERFLOW_ERROR);
|
|
BREAKITER_ERROR_CODE(bio) = U_ZERO_ERROR;
|
|
|
|
std::unique_ptr<int32_t[]> rules = std::unique_ptr<int32_t[]>(new int32_t[num_rules]);
|
|
num_rules = fetch_rbbi(bio)->getRuleStatusVec(rules.get(), num_rules,
|
|
BREAKITER_ERROR_CODE(bio));
|
|
if (U_FAILURE(BREAKITER_ERROR_CODE(bio))) {
|
|
intl_errors_set(BREAKITER_ERROR_P(bio), BREAKITER_ERROR_CODE(bio),
|
|
"failed obtaining the status values");
|
|
RETURN_FALSE;
|
|
}
|
|
|
|
array_init_size(return_value, num_rules);
|
|
for (int32_t i = 0; i < num_rules; i++) {
|
|
add_next_index_long(return_value, rules[i]);
|
|
}
|
|
}
|
|
|
|
U_CFUNC PHP_METHOD(IntlRuleBasedBreakIterator, getBinaryRules)
|
|
{
|
|
BREAKITER_METHOD_INIT_VARS;
|
|
object = ZEND_THIS;
|
|
|
|
ZEND_PARSE_PARAMETERS_NONE();
|
|
|
|
BREAKITER_METHOD_FETCH_OBJECT;
|
|
|
|
uint32_t rules_len;
|
|
const uint8_t *rules = fetch_rbbi(bio)->getBinaryRules(rules_len);
|
|
|
|
if (rules_len > INT_MAX - 1) {
|
|
intl_errors_set(BREAKITER_ERROR_P(bio), BREAKITER_ERROR_CODE(bio),
|
|
"the rules are too large");
|
|
RETURN_FALSE;
|
|
}
|
|
|
|
zend_string *ret_rules = zend_string_alloc(rules_len, 0);
|
|
memcpy(ZSTR_VAL(ret_rules), rules, rules_len);
|
|
ZSTR_VAL(ret_rules)[rules_len] = '\0';
|
|
|
|
RETURN_STR(ret_rules);
|
|
}
|