mirror of
https://github.com/php/php-src.git
synced 2025-08-15 13:38:49 +02:00
6600d0e00f
This is a comprehensive refactoring of the error mechanism of the Intl extension. By moving the prefixing of the current method/function being executed to actual error message creation by accessing the execution context, we get the following benefits: - Accurate error messages indicating *what* call caused the error - As we *always* "copy" the message, the `copyMsg` arg becomes unused, meaning we can reduce the size of the `intl_error` struct by 4 bytes. - Saving it as a zend_string means we know the length of the message - Remove the need to pass around a "function name" `char*` across multiple calls - Use Intl's exception mechanism to generate exceptions for constructor call - This removes the need for replacing the error handler - Which didn't do anything anyway in silent mode, which required throwing non-descriptive exceptions
38 lines
1.3 KiB
C
38 lines
1.3 KiB
C
/*
|
|
+----------------------------------------------------------------------+
|
|
| This source file is subject to version 3.01 of the PHP license, |
|
|
| that is bundled with this package in the file LICENSE, and is |
|
|
| available through the world-wide-web at the following url: |
|
|
| https://www.php.net/license/3_01.txt |
|
|
| If you did not receive a copy of the PHP license and are unable to |
|
|
| obtain it through the world-wide-web, please send a note to |
|
|
| license@php.net so we can mail you a copy immediately. |
|
|
+----------------------------------------------------------------------+
|
|
| Authors: Gustavo Lopes <cataphract@php.net> |
|
|
+----------------------------------------------------------------------+
|
|
*/
|
|
|
|
#ifndef DATEFORMAT_HELPERS_H
|
|
#define DATEFORMAT_HELPERS_H
|
|
|
|
#ifndef __cplusplus
|
|
#error For C++ only
|
|
#endif
|
|
|
|
#include <unicode/calendar.h>
|
|
#include <unicode/datefmt.h>
|
|
|
|
extern "C" {
|
|
#include "../php_intl.h"
|
|
}
|
|
|
|
using icu::Locale;
|
|
using icu::Calendar;
|
|
using icu::DateFormat;
|
|
|
|
zend_result datefmt_process_calendar_arg(
|
|
zend_object *calendar_obj, zend_long calendar_long, bool calendar_is_null, Locale const& locale,
|
|
intl_error *err, Calendar*& cal, zend_long& cal_int_type, bool& calendar_owned
|
|
);
|
|
|
|
#endif /* DATEFORMAT_HELPERS_H */
|