mirror of
https://github.com/php/php-src.git
synced 2025-08-15 21:48:51 +02:00

This is a comprehensive refactoring of the error mechanism of the Intl extension. By moving the prefixing of the current method/function being executed to actual error message creation by accessing the execution context, we get the following benefits: - Accurate error messages indicating *what* call caused the error - As we *always* "copy" the message, the `copyMsg` arg becomes unused, meaning we can reduce the size of the `intl_error` struct by 4 bytes. - Saving it as a zend_string means we know the length of the message - Remove the need to pass around a "function name" `char*` across multiple calls - Use Intl's exception mechanism to generate exceptions for constructor call - This removes the need for replacing the error handler - Which didn't do anything anyway in silent mode, which required throwing non-descriptive exceptions
33 lines
1.4 KiB
PHP
33 lines
1.4 KiB
PHP
--TEST--
|
|
IntlDateFormatter with invalid locale
|
|
--EXTENSIONS--
|
|
intl
|
|
--FILE--
|
|
<?php
|
|
|
|
$locale = 'en_US';
|
|
$timezone = 'GMT+05:12';
|
|
$type = IntlDateFormatter::FULL;
|
|
$invalidCalendar = -1;
|
|
|
|
try {
|
|
$df = new IntlDateFormatter($locale, $type, $type, $timezone, $invalidCalendar);
|
|
} catch (Throwable $e) {
|
|
echo $e::class, ': ', $e->getMessage(), PHP_EOL;
|
|
}
|
|
|
|
$df = IntlDateFormatter::create($locale, $type, $type, $timezone, $invalidCalendar);
|
|
var_dump($df);
|
|
var_dump(intl_get_error_message());
|
|
|
|
$df = datefmt_create($locale, $type, $type, $timezone, $invalidCalendar);
|
|
var_dump($df);
|
|
var_dump(intl_get_error_message());
|
|
|
|
?>
|
|
--EXPECT--
|
|
IntlException: IntlDateFormatter::__construct(): Invalid value for calendar type; it must be one of IntlDateFormatter::TRADITIONAL (locale's default calendar) or IntlDateFormatter::GREGORIAN. Alternatively, it can be an IntlCalendar object
|
|
NULL
|
|
string(245) "IntlDateFormatter::create(): Invalid value for calendar type; it must be one of IntlDateFormatter::TRADITIONAL (locale's default calendar) or IntlDateFormatter::GREGORIAN. Alternatively, it can be an IntlCalendar object: U_ILLEGAL_ARGUMENT_ERROR"
|
|
NULL
|
|
string(234) "datefmt_create(): Invalid value for calendar type; it must be one of IntlDateFormatter::TRADITIONAL (locale's default calendar) or IntlDateFormatter::GREGORIAN. Alternatively, it can be an IntlCalendar object: U_ILLEGAL_ARGUMENT_ERROR"
|