mirror of
https://github.com/php/php-src.git
synced 2025-08-16 05:58:45 +02:00
6600d0e00f
This is a comprehensive refactoring of the error mechanism of the Intl extension. By moving the prefixing of the current method/function being executed to actual error message creation by accessing the execution context, we get the following benefits: - Accurate error messages indicating *what* call caused the error - As we *always* "copy" the message, the `copyMsg` arg becomes unused, meaning we can reduce the size of the `intl_error` struct by 4 bytes. - Saving it as a zend_string means we know the length of the message - Remove the need to pass around a "function name" `char*` across multiple calls - Use Intl's exception mechanism to generate exceptions for constructor call - This removes the need for replacing the error handler - Which didn't do anything anyway in silent mode, which required throwing non-descriptive exceptions
47 lines
1.2 KiB
PHP
47 lines
1.2 KiB
PHP
--TEST--
|
|
numfmt_get_error_message/code()
|
|
--EXTENSIONS--
|
|
intl
|
|
--FILE--
|
|
<?php
|
|
|
|
$nf = new NumberFormatter("en_US", NumberFormatter::CURRENCY);
|
|
$nf->parseCurrency('123.45', $currency);
|
|
var_dump($currency);
|
|
var_dump($nf->getErrorMessage());
|
|
var_dump($nf->getErrorCode());
|
|
|
|
$pos = 0;
|
|
$nf->parseCurrency('123.45', $currency, $pos);
|
|
var_dump($currency);
|
|
var_dump($nf->getErrorMessage());
|
|
var_dump($nf->getErrorCode());
|
|
|
|
$nf = numfmt_create("en_US", NumberFormatter::CURRENCY);
|
|
var_dump(numfmt_parse_currency($nf, '123.45', $currency));
|
|
var_dump($currency);
|
|
var_dump($nf->getErrorMessage());
|
|
var_dump($nf->getErrorCode());
|
|
|
|
$pos = 0;
|
|
var_dump(numfmt_parse_currency($nf, '123.45', $currency, $pos));
|
|
var_dump($currency);
|
|
var_dump($nf->getErrorMessage());
|
|
var_dump($nf->getErrorCode());
|
|
|
|
?>
|
|
--EXPECT--
|
|
NULL
|
|
string(70) "NumberFormatter::parseCurrency(): Number parsing failed: U_PARSE_ERROR"
|
|
int(9)
|
|
NULL
|
|
string(70) "NumberFormatter::parseCurrency(): Number parsing failed: U_PARSE_ERROR"
|
|
int(9)
|
|
bool(false)
|
|
NULL
|
|
string(61) "numfmt_parse_currency(): Number parsing failed: U_PARSE_ERROR"
|
|
int(9)
|
|
bool(false)
|
|
NULL
|
|
string(61) "numfmt_parse_currency(): Number parsing failed: U_PARSE_ERROR"
|
|
int(9)
|