mirror of
https://github.com/php/php-src.git
synced 2025-08-15 13:38:49 +02:00
6600d0e00f
This is a comprehensive refactoring of the error mechanism of the Intl extension. By moving the prefixing of the current method/function being executed to actual error message creation by accessing the execution context, we get the following benefits: - Accurate error messages indicating *what* call caused the error - As we *always* "copy" the message, the `copyMsg` arg becomes unused, meaning we can reduce the size of the `intl_error` struct by 4 bytes. - Saving it as a zend_string means we know the length of the message - Remove the need to pass around a "function name" `char*` across multiple calls - Use Intl's exception mechanism to generate exceptions for constructor call - This removes the need for replacing the error handler - Which didn't do anything anyway in silent mode, which required throwing non-descriptive exceptions
30 lines
737 B
PHP
30 lines
737 B
PHP
--TEST--
|
|
MessageFormatter with invalid locale
|
|
--EXTENSIONS--
|
|
intl
|
|
--FILE--
|
|
<?php
|
|
|
|
$fmt = '{0,whatever} would not work!';
|
|
|
|
try {
|
|
$mf = new MessageFormatter('root', $fmt);
|
|
} catch (Throwable $e) {
|
|
echo $e::class, ': ', $e->getMessage(), PHP_EOL;
|
|
}
|
|
|
|
$mf = MessageFormatter::create('root', $fmt);
|
|
var_dump($mf);
|
|
var_dump(intl_get_error_message());
|
|
|
|
$mf = msgfmt_create('root', $fmt);
|
|
var_dump($mf);
|
|
var_dump(intl_get_error_message());
|
|
|
|
?>
|
|
--EXPECT--
|
|
IntlException: MessageFormatter::__construct(): message formatter creation failed
|
|
NULL
|
|
string(87) "MessageFormatter::create(): message formatter creation failed: U_ILLEGAL_ARGUMENT_ERROR"
|
|
NULL
|
|
string(76) "msgfmt_create(): message formatter creation failed: U_ILLEGAL_ARGUMENT_ERROR"
|