mirror of
https://github.com/php/php-src.git
synced 2025-08-15 13:38:49 +02:00
6600d0e00f
This is a comprehensive refactoring of the error mechanism of the Intl extension. By moving the prefixing of the current method/function being executed to actual error message creation by accessing the execution context, we get the following benefits: - Accurate error messages indicating *what* call caused the error - As we *always* "copy" the message, the `copyMsg` arg becomes unused, meaning we can reduce the size of the `intl_error` struct by 4 bytes. - Saving it as a zend_string means we know the length of the message - Remove the need to pass around a "function name" `char*` across multiple calls - Use Intl's exception mechanism to generate exceptions for constructor call - This removes the need for replacing the error handler - Which didn't do anything anyway in silent mode, which required throwing non-descriptive exceptions
27 lines
700 B
PHP
27 lines
700 B
PHP
--TEST--
|
|
MessageFormatter::parseMessage() with invalid locale
|
|
--EXTENSIONS--
|
|
intl
|
|
--CREDITS--
|
|
girgias@php.net
|
|
--FILE--
|
|
<?php
|
|
|
|
$locale = 'root';
|
|
$fmt = '{0,whatever} would not work!';
|
|
$str = '4,560 monkeys on 123 trees make 37.073 monkeys per tree';
|
|
|
|
$m = MessageFormatter::parseMessage($locale, $fmt, $str);
|
|
var_dump($m);
|
|
var_dump(intl_get_error_message());
|
|
|
|
$m = msgfmt_parse_message($locale, $fmt, $str);
|
|
var_dump($m);
|
|
var_dump(intl_get_error_message());
|
|
|
|
?>
|
|
--EXPECT--
|
|
bool(false)
|
|
string(93) "MessageFormatter::parseMessage(): Creating message formatter failed: U_ILLEGAL_ARGUMENT_ERROR"
|
|
bool(false)
|
|
string(83) "msgfmt_parse_message(): Creating message formatter failed: U_ILLEGAL_ARGUMENT_ERROR"
|