mirror of
https://github.com/php/php-src.git
synced 2025-08-15 21:48:51 +02:00
6600d0e00f
This is a comprehensive refactoring of the error mechanism of the Intl extension. By moving the prefixing of the current method/function being executed to actual error message creation by accessing the execution context, we get the following benefits: - Accurate error messages indicating *what* call caused the error - As we *always* "copy" the message, the `copyMsg` arg becomes unused, meaning we can reduce the size of the `intl_error` struct by 4 bytes. - Saving it as a zend_string means we know the length of the message - Remove the need to pass around a "function name" `char*` across multiple calls - Use Intl's exception mechanism to generate exceptions for constructor call - This removes the need for replacing the error handler - Which didn't do anything anyway in silent mode, which required throwing non-descriptive exceptions
25 lines
685 B
PHP
25 lines
685 B
PHP
--TEST--
|
|
Test ResourceBundle::get() missing keys
|
|
--EXTENSIONS--
|
|
intl
|
|
--FILE--
|
|
<?php
|
|
include "resourcebundle.inc";
|
|
|
|
$bundle = new ResourceBundle('en_US', BUNDLE);
|
|
var_dump($bundle->get('nonexisting'));
|
|
var_dump(intl_get_error_message());
|
|
|
|
var_dump(resourcebundle_get($bundle, 'nonexisting'));
|
|
var_dump(intl_get_error_message());
|
|
|
|
// Make sure accessing existing after non-existing works.
|
|
var_dump($bundle->get('teststring'));
|
|
|
|
?>
|
|
--EXPECT--
|
|
NULL
|
|
string(91) "ResourceBundle::get(): Cannot load resource element 'nonexisting': U_MISSING_RESOURCE_ERROR"
|
|
NULL
|
|
string(90) "resourcebundle_get(): Cannot load resource element 'nonexisting': U_MISSING_RESOURCE_ERROR"
|
|
string(12) "Hello World!"
|