mirror of
https://github.com/php/php-src.git
synced 2025-08-16 14:08:47 +02:00
73b1ebfa20
We use linker relocations to fetch the TLS index and offset of _tsrm_ls_cache.
When building Opcache statically, linkers may attempt to optimize that into a
more efficient code sequence (relaxing from "General Dynamic" to "Local Exec"
model [1]). Unfortunately, linkers will fail, rather than ignore our
relocations, when they don't recognize the exact code sequence they are
expecting.
This results in errors as reported by GH-15074:
TLS transition from R_X86_64_TLSGD to R_X86_64_GOTTPOFF against
`_tsrm_ls_cache' at 0x12fc3 in section `.text' failed"
Here I take a different approach:
* Emit the exact full code sequence expected by linkers
* Extract the TLS index/offset by inspecting the linked ASM code, rather than
executing it (execution would give us the thread-local address).
* We detect when the code was relaxed, in which case we can extract the TCB
offset instead.
* This is done in a conservative way so that if the linker did something we
didn't expect, we fallback to a safer (but slower) mechanism.
One additional benefit of that is we are now able to use the Local Exec model in
more cases, in JIT'ed code. This makes non-glibc builds faster in these cases.
Closes GH-18939.
Related RFC: https://wiki.php.net/rfc/make_opcache_required.
[1] https://www.akkadia.org/drepper/tls.pdf
28 lines
644 B
C
28 lines
644 B
C
|
|
/* _tsrm_ls_cache is used / inspected here */
|
|
|
|
#include "../zend_jit_tls.h"
|
|
|
|
extern __thread void* _tsrm_ls_cache;
|
|
|
|
int test(void)
|
|
{
|
|
size_t tcb_offset = 0;
|
|
size_t module_index = -1;
|
|
size_t module_offset = -1;
|
|
|
|
/* Ensure the slot is allocated */
|
|
_tsrm_ls_cache = NULL;
|
|
|
|
zend_result result = zend_jit_resolve_tsrm_ls_cache_offsets(
|
|
&tcb_offset, &module_index, &module_offset);
|
|
|
|
printf("tcb_offset: %zd; module_index: %zd; module_offset: %zd\n",
|
|
tcb_offset, module_index, module_offset);
|
|
|
|
if (result != SUCCESS) {
|
|
return 0;
|
|
}
|
|
|
|
return zend_jit_tsrm_ls_cache_address(tcb_offset, module_index, module_offset) == &_tsrm_ls_cache;
|
|
}
|