mirror of
https://github.com/php/php-src.git
synced 2025-08-15 13:38:49 +02:00
6600d0e00f
This is a comprehensive refactoring of the error mechanism of the Intl extension. By moving the prefixing of the current method/function being executed to actual error message creation by accessing the execution context, we get the following benefits: - Accurate error messages indicating *what* call caused the error - As we *always* "copy" the message, the `copyMsg` arg becomes unused, meaning we can reduce the size of the `intl_error` struct by 4 bytes. - Saving it as a zend_string means we know the length of the message - Remove the need to pass around a "function name" `char*` across multiple calls - Use Intl's exception mechanism to generate exceptions for constructor call - This removes the need for replacing the error handler - Which didn't do anything anyway in silent mode, which required throwing non-descriptive exceptions
39 lines
1.1 KiB
PHP
39 lines
1.1 KiB
PHP
--TEST--
|
|
IntlCalendar::getErrorCode(), ::getErrorMessage() basic test
|
|
--INI--
|
|
date.timezone=Atlantic/Azores
|
|
--EXTENSIONS--
|
|
intl
|
|
--FILE--
|
|
<?php
|
|
ini_set("intl.error_level", E_WARNING);
|
|
ini_set("intl.default_locale", "nl");
|
|
|
|
$intlcal = IntlGregorianCalendar::createFromDate(2012, 1, 29);
|
|
var_dump(
|
|
$intlcal->getErrorCode(),
|
|
intlcal_get_error_code($intlcal),
|
|
$intlcal->getErrorMessage(),
|
|
intlcal_get_error_message($intlcal)
|
|
);
|
|
$intlcal->add(IntlCalendar::FIELD_SECOND, 2147483647);
|
|
$intlcal->fieldDifference(-PHP_INT_MAX, IntlCalendar::FIELD_SECOND);
|
|
|
|
var_dump(
|
|
$intlcal->getErrorCode(),
|
|
intlcal_get_error_code($intlcal),
|
|
$intlcal->getErrorMessage(),
|
|
intlcal_get_error_message($intlcal)
|
|
);
|
|
?>
|
|
--EXPECTF--
|
|
int(0)
|
|
int(0)
|
|
string(12) "U_ZERO_ERROR"
|
|
string(12) "U_ZERO_ERROR"
|
|
|
|
Warning: IntlCalendar::fieldDifference(): Call to ICU method has failed in %s on line %d
|
|
int(1)
|
|
int(1)
|
|
string(88) "IntlCalendar::fieldDifference(): Call to ICU method has failed: U_ILLEGAL_ARGUMENT_ERROR"
|
|
string(88) "IntlCalendar::fieldDifference(): Call to ICU method has failed: U_ILLEGAL_ARGUMENT_ERROR"
|