mirror of
https://github.com/php/php-src.git
synced 2025-08-17 22:48:57 +02:00
b10416a652
This deprecates passing null to non-nullable scale arguments of internal functions, with the eventual goal of making the behavior consistent with userland functions, where null is never accepted for non-nullable arguments. This change is expected to cause quite a lot of fallout. In most cases, calling code should be adjusted to avoid passing null. In some cases, PHP should be adjusted to make some function arguments nullable. I have already fixed a number of functions before landing this, but feel free to file a bug if you encounter a function that doesn't accept null, but probably should. (The rule of thumb for this to be applicable is that the function must have special behavior for 0 or "", which is distinct from the natural behavior of the parameter.) RFC: https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg Closes GH-6475.
45 lines
1.5 KiB
PHP
45 lines
1.5 KiB
PHP
--TEST--
|
|
XMLReader: libxml2 XML Reader, Move cursor to a named attribute within a namespace, with invalid arguments
|
|
--CREDITS--
|
|
Mark Baker mark@lange.demon.co.uk at the PHPNW2017 Conference for PHP Testfest 2017
|
|
--SKIPIF--
|
|
<?php if (!extension_loaded("xmlreader")) print "skip"; ?>
|
|
--FILE--
|
|
<?php
|
|
// Set up test data in a new file
|
|
$xmlstring = '<?xml version="1.0" encoding="UTF-8"?>
|
|
<books xmlns:ns1="http://www.ns1.namespace.org/" xmlns:ns2="http://www.ns2.namespace.org/"><book ns1:num="1" ns2:idx="2" ns1:idx="3" ns2:isbn="4">book1</book></books>';
|
|
$filename = __DIR__ . '/015-move-errors.xml';
|
|
file_put_contents($filename, $xmlstring);
|
|
|
|
// Load test data into a new XML Reader
|
|
$reader = new XMLReader();
|
|
if (!$reader->open($filename)) {
|
|
exit('XML could not be read');
|
|
}
|
|
|
|
// Parse the data
|
|
while ($reader->read()) {
|
|
if ($reader->nodeType != XMLREADER::END_ELEMENT) {
|
|
// Find the book node
|
|
if ($reader->nodeType == XMLREADER::ELEMENT && $reader->name == 'book') {
|
|
// Test for missing namespace argument
|
|
try {
|
|
$reader->moveToAttributeNs('idx', null);
|
|
} catch (ValueError $exception) {
|
|
echo $exception->getMessage() . "\n";
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
// clean up
|
|
$reader->close();
|
|
?>
|
|
--CLEAN--
|
|
<?php
|
|
unlink(__DIR__.'/015-move-errors.xml');
|
|
?>
|
|
--EXPECTF--
|
|
Deprecated: XMLReader::moveToAttributeNs(): Passing null to parameter #2 ($namespace) of type string is deprecated in %s on line %d
|
|
XMLReader::moveToAttributeNs(): Argument #2 ($namespace) cannot be empty
|